Issue 618103 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	msw@chromium.org
Closed:	Jun 2016
Cc:	█ fsam...@chromium.org
Components:	Internals>Mojo Internals>Skia Tests>Missing
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	3
Type:	Bug
mustash mash

Add unittests for Mojo SkBitmap struct traits.

Project Member Reported by msw@chromium.org, Jun 7 2016

Issue description

Add unittests for Mojo SkBitmap struct traits.

I removed the type converters and added bitmap StructTraits in this CL:
  https://codereview.chromium.org/2014013002

We need unit tests for the struct traits, akin to those for image filter:
  https://codereview.chromium.org/2040233002

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2e406d650bf90ed420197a38e5da0c438f8e072

commit e2e406d650bf90ed420197a38e5da0c438f8e072
Author: msw <msw@chromium.org>
Date: Wed Jun 08 15:52:51 2016

Add basic SkBitmap StructTraitsTest.

BUG= 618103 
TEST=automated
R=reed@chromium.org

Review-Url: https://codereview.chromium.org/2044313002
Cr-Commit-Position: refs/heads/master@{#398571}

[modify] https://crrev.com/e2e406d650bf90ed420197a38e5da0c438f8e072/skia/public/interfaces/test/struct_traits_unittest.cc
[modify] https://crrev.com/e2e406d650bf90ed420197a38e5da0c438f8e072/skia/public/interfaces/test/traits_test_service.mojom

Comment 2 by msw@chromium.org, Jun 8 2016

Status: Fixed (was: Assigned)

►

Issue 618103 link

Issue metadata

Add unittests for Mojo SkBitmap struct traits.

Issue description

Comment 1 by bugdroid1@chromium.org, Jun 8 2016

Comment 1 Deleted

Comment 2 by msw@chromium.org, Jun 8 2016

Comment 2 Deleted

Sign in to add a comment