Sync error notification badge is different on Mac |
||||||||
Issue descriptionENVIRONMENT and STATS For syncing clients: Chrome version: 53.0.2761.0 OS: Mac REPRO STEPS 1. Sign in to Chrome on multiple clients. 2. Go to advanced sync settings. 3. Change the encryption settings to "All data was encrypted with...." 4. Make sure that "Sync error:Update sync passphrase..." message shows up in the settings menu of all the syncing clients. ACTUAL RESULTS Observe that on windows machine there is a new orange badge (see the attached screenshot) On Mac machine there is no orange badge. EXPECTED RESULTS Sync error notification badge should look the same on all the desktop clients
,
Jun 9 2016
,
Jun 9 2016
shrike@: could you triage. On mac UpdateBadgeSeverity is handled in toolbar_controller.mm. It seems not to take BadgeType parameter into account.
,
Jun 9 2016
,
Jun 9 2016
The new sync notification icons recently landed (replacing the three dots of the old "hamburger menu"). I thought the new icons would just show up for us on the Mac but apparently not. spqchan@ - would you please make the necessary changes to get the icons to show up? This will be for M53 (so no time pressure to try to cherry-pick back to M52).
,
Jun 10 2016
A second cl landed for Issue 584342 - the badges not showing up may have been because only the first cl had landed. We should see what the next Canary looks like before proceeding.
,
Jun 13 2016
,
Jul 6 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 21 2016
This has been fixed long time back and also the sync error notification has been moved to the profile menu recently. Closing the bug. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by pav...@chromium.org
, Jun 8 2016