Issue metadata
Sign in to add a comment
|
printing/thead-repeats-at-top-of-each-page.html needs another rebaseline |
||||||||||||||||||||||
Issue descriptionThese two tests: printing/thead-repeats-at-top-of-each-page.html virtual/threaded/printing/thead-repeats-at-top-of-each-page.html are failing on WebKit Win10 here: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10
,
Jun 8 2016
I will label this test as failing because I am not familiar with webkit tests. I observed that https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/10960 is the first build in which the tests failed, which contains a rebaselining https://chromium.googlesource.com/chromium/src/+/d3fafe01982462138b0f82e75649e65370ca9111
,
Jun 8 2016
For windows bots, sometimes NeedsRebaseLine can be skipped. I think this test just needs another rebaseline. I will file a CL.
,
Jun 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51ddb081cea0371a8dd329a7cfe2a6973f11b661 commit 51ddb081cea0371a8dd329a7cfe2a6973f11b661 Author: battre <battre@chromium.org> Date: Wed Jun 08 13:51:49 2016 Mark printing/thead-repeats-at-top-of-each-page.html as failing on Win10 BUG= 618082 , 24826 TBR=robhogan@gmail.com NOTRY=true Review-Url: https://codereview.chromium.org/2049013002 Cr-Commit-Position: refs/heads/master@{#398540} [modify] https://crrev.com/51ddb081cea0371a8dd329a7cfe2a6973f11b661/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67a46a72b12d0a556cf0ccec546b08be058771ea commit 67a46a72b12d0a556cf0ccec546b08be058771ea Author: xidachen <xidachen@chromium.org> Date: Wed Jun 08 14:14:23 2016 Rebaseline printing/thead-repeats-at-top-of-each-page.html again It seems that after this rebaseline CL: https://codereview.chromium.org/2042583002 This test is still missing its expected test result on Win 10. This CL sends another rebaseline. See failure here for details: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10 BUG= 618082 Review-Url: https://codereview.chromium.org/2044393002 Cr-Commit-Position: refs/heads/master@{#398545} [modify] https://crrev.com/67a46a72b12d0a556cf0ccec546b08be058771ea/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 8 2016
I have reverted my CL which conflicts with yours.
,
Jun 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b543c2dcaa099f117d2ae56867ed37a05f8807a1 commit b543c2dcaa099f117d2ae56867ed37a05f8807a1 Author: battre <battre@chromium.org> Date: Wed Jun 08 14:38:03 2016 Revert of Mark printing/thead-repeats-at-top-of-each-page.html as failing on Win10 (patchset #1 id:1 of https://codereview.chromium.org/2049013002/ ) Reason for revert: Trybots are unhappy and did not flag it in the CQ. LayoutTests/TestExpectations:1329 Duplicate or ambiguous entry lines LayoutTests/TestExpectations:1075 and LayoutTests/TestExpectations:1329. printing/thead-repeats-at-top-of-each-page.html LayoutTests/TestExpectations:1330 Duplicate or ambiguous entry lines LayoutTests/TestExpectations:1076 and LayoutTests/TestExpectations:1330. virtual/threaded/printing/thead-repeats-at-top-of-each-page.html Original issue's description: > Mark printing/thead-repeats-at-top-of-each-page.html as failing on Win10 > > BUG= 618082 , 24826 > TBR=robhogan@gmail.com > NOTRY=true > > Committed: https://crrev.com/51ddb081cea0371a8dd329a7cfe2a6973f11b661 > Cr-Commit-Position: refs/heads/master@{#398540} TBR=robhogan@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 618082 , 24826 Review-Url: https://codereview.chromium.org/2049073002 Cr-Commit-Position: refs/heads/master@{#398547} [modify] https://crrev.com/b543c2dcaa099f117d2ae56867ed37a05f8807a1/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18e991c5df9f8926212a26e6e7267199034a2ba5 commit 18e991c5df9f8926212a26e6e7267199034a2ba5 Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Wed Jun 08 15:54:08 2016 Auto-rebaseline for r398545 https://chromium.googlesource.com/chromium/src/+/67a46a72b BUG= 618082 TBR=xidachen@chromium.org Review URL: https://codereview.chromium.org/2043383002 . Cr-Commit-Position: refs/heads/master@{#398574} [modify] https://crrev.com/18e991c5df9f8926212a26e6e7267199034a2ba5/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/18e991c5df9f8926212a26e6e7267199034a2ba5/third_party/WebKit/LayoutTests/platform/win/printing/thead-repeats-at-top-of-each-page-expected.png [modify] https://crrev.com/18e991c5df9f8926212a26e6e7267199034a2ba5/third_party/WebKit/LayoutTests/platform/win/printing/thead-repeats-at-top-of-each-page-expected.txt [add] https://crrev.com/18e991c5df9f8926212a26e6e7267199034a2ba5/third_party/WebKit/LayoutTests/platform/win7/printing/thead-repeats-at-top-of-each-page-expected.txt
,
Jun 8 2016
These two tests seem to fail on Win10 even after rebaseline: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/11102 robhogan@: please have a look.
,
Jun 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f797718e65758bc29758d1f8ecbea97aa241812 commit 7f797718e65758bc29758d1f8ecbea97aa241812 Author: xidachen <xidachen@chromium.org> Date: Wed Jun 08 19:38:20 2016 Mark printing/thead-repeats-at-top-of-each-page.html as failure printing/thead-repeats-at-top-of-each-page.html virtual/threaded/printing/thead-repeats-at-top-of-each-page.html fails on Win10 even after rebaseline https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/11102 BUG= 618082 NOTRY=true TBR=robhogan@gmail.com Review-Url: https://codereview.chromium.org/2045013006 Cr-Commit-Position: refs/heads/master@{#398641} [modify] https://crrev.com/7f797718e65758bc29758d1f8ecbea97aa241812/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 18 2016
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e97add117956e4d880a8d42fececee504040bc3 commit 9e97add117956e4d880a8d42fececee504040bc3 Author: Stefan Zager <szager@chromium.org> Date: Tue Nov 21 20:58:08 2017 Fix win-specific baselines for printing layout test The previous platform/win expected.png file was not a printing layout. Bug: 618082 Change-Id: I73c5d69a4f5d45086d974178f2d21151f5bb10d5 Reviewed-on: https://chromium-review.googlesource.com/781980 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#518386} [modify] https://crrev.com/9e97add117956e4d880a8d42fececee504040bc3/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/9e97add117956e4d880a8d42fececee504040bc3/third_party/WebKit/LayoutTests/platform/win/printing/thead-repeats-at-top-of-each-page-expected.png [modify] https://crrev.com/9e97add117956e4d880a8d42fececee504040bc3/third_party/WebKit/LayoutTests/platform/win/printing/thead-repeats-at-top-of-each-page-expected.txt [delete] https://crrev.com/cf947e084cfb8f06bf8b75fa3bab4e3b90fda696/third_party/WebKit/LayoutTests/platform/win7/printing/thead-repeats-at-top-of-each-page-expected.png [delete] https://crrev.com/cf947e084cfb8f06bf8b75fa3bab4e3b90fda696/third_party/WebKit/LayoutTests/platform/win7/printing/thead-repeats-at-top-of-each-page-expected.txt |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by battre@chromium.org
, Jun 8 2016Labels: -Pri-3 Pri-1