New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618081 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Disable autoplay muted video via autoplay setting

Project Member Reported by mlamouri@chromium.org, Jun 7 2016

Issue description

We did introduce an autoplay setting in M52. We should re-use it to disable the feature in M53.e
 
Cc: mlamouri@chromium.org
Owner: avayvod@chromium.org
Status: Started (was: Assigned)
I guess avayvod@ already started this :)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d05e65d8ab098888e1e87cd51f93496e93a8398

commit 5d05e65d8ab098888e1e87cd51f93496e93a8398
Author: avayvod <avayvod@chromium.org>
Date: Fri Jun 10 16:04:46 2016

[Android, Media] Enable autoplay settings for muted autoplay, wired them up to the media element.

Use chrome://flags/#enable-autoplay-muted-videos to enable the autoplay site setting.

Check the setting before allowing muted videos to autoplay.

BUG= 618083 , 618081 
TEST=Manual

Review-Url: https://codereview.chromium.org/2052623002
Cr-Commit-Position: refs/heads/master@{#399199}

[modify] https://crrev.com/5d05e65d8ab098888e1e87cd51f93496e93a8398/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java
[modify] https://crrev.com/5d05e65d8ab098888e1e87cd51f93496e93a8398/third_party/WebKit/LayoutTests/media/autoplay-muted.html
[modify] https://crrev.com/5d05e65d8ab098888e1e87cd51f93496e93a8398/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/5d05e65d8ab098888e1e87cd51f93496e93a8398/third_party/WebKit/Source/core/html/HTMLMediaElement.h

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d05e65d8ab098888e1e87cd51f93496e93a8398

commit 5d05e65d8ab098888e1e87cd51f93496e93a8398
Author: avayvod <avayvod@chromium.org>
Date: Fri Jun 10 16:04:46 2016

[Android, Media] Enable autoplay settings for muted autoplay, wired them up to the media element.

Use chrome://flags/#enable-autoplay-muted-videos to enable the autoplay site setting.

Check the setting before allowing muted videos to autoplay.

BUG= 618083 , 618081 
TEST=Manual

Review-Url: https://codereview.chromium.org/2052623002
Cr-Commit-Position: refs/heads/master@{#399199}

[modify] https://crrev.com/5d05e65d8ab098888e1e87cd51f93496e93a8398/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java
[modify] https://crrev.com/5d05e65d8ab098888e1e87cd51f93496e93a8398/third_party/WebKit/LayoutTests/media/autoplay-muted.html
[modify] https://crrev.com/5d05e65d8ab098888e1e87cd51f93496e93a8398/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/5d05e65d8ab098888e1e87cd51f93496e93a8398/third_party/WebKit/Source/core/html/HTMLMediaElement.h

Sign in to add a comment