New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 618079 link

Starred by 1 user
Status: Fixed
Owner:
█ cco3@chromium.org
Last visit > 30 days ago
Closed: Jul 2016
Cc:
█ animohan@chromium.org
█ scottj@chromium.org
█ mmo...@chromium.org
█ cco3@chromium.org
mattreynolds@chromium.org
█ rzhao@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove settings link from PW Activity

Project Member Reported by mmo...@chromium.org, Jun 7 2016 
Remove the feature which was implemented in #603132, since it was implemented in a way that in inconsistent with other features.

Instead, we can investigate adding a "cog" to the notification itself.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0f304cf34c7a20dcab2f8de8f4941521c6a0f9b

commit b0f304cf34c7a20dcab2f8de8f4941521c6a0f9b
Author: cco3 <cco3@chromium.org>
Date: Tue Jun 21 00:21:15 2016

Remove settings button from Physical Web Activity

Other features in chromium don't link to the settings page, so for
consistency, the Physical Web shouldn't either.

BUG= 618079 

Review-Url: https://codereview.chromium.org/2048793002
Cr-Commit-Position: refs/heads/master@{#400850}

[modify] https://crrev.com/b0f304cf34c7a20dcab2f8de8f4941521c6a0f9b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java

Comment 2 by cco3@chromium.org, Jul 18 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment