Move SendPingback logic to OnFirstBackgroundEvent |
||||
Issue descriptionDue to fast shutdown on android, OnFirstBackgroundEvent would be a better method to use than OnComplete. OnFirstBackgroundEvent does not yet exist, but OnHidden does, and a combination of OnHidden and OnComplete could be used.
,
Jun 23 2016
+bmcquade During the android fast shutdown pathway, we might miss a pingback (or multiple pingbacks if there are multiple tabs). If we also listen to the First Background event, we'll miss fewer.
,
Jul 14 2016
,
Oct 28 2016
ryansturm@: Please say more about what this issue is about.
,
Oct 28 2016
DataReductionProxy only cares about timing events that happen before the first background event. Currently, the pingback is started when the next navigation happens in a tab, but this can be moved up to the earlier of a tab being hidden (background event) or the next navigation happens.
,
Nov 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b2687efe4b3b81aad36cb61d814f45474b1173a commit 0b2687efe4b3b81aad36cb61d814f45474b1173a Author: ryansturm <ryansturm@chromium.org> Date: Sat Nov 05 00:09:31 2016 DRP metrics observer stop observing after hidden This calls SendPingback when the tab is first hidden instead of waiting until the tab is closed. The pingback only carries information about events that happen before hidden. This also allows for some simplification (knowing callbacks will only be called before hidden has happened). BUG= 618072 Review-Url: https://codereview.chromium.org/2478903002 Cr-Commit-Position: refs/heads/master@{#430070} [modify] https://crrev.com/0b2687efe4b3b81aad36cb61d814f45474b1173a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc [modify] https://crrev.com/0b2687efe4b3b81aad36cb61d814f45474b1173a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h [modify] https://crrev.com/0b2687efe4b3b81aad36cb61d814f45474b1173a/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc [modify] https://crrev.com/0b2687efe4b3b81aad36cb61d814f45474b1173a/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.h [modify] https://crrev.com/0b2687efe4b3b81aad36cb61d814f45474b1173a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc [modify] https://crrev.com/0b2687efe4b3b81aad36cb61d814f45474b1173a/chrome/browser/page_load_metrics/page_load_metrics_observer.h [modify] https://crrev.com/0b2687efe4b3b81aad36cb61d814f45474b1173a/chrome/browser/page_load_metrics/page_load_tracker.cc
,
Nov 10 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bengr@chromium.org
, Jun 23 2016