We'll need to think a little bit about which accessibility services on mash are implemented in chrome vs. in the window server. For example, stuff like big cursors, high contrast UI, etc. seem like window server features. I wonder if breaking the existing monolithic a11y delegate into smaller pieces would make it  easier to convert.

We do have a new ui::mojom::AccessibilityManager (just for high contrast at the moment), but a lot of the existing functionality goes through ash/chrome's separate AccessibilityManager for access to profile preferences. I'm taking the approach of converting what we have, and I can make minor tweaks to that, but I'm avoiding a complex overhaul for now. Happy to discuss :)

I think we should punt on a11y for this quarter.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82a84e3797b39944d4485a756f20054dab716ac8

commit 82a84e3797b39944d4485a756f20054dab716ac8
Author: James Cook <jamescook@chromium.org>
Date: Thu Aug 17 22:06:08 2017

cros: Move accessibility pref names into ash

This eventually will allow code in //ash to monitor them directly,
instead of communicating back and forth with //chrome.

See go/mustash-tray-accessibility

TBR=pastarmovj@chromium.org

Bug: 594887,  618070 
Test: compiles, ash_unittests, browser_tests
Change-Id: I40f10186ed790afad698118bf879975111052ca8
Reviewed-on: https://chromium-review.googlesource.com/618083
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495341}
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/ash/public/cpp/ash_pref_names.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/ash/public/cpp/ash_pref_names.h
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/browser/chromeos/accessibility/accessibility_util.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/browser/chromeos/accessibility/magnification_manager.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/browser/chromeos/accessibility/magnification_manager_browsertest.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/browser/chromeos/extensions/accessibility_features_apitest.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/browser/chromeos/extensions/info_private_api.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/browser/chromeos/extensions/info_private_apitest.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/browser/chromeos/policy/login_screen_default_policy_browsertest.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/browser/chromeos/policy/recommendation_restorer.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/browser/extensions/api/preference/preference_api.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/browser/extensions/component_loader_unittest.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/common/pref_names.cc
[modify] https://crrev.com/82a84e3797b39944d4485a756f20054dab716ac8/chrome/common/pref_names.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c3967a5eaa464c3e9b3cef2404a64cebc867341

commit 9c3967a5eaa464c3e9b3cef2404a64cebc867341
Author: James Cook <jamescook@chromium.org>
Date: Thu Aug 17 22:57:20 2017

Revert "cros: Move accessibility pref names into ash"

This reverts commit 82a84e3797b39944d4485a756f20054dab716ac8.

Reason for revert:
build failure on the Ozone Linux bot:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FOzone_Linux%2F19031%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout

Original change's description:
> cros: Move accessibility pref names into ash
> 
> This eventually will allow code in //ash to monitor them directly,
> instead of communicating back and forth with //chrome.
> 
> See go/mustash-tray-accessibility
> 
> TBR=pastarmovj@chromium.org
> 
> Bug: 594887,  618070 
> Test: compiles, ash_unittests, browser_tests
> Change-Id: I40f10186ed790afad698118bf879975111052ca8
> Reviewed-on: https://chromium-review.googlesource.com/618083
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Commit-Queue: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#495341}

TBR=jamescook@chromium.org,pastarmovj@chromium.org,dmazzoni@chromium.org,rockot@chromium.org

Change-Id: Ie7f6d29a6600f4211ec87bb270faee5cc9de490b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 594887,  618070 
Reviewed-on: https://chromium-review.googlesource.com/619628
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495364}
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/ash/public/cpp/ash_pref_names.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/ash/public/cpp/ash_pref_names.h
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/browser/chromeos/accessibility/accessibility_util.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/browser/chromeos/accessibility/magnification_manager.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/browser/chromeos/accessibility/magnification_manager_browsertest.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/browser/chromeos/extensions/accessibility_features_apitest.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/browser/chromeos/extensions/info_private_api.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/browser/chromeos/extensions/info_private_apitest.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/browser/chromeos/policy/login_screen_default_policy_browsertest.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/browser/chromeos/policy/recommendation_restorer.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/browser/extensions/api/preference/preference_api.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/browser/extensions/component_loader_unittest.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/common/pref_names.cc
[modify] https://crrev.com/9c3967a5eaa464c3e9b3cef2404a64cebc867341/chrome/common/pref_names.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c63b9fdd07e09bca185851e72092b4c4cddee45f

commit c63b9fdd07e09bca185851e72092b4c4cddee45f
Author: James Cook <jamescook@chromium.org>
Date: Fri Aug 18 18:48:32 2017

Reland: cros: Move accessibility pref names into ash

Reland of https://chromium-review.googlesource.com/c/618083 which broke
gn check on the Linux Ozone FYI bot.

This eventually will allow code in //ash to monitor them directly,
instead of communicating back and forth with //chrome.

See go/mustash-tray-accessibility

TBR=pastarmovj@chromium.org

Bug: 594887,  618070 
Test: compiles, ash_unittests, browser_tests
Change-Id: I35c6770a1969178fbb43a97716da15e80aed99d6
Reviewed-on: https://chromium-review.googlesource.com/618083
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495341}
Reviewed-on: https://chromium-review.googlesource.com/621447
Cr-Commit-Position: refs/heads/master@{#495630}
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/ash/public/cpp/ash_pref_names.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/ash/public/cpp/ash_pref_names.h
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/browser/chromeos/accessibility/accessibility_util.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/browser/chromeos/accessibility/magnification_manager.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/browser/chromeos/accessibility/magnification_manager_browsertest.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/browser/chromeos/extensions/accessibility_features_apitest.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/browser/chromeos/extensions/info_private_api.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/browser/chromeos/extensions/info_private_apitest.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/browser/chromeos/policy/login_screen_default_policy_browsertest.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/browser/chromeos/policy/recommendation_restorer.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/browser/extensions/api/preference/preference_api.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/browser/extensions/component_loader_unittest.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/common/pref_names.cc
[modify] https://crrev.com/c63b9fdd07e09bca185851e72092b4c4cddee45f/chrome/common/pref_names.h

Let me take this one, partly because it is blocking  issue 783058 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a

commit 4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a
Author: Qiang Xu <warx@chromium.org>
Date: Fri Nov 10 02:14:30 2017

mash: move accessibility_types.h to ash/public/cpp/

changes:
- Move accessibility_types.h to ash/public/cpp/ since it is used in
  both ash/ and chrome/.
- Move kMagnificationScaleFactor to ash::MagnificationController.

Majorly done by tools/git/move_source_file.py

Bug:  618070 
Test: still compiles
Change-Id: Id8e641cc34d22395d12755df3ef372eb53187254
Reviewed-on: https://chromium-review.googlesource.com/761337
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515421}
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/ash/BUILD.gn
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/ash/accelerators/accelerator_controller_delegate_classic.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/ash/accelerators/spoken_feedback_toggler.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/ash/accessibility/accessibility_delegate.h
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/ash/accessibility/default_accessibility_delegate.h
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/ash/magnifier/magnification_controller.h
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/ash/magnifier/magnification_controller_unittest.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/ash/public/cpp/BUILD.gn
[rename] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/ash/public/cpp/accessibility_types.h
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/ash/system/accessibility_observer.h
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/ash/system/ime/tray_ime_chromeos_unittest.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/ash/system/tray_accessibility.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/chrome/browser/chromeos/accessibility/chromevox_panel.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/chrome/browser/chromeos/accessibility/magnification_manager.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/chrome/browser/chromeos/accessibility/magnification_manager_unittest.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/chrome/browser/chromeos/policy/login_screen_default_policy_browsertest.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/chrome/browser/ui/ash/ash_init.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/chrome/browser/ui/ash/volume_controller_browsertest.cc
[modify] https://crrev.com/4cfec6e63721b2e1fe8a13f15d8b471a3d26da6a/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0133ccb0c8a735b9d0ca7870b17b342be8bc681d

commit 0133ccb0c8a735b9d0ca7870b17b342be8bc681d
Author: Qiang Xu <warx@chromium.org>
Date: Mon Nov 13 23:32:06 2017

mash: move TriggerAccessibilityAlert to AccessibilityController

changes:
move TriggerAccessibilityAlert from AccessibilityDelegate to
AccessibilityController. This is part of mash work aimed at removing
AccessibilityDelegate.

Bug:  618070 
Test: covered by tests
Change-Id: Ic5c026df5a33516e135be5edf38f6fea4cf1d9dc
Reviewed-on: https://chromium-review.googlesource.com/764597
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516097}
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/BUILD.gn
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/accessibility/accessibility_delegate.h
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/accessibility/default_accessibility_delegate.cc
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/accessibility/default_accessibility_delegate.h
[add] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/accessibility/test_accessibility_controller_client.cc
[add] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/accessibility/test_accessibility_controller_client.h
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/mojo_interface_factory.cc
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/mus/manifest.json
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/public/cpp/accessibility_types.h
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/public/interfaces/BUILD.gn
[add] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/public/interfaces/accessibility_controller.mojom
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/system/power/power_button_display_controller.cc
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/system/power/tablet_power_button_controller_unittest.cc
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/system/tray_caps_lock.cc
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/system/tray_caps_lock_unittest.cc
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/chrome/browser/ui/ash/accessibility/accessibility_controller_client.cc
[add] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/chrome/browser/ui/ash/accessibility/accessibility_controller_client.h
[add] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/chrome/browser/ui/ash/accessibility/accessibility_controller_client_unittest.cc
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.h
[modify] https://crrev.com/0133ccb0c8a735b9d0ca7870b17b342be8bc681d/chrome/test/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19edeba743c8addc335938520ed222386b282551

commit 19edeba743c8addc335938520ed222386b282551
Author: Qiang Xu <warx@chromium.org>
Date: Tue Nov 14 00:26:22 2017

mash: fix SpokenFeedbackTest.OverviewMode test failure

changes:
Test failure is because chrome side doesn't do bind and set client to
ash. This should go with crrev.com/c/761337, however that cl was merged
before I uploaded the fix.

TBR=jamescook@chromium.org

Bug:  618070 
Test: interactive_ui_tests saw it fixed
Change-Id: I497442e71f4e3766d8f948c5889fee6871a2f1d3
Reviewed-on: https://chromium-review.googlesource.com/767731
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516115}
[modify] https://crrev.com/19edeba743c8addc335938520ed222386b282551/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09d525a9a5fb5da068a415342f9fe91b7cd267b8

commit 09d525a9a5fb5da068a415342f9fe91b7cd267b8
Author: Qiang Xu <warx@chromium.org>
Date: Thu Nov 30 04:41:14 2017

mash: convert PlayEarcon/PlayShutdownSound through mojo call

changes:
- Remove PlayEarcon/PlayShutdownSound from ash::AccessibilityDelegate.
  Convert them calling into chrome through mojo call.
- PlayShutdownSound gets shutdown sound duration asynchronously from
  chrome in ash::AccessibilityController. Synchronize the real shutdown
  timer's beginning when getting shutdown sound duration.

TBR=xiyuan@chromium.org

work when SpokenFeedbackEnabled is moved to ash. And add several test
coverage.

Bug:  618070 
Test: tested on device without --mash, it works fine. --mash should
Change-Id: I82b3ce684983e3de658e8d165f90a47cf754f4f6
Reviewed-on: https://chromium-review.googlesource.com/773629
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520441}
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/ash/BUILD.gn
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/ash/accessibility/accessibility_controller_unittest.cc
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/ash/accessibility/accessibility_delegate.h
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/ash/accessibility/default_accessibility_delegate.cc
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/ash/accessibility/default_accessibility_delegate.h
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/ash/accessibility/test_accessibility_controller_client.cc
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/ash/accessibility/test_accessibility_controller_client.h
[delete] https://crrev.com/2eb7a48bfb55e003aad26091a951353ed96c7750/ash/accessibility/test_accessibility_delegate.cc
[delete] https://crrev.com/2eb7a48bfb55e003aad26091a951353ed96c7750/ash/accessibility/test_accessibility_delegate.h
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/ash/public/interfaces/accessibility_controller.mojom
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/ash/test_shell_delegate.cc
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/ash/wm/lock_state_controller.cc
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/ash/wm/lock_state_controller_unittest.cc
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/ash/wm/workspace/backdrop_controller.cc
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/chrome/browser/ui/ash/accessibility/accessibility_controller_client.cc
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/chrome/browser/ui/ash/accessibility/accessibility_controller_client.h
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/chrome/browser/ui/ash/accessibility/accessibility_controller_client_unittest.cc
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/chrome/browser/ui/ash/volume_controller.cc
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
[modify] https://crrev.com/09d525a9a5fb5da068a415342f9fe91b7cd267b8/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51b77306ffe5cdb87601225e0c4b045fd1b78994

commit 51b77306ffe5cdb87601225e0c4b045fd1b78994
Author: Qiang(Joe) Xu <warx@chromium.org>
Date: Fri Dec 01 01:06:03 2017

Revert "mash: convert PlayEarcon/PlayShutdownSound through mojo call"

This reverts commit 09d525a9a5fb5da068a415342f9fe91b7cd267b8.

Reason for revert: revert for a clean revert of crrev.com/c/777780

Original change's description:
> mash: convert PlayEarcon/PlayShutdownSound through mojo call
> 
> changes:
> - Remove PlayEarcon/PlayShutdownSound from ash::AccessibilityDelegate.
>   Convert them calling into chrome through mojo call.
> - PlayShutdownSound gets shutdown sound duration asynchronously from
>   chrome in ash::AccessibilityController. Synchronize the real shutdown
>   timer's beginning when getting shutdown sound duration.
> 
> TBR=xiyuan@chromium.org
> 
> work when SpokenFeedbackEnabled is moved to ash. And add several test
> coverage.
> 
> Bug:  618070 
> Test: tested on device without --mash, it works fine. --mash should
> Change-Id: I82b3ce684983e3de658e8d165f90a47cf754f4f6
> Reviewed-on: https://chromium-review.googlesource.com/773629
> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
> Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520441}

TBR=jamescook@chromium.org,xiyuan@chromium.org,dmazzoni@chromium.org,dtseng@chromium.org,tsepez@chromium.org,warx@chromium.org

Change-Id: I3673182425fa0cb4702036d326b83a275415d5de
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  618070 ,  790750 
Reviewed-on: https://chromium-review.googlesource.com/802614
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520780}
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/BUILD.gn
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/accessibility/accessibility_controller_unittest.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/accessibility/accessibility_delegate.h
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/accessibility/default_accessibility_delegate.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/accessibility/default_accessibility_delegate.h
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/accessibility/test_accessibility_controller_client.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/accessibility/test_accessibility_controller_client.h
[add] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/accessibility/test_accessibility_delegate.cc
[add] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/accessibility/test_accessibility_delegate.h
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/public/interfaces/accessibility_controller.mojom
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/test_shell_delegate.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/wm/lock_state_controller.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/wm/lock_state_controller_unittest.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/wm/workspace/backdrop_controller.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/ui/ash/accessibility/accessibility_controller_client.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/ui/ash/accessibility/accessibility_controller_client.h
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/ui/ash/accessibility/accessibility_controller_client_unittest.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/ui/ash/volume_controller.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89af823eeee241570872af2c084fad53b74f6713

commit 89af823eeee241570872af2c084fad53b74f6713
Author: Qiang Xu <warx@chromium.org>
Date: Tue Dec 05 04:04:47 2017

Reland: mash: Convert PlayEarcon/PlayShutdownSound through mojo call

This CL description:
- This CL could be landed before ash could learn/control spoken
  feedback enabled state. Ash will call PlayEarcon/PlayShutdownSound
  any time the caller wants, it bails out on chrome side if spoken
  feedback is not enabled.

original CL description:
- Remove PlayEarcon/PlayShutdownSound from ash::AccessibilityDelegate.
  Convert them calling into chrome through mojo call.
- PlayShutdown sound gets shutdown sound duration asynchronously from
  chrome in ash::AccessibilityController. Callback runs to start real
  shutdown timer when getting shutdown sound duration.

TBR=jamescook@chromium.org, xiyuan@chromium.org, dmazzoni@chromium.org
TBR=tsepez@chromium.org

Bug:  618070 
Test: tested on device without --mash, it works fine.
Change-Id: Ie1e04825640bb286e8676121e591810872c9417c
Reviewed-on: https://chromium-review.googlesource.com/805361
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521610}
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/ash/BUILD.gn
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/ash/accessibility/accessibility_controller_unittest.cc
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/ash/accessibility/accessibility_delegate.h
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/ash/accessibility/default_accessibility_delegate.cc
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/ash/accessibility/default_accessibility_delegate.h
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/ash/accessibility/test_accessibility_controller_client.cc
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/ash/accessibility/test_accessibility_controller_client.h
[delete] https://crrev.com/380025fc0e608129ad2591b64a39bcf43455a1a8/ash/accessibility/test_accessibility_delegate.cc
[delete] https://crrev.com/380025fc0e608129ad2591b64a39bcf43455a1a8/ash/accessibility/test_accessibility_delegate.h
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/ash/public/interfaces/accessibility_controller.mojom
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/ash/test_shell_delegate.cc
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/ash/wm/lock_state_controller.cc
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/ash/wm/lock_state_controller_unittest.cc
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/ash/wm/workspace/backdrop_controller.cc
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/chrome/browser/ui/ash/accessibility/accessibility_controller_client.cc
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/chrome/browser/ui/ash/accessibility/accessibility_controller_client.h
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/chrome/browser/ui/ash/accessibility/accessibility_controller_client_unittest.cc
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/chrome/browser/ui/ash/volume_controller.cc
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
[modify] https://crrev.com/89af823eeee241570872af2c084fad53b74f6713/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e12fa765e2b878bb57c1d6a73655e0f162e7027

commit 9e12fa765e2b878bb57c1d6a73655e0f162e7027
Author: Qiang Xu <warx@chromium.org>
Date: Tue Dec 19 03:27:49 2017

mash: Convert HandleAccessibilityGesture method through mojo

changes:
Convert HandleAccessibilityGesture method through mojo.

Bug:  618070 
Test: device test and added test coverage
Change-Id: Iedff4da81aba39c179057cb354c3ba5a54f29257
Reviewed-on: https://chromium-review.googlesource.com/826922
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524933}
[modify] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/BUILD.gn
[modify] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/accessibility/accessibility_delegate.h
[modify] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/accessibility/default_accessibility_delegate.cc
[modify] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/accessibility/default_accessibility_delegate.h
[modify] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/accessibility/test_accessibility_controller_client.cc
[modify] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/accessibility/test_accessibility_controller_client.h
[modify] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/ash_touch_exploration_manager_chromeos_unittest.cc
[modify] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/public/interfaces/accessibility_controller.mojom
[modify] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/chrome/browser/ui/ash/accessibility/accessibility_controller_client.cc
[modify] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/chrome/browser/ui/ash/accessibility/accessibility_controller_client.h
[modify] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/chrome/browser/ui/ash/accessibility/accessibility_controller_client_unittest.cc
[modify] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/chrome/browser/ui/ash/chrome_shell_delegate.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/613e29f03a4aa166b52deccc927f1c5353ab519a

commit 613e29f03a4aa166b52deccc927f1c5353ab519a
Author: Qiang Xu <warx@google.com>
Date: Fri Feb 09 17:56:09 2018

mash: remove no ash callers a11y delegates

Bug:  618070 
Test: still compiles
Change-Id: Ib35af9450249bb4f83dc4aa3789f1065a1cecf8b
Reviewed-on: https://chromium-review.googlesource.com/909702
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#535748}
[modify] https://crrev.com/613e29f03a4aa166b52deccc927f1c5353ab519a/ash/accessibility/accessibility_delegate.h
[modify] https://crrev.com/613e29f03a4aa166b52deccc927f1c5353ab519a/ash/accessibility/default_accessibility_delegate.cc
[modify] https://crrev.com/613e29f03a4aa166b52deccc927f1c5353ab519a/ash/accessibility/default_accessibility_delegate.h
[modify] https://crrev.com/613e29f03a4aa166b52deccc927f1c5353ab519a/chrome/browser/ui/ash/chrome_shell_delegate.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1b3e7ea05adefc1dd5f7766789dccd27a0a160e

commit c1b3e7ea05adefc1dd5f7766789dccd27a0a160e
Author: Qiang Xu <warx@google.com>
Date: Mon Feb 12 19:57:38 2018

mash: migrate two touch spoken feedback methods

changes:
Remove ShouldToggleSpokenFeedbackViaTouch and
PlaySpokenFeedbackToggleCountdown from ash::AccessibilityDelegate.
Convert them calling into chrome through mojo call.

feature, spoken feedback is toggled by two fingers touching after
hearing two tick sounds.

Bug:  618070 
Test: added test coverage. Also tested on device by enabling the
Change-Id: I75c2fb719724b6a0e1f82d627563b89215790fad
Reviewed-on: https://chromium-review.googlesource.com/909331
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#536165}
[modify] https://crrev.com/c1b3e7ea05adefc1dd5f7766789dccd27a0a160e/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/c1b3e7ea05adefc1dd5f7766789dccd27a0a160e/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/c1b3e7ea05adefc1dd5f7766789dccd27a0a160e/ash/accessibility/accessibility_controller_unittest.cc
[modify] https://crrev.com/c1b3e7ea05adefc1dd5f7766789dccd27a0a160e/ash/accessibility/accessibility_delegate.h
[modify] https://crrev.com/c1b3e7ea05adefc1dd5f7766789dccd27a0a160e/ash/accessibility/default_accessibility_delegate.cc
[modify] https://crrev.com/c1b3e7ea05adefc1dd5f7766789dccd27a0a160e/ash/accessibility/default_accessibility_delegate.h
[modify] https://crrev.com/c1b3e7ea05adefc1dd5f7766789dccd27a0a160e/ash/accessibility/test_accessibility_controller_client.cc
[modify] https://crrev.com/c1b3e7ea05adefc1dd5f7766789dccd27a0a160e/ash/accessibility/test_accessibility_controller_client.h
[modify] https://crrev.com/c1b3e7ea05adefc1dd5f7766789dccd27a0a160e/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/c1b3e7ea05adefc1dd5f7766789dccd27a0a160e/ash/public/interfaces/accessibility_controller.mojom
[modify] https://crrev.com/c1b3e7ea05adefc1dd5f7766789dccd27a0a160e/chrome/browser/ui/ash/accessibility/accessibility_controller_client.cc
[modify] https://crrev.com/c1b3e7ea05adefc1dd5f7766789dccd27a0a160e/chrome/browser/ui/ash/accessibility/accessibility_controller_client.h
[modify] https://crrev.com/c1b3e7ea05adefc1dd5f7766789dccd27a0a160e/chrome/browser/ui/ash/accessibility/accessibility_controller_client_unittest.cc
[modify] https://crrev.com/c1b3e7ea05adefc1dd5f7766789dccd27a0a160e/chrome/browser/ui/ash/chrome_shell_delegate.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4b057564f7b414223341b6c3f561242e012ab40

commit c4b057564f7b414223341b6c3f561242e012ab40
Author: Qiang Xu <warx@google.com>
Date: Tue Feb 13 20:10:28 2018

use ax_enums.mojom for HandleAccessibilityGesture

Bug:  618070 
Test: compiles
Change-Id: I7814c4d60f9fa2c9976db95d715c67d97340ccb5
Reviewed-on: https://chromium-review.googlesource.com/915142
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#536436}
[modify] https://crrev.com/c4b057564f7b414223341b6c3f561242e012ab40/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/c4b057564f7b414223341b6c3f561242e012ab40/ash/accessibility/test_accessibility_controller_client.cc
[modify] https://crrev.com/c4b057564f7b414223341b6c3f561242e012ab40/ash/accessibility/test_accessibility_controller_client.h
[modify] https://crrev.com/c4b057564f7b414223341b6c3f561242e012ab40/ash/ash_touch_exploration_manager_chromeos_unittest.cc
[modify] https://crrev.com/c4b057564f7b414223341b6c3f561242e012ab40/ash/public/interfaces/accessibility_controller.mojom
[modify] https://crrev.com/c4b057564f7b414223341b6c3f561242e012ab40/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/c4b057564f7b414223341b6c3f561242e012ab40/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/c4b057564f7b414223341b6c3f561242e012ab40/chrome/browser/ui/ash/accessibility/accessibility_controller_client.cc
[modify] https://crrev.com/c4b057564f7b414223341b6c3f561242e012ab40/chrome/browser/ui/ash/accessibility/accessibility_controller_client.h
[modify] https://crrev.com/c4b057564f7b414223341b6c3f561242e012ab40/chrome/browser/ui/ash/accessibility/accessibility_controller_client_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9f289a98c8f05488eefe90142b7b26c47bf7356

commit d9f289a98c8f05488eefe90142b7b26c47bf7356
Author: Qiang Xu <warx@google.com>
Date: Wed Feb 21 00:31:24 2018

mash: Convert OnTwoFingerTouchStart{Stop} SilenceSpokenFeedback

Changes:
Remove OnTwoFingerTouchStart{Stop} and SilenceSpokenFeedback from
ash::AccessibilityDelegate. Convert them calling into chrome through
mojo call. These are last three delegate methods which need mojo call
convert.

Bug:  618070 
Change-Id: Ia89d5d1d7033ad0bbd1b47e6de31e2eb0ce2416c
Reviewed-on: https://chromium-review.googlesource.com/917021
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#537957}
[modify] https://crrev.com/d9f289a98c8f05488eefe90142b7b26c47bf7356/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/d9f289a98c8f05488eefe90142b7b26c47bf7356/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/d9f289a98c8f05488eefe90142b7b26c47bf7356/ash/accessibility/accessibility_delegate.h
[modify] https://crrev.com/d9f289a98c8f05488eefe90142b7b26c47bf7356/ash/accessibility/default_accessibility_delegate.cc
[modify] https://crrev.com/d9f289a98c8f05488eefe90142b7b26c47bf7356/ash/accessibility/default_accessibility_delegate.h
[modify] https://crrev.com/d9f289a98c8f05488eefe90142b7b26c47bf7356/ash/accessibility/test_accessibility_controller_client.cc
[modify] https://crrev.com/d9f289a98c8f05488eefe90142b7b26c47bf7356/ash/accessibility/test_accessibility_controller_client.h
[modify] https://crrev.com/d9f289a98c8f05488eefe90142b7b26c47bf7356/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/d9f289a98c8f05488eefe90142b7b26c47bf7356/ash/public/interfaces/accessibility_controller.mojom
[modify] https://crrev.com/d9f289a98c8f05488eefe90142b7b26c47bf7356/chrome/browser/ui/ash/accessibility/accessibility_controller_client.cc
[modify] https://crrev.com/d9f289a98c8f05488eefe90142b7b26c47bf7356/chrome/browser/ui/ash/accessibility/accessibility_controller_client.h
[modify] https://crrev.com/d9f289a98c8f05488eefe90142b7b26c47bf7356/chrome/browser/ui/ash/accessibility/accessibility_controller_client_unittest.cc
[modify] https://crrev.com/d9f289a98c8f05488eefe90142b7b26c47bf7356/chrome/browser/ui/ash/chrome_shell_delegate.cc

We don't need more mojo calls for the methods left in ash::AccessibilityDelegate.

Mark this as fixed.