Issue 618058 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	jamescook@chromium.org
Closed:	Oct 2016
Components:	Tests>Disabled
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
WindowManager mash VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61 Test-Disabled

MruWindowTrackerTest.DraggedWindowsInListOnlyOnce disabled because of shelf window

Project Member Reported by sky@chromium.org, Jun 7 2016

Issue description

It's currently crashing in DockedBackgroundWidget's constructor at:

manager_->shelf()->GetBackgroundType()

The shelf is null. This is because we lazily set the shelf once the window is available. I believe this will go away once we create the shelf explicitly in mash rather than at the request of ash_sysui.

Comment 1 by jamescook@chromium.org, Jun 8 2016

Cc: -jamescook@chromium.org
Owner: jamescook@chromium.org
Status: Assigned (was: Available)

Note to self, this is in mash_unittests

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34ff3fb8a90313138cdc1732410414c7b51e862e

commit 34ff3fb8a90313138cdc1732410414c7b51e862e
Author: sky <sky@chromium.org>
Date: Wed Jun 08 21:37:15 2016

MruWindowTrackerTest for mash

BUG= 617789 , 618058 
TEST=test only change
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2046633006
Cr-Commit-Position: refs/heads/master@{#398686}

[modify] https://crrev.com/34ff3fb8a90313138cdc1732410414c7b51e862e/ash/mus/BUILD.gn
[modify] https://crrev.com/34ff3fb8a90313138cdc1732410414c7b51e862e/ash/mus/wm/mru_window_tracker_unittest.cc

Comment 3 by sky@chromium.org, Oct 12 2016

Labels: -windowmanager WindowManager
Status: Fixed (was: Assigned)

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/829e1b23a8e607028515ccf5376314b4d203bcc1

commit 829e1b23a8e607028515ccf5376314b4d203bcc1
Author: sky <sky@chromium.org>
Date: Tue Oct 11 23:54:40 2016

Converts ash/wm/mru_window_tracker_unittest.cc to use AshTest

And nukes the wm one. I'll move the file to common in a follow on
patch. In order to get this working I needed to add a couple of
things:

. Wire up WmWindowProperty::EXCLUDE_FROM_MRU in WmWindowMus.
. Fix bug in WmShell that resulted in OnWindowActivated() not being
  called correctly (and with wrong args).
. Make ui::WindowObserver::OnWindowDestroyed() be called at the same
  time as that of aura::WindowObserver.

BUG= 618058 ,  654887 
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2411913003
Cr-Commit-Position: refs/heads/master@{#424603}

[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/ash/BUILD.gn
[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/ash/common/BUILD.gn
[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/ash/common/wm/window_state.cc
[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/ash/mus/BUILD.gn
[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/ash/mus/property_util.cc
[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/ash/mus/property_util.h
[delete] https://crrev.com/fa1eb5b3cfb4bee9bf72f7721c73d3a50e5b3932/ash/mus/wm/mru_window_tracker_unittest.cc
[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/ash/wm/mru_window_tracker_unittest.cc
[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/services/ui/public/cpp/window.cc
[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/services/ui/public/interfaces/window_manager.mojom