Migrate Channel ID and Token Binding away from ECPrivateKey::ExportEncryptedPrivateKey |
||
Issue descriptionSee issue #603319 .
,
Apr 10 2017
To completely move away from the encrypted private key functions in ECPrivateKey, we'll need to delete the SQLiteChannelIDStore migration. (ECPrivateKey::ExportEncryptedPrivateKey is no longer depended on by SQLiteChannelIDStore, but ECPrivateKey::CreateFromEncryptedPrivateKeyInfo is.) https://codereview.chromium.org/2807853002/ logs what version the db was when loading before running any migrations, and could be used for making a decision about when to drop support for migrating from old versions.
,
Sep 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a32990c51b6d1bc84211bb1ee73d6c255ff4d20 commit 1a32990c51b6d1bc84211bb1ee73d6c255ff4d20 Author: Nick Harper <nharper@chromium.org> Date: Tue Sep 19 22:11:48 2017 Don't use crypto::ECPrivateKey::CreateFromEncryptedPrivateKeyInfo in //net This function was only used in the SQLite Channel ID store; a migration away from it was added in April. This change removes the use of the function which until now is only used for migrating old Channel ID db formats to the new format. With this change, old databases won't be upgradeable. Bug: 618026 Change-Id: I245077dd1cb16cb5a53b174a15d7dbdf0e0e9942 Reviewed-on: https://chromium-review.googlesource.com/669866 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#502966} [modify] https://crrev.com/1a32990c51b6d1bc84211bb1ee73d6c255ff4d20/net/extras/sqlite/sqlite_channel_id_store.cc [modify] https://crrev.com/1a32990c51b6d1bc84211bb1ee73d6c255ff4d20/net/extras/sqlite/sqlite_channel_id_store_unittest.cc
,
Sep 19 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Apr 5 2017