New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618022 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 618023



Sign in to add a comment

PolyGerrit buildbucket plugin should support auth

Project Member Reported by andyb...@chromium.org, Jun 7 2016

Issue description

In order to enable scheduling of builds and viewing internal ones.
 
Blockedon: 618023
Labels: Proj-Gerrit-Migration
Blockedon: -618023
Blocking: 618023
Owner: jrn@google.com
Labels: Milestone-Fishfood
Owner: andyb...@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/1eb7f7a56020f6a6829433f07d0aa98ebdc2c9d5

commit 1eb7f7a56020f6a6829433f07d0aa98ebdc2c9d5
Author: Andrew Bonventre <andybons@chromium.org>
Date: Thu Oct 20 17:41:21 2016

Grab OAuth2 token before requesting builds

+ If it fails, then it will still attempt to retrieve a build list
  without the Authorization header (as a fallback so that things
  don’t regress in prod while we get all this working).
+ Don’t show “Loading builds...” since it is superfluous jank when
  there are no builds to show.

BUG= 618022 

Change-Id: Ie81e81c1137f66a8b0997524635226f46b4296d2

[modify] https://crrev.com/1eb7f7a56020f6a6829433f07d0aa98ebdc2c9d5/src/main/resources/static/cr-buildbucket-view.html
[modify] https://crrev.com/1eb7f7a56020f6a6829433f07d0aa98ebdc2c9d5/src/main/resources/static/cr-buildbucket-view.js

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/27f23e8dbfad02a26f5101b2250d7ff92b08fbdd

commit 27f23e8dbfad02a26f5101b2250d7ff92b08fbdd
Author: Andrew Bonventre <andybons@chromium.org>
Date: Mon Oct 24 21:22:05 2016

Add toggle for OAuth check

Disable OAuth by default due to a bug in prod, but allow for toggling
it on using a query param `enableoauth` so that it can be debugged.

BUG= 618022 

Change-Id: I8ed2bf25ba212104cc96e59477562f00c14c1602

[modify] https://crrev.com/27f23e8dbfad02a26f5101b2250d7ff92b08fbdd/src/main/resources/static/cr-buildbucket-view.js

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/27f23e8dbfad02a26f5101b2250d7ff92b08fbdd

commit 27f23e8dbfad02a26f5101b2250d7ff92b08fbdd
Author: Andrew Bonventre <andybons@chromium.org>
Date: Mon Oct 24 21:22:05 2016

Add toggle for OAuth check

Disable OAuth by default due to a bug in prod, but allow for toggling
it on using a query param `enableoauth` so that it can be debugged.

BUG= 618022 

Change-Id: I8ed2bf25ba212104cc96e59477562f00c14c1602

[modify] https://crrev.com/27f23e8dbfad02a26f5101b2250d7ff92b08fbdd/src/main/resources/static/cr-buildbucket-view.js

Status: Fixed (was: Assigned)

Sign in to add a comment