ServiceWorkerProviderHostTest.ContextSecurity failing under Dr. Memory |
|||
Issue descriptionExample from build https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/5016: ServiceWorkerProviderHostTest.ContextSecurity: c:\b\build\slave\drm-cr\build\src\content\browser\service_worker\service_worker_provider_host_unittest.cc(178): error: Value of: OriginCanAccessServiceWorkers(url) Actual: false Expected: true c:\b\build\slave\drm-cr\build\src\content\browser\service_worker\service_worker_provider_host_unittest.cc(179): error: Value of: provider_host1_->IsContextSecureForServiceWorker() Actual: false Expected: true Suspecting r398229.
,
Jun 8 2016
,
Jun 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6a56d552c00fd8d7020f0abd019e990838ac687 commit e6a56d552c00fd8d7020f0abd019e990838ac687 Author: falken <falken@chromium.org> Date: Tue Jun 14 06:30:13 2016 Revert of Disable tests failing under Dr. Memory (patchset #1 id:1 of https://codereview.chromium.org/2043123002/ ) Reason for revert: The change that added this test has seen been reverted. Original issue's description: > Disable tests failing under Dr. Memory > > ServiceWorkerProviderHostTest.ContextSecurity > > BUG= 618015 > TBR=oshima@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/6bfb23934a9ba482fc12f5d2628a253f40422ff4 TBR=oshima@chromium.org,reillyg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 618015 Review-Url: https://codereview.chromium.org/2064983002 Cr-Commit-Position: refs/heads/master@{#399652} [modify] https://crrev.com/e6a56d552c00fd8d7020f0abd019e990838ac687/tools/valgrind/gtest_exclude/content_unittests.gtest-drmemory_win32.txt
,
Jun 14 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6a56d552c00fd8d7020f0abd019e990838ac687 commit e6a56d552c00fd8d7020f0abd019e990838ac687 Author: falken <falken@chromium.org> Date: Tue Jun 14 06:30:13 2016 Revert of Disable tests failing under Dr. Memory (patchset #1 id:1 of https://codereview.chromium.org/2043123002/ ) Reason for revert: The change that added this test has seen been reverted. Original issue's description: > Disable tests failing under Dr. Memory > > ServiceWorkerProviderHostTest.ContextSecurity > > BUG= 618015 > TBR=oshima@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/6bfb23934a9ba482fc12f5d2628a253f40422ff4 TBR=oshima@chromium.org,reillyg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 618015 Review-Url: https://codereview.chromium.org/2064983002 Cr-Commit-Position: refs/heads/master@{#399652} [modify] https://crrev.com/e6a56d552c00fd8d7020f0abd019e990838ac687/tools/valgrind/gtest_exclude/content_unittests.gtest-drmemory_win32.txt
,
Sep 20 2016
For the fossil record: The revert of https://crrev.com/ad1850962644e19cdb040d60eb236e0ebc23c243 occurred because some CHECKs it added were failing ( issue 607543 , https://crrev.com/c363d41a6001cb7b27789484702d23fa4572a918). The tests were failing and were disabled in DrMemory for an unrelated cause: not calling content::ResetSchemesAndOriginsWhitelistForTesting at the beginning of the unit test. Both issues were addressed in the reland at https://codereview.chromium.org/2071433003. That is: https://crrev.com/ad1850962644e19cdb040d60eb236e0ebc23c243 original patch https://crrev.com/6bfb23934a9ba482fc12f5d2628a253f40422ff4 disable on Dr Memory https://crrev.com/c363d41a6001cb7b27789484702d23fa4572a918 revert the patch https://crrev.com/e6a56d552c00fd8d7020f0abd019e990838ac687 revert the Dr Memory expectations https://crrev.com/ad1850962644e19cdb040d60eb236e0ebc23c243 reland the patch |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jun 7 2016