New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618004 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename MediaCodecBridge::Reset to Flush

Project Member Reported by w...@chromium.org, Jun 7 2016

Issue description

MediaCodec has both a flush() and reset() but MediaCodecBridge::Reset()
calls MediaCodec#flush(), which is a bit confusing, e.g., two of the
call sites actually have a comment saying that Reset() calls flush().

 
Yes, please! +1000

Comment 2 by w...@chromium.org, Jun 7 2016

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab7d097a56f7cba3fa417b5ade22b71bcb4c1953

commit ab7d097a56f7cba3fa417b5ade22b71bcb4c1953
Author: watk <watk@chromium.org>
Date: Tue Jun 07 23:26:40 2016

Rename MediaCodecBridge::Reset() to Flush()

MediaCodec has both a flush() and reset() but MediaCodecBridge::Reset()
calls MediaCodec#flush(), which is a bit confusing, e.g., two of the
call sites actually have a comment saying that Reset() calls flush().

BUG= 618004 

Review-Url: https://codereview.chromium.org/2047003003
Cr-Commit-Position: refs/heads/master@{#398414}

[modify] https://crrev.com/ab7d097a56f7cba3fa417b5ade22b71bcb4c1953/media/base/android/media_codec_bridge.h
[modify] https://crrev.com/ab7d097a56f7cba3fa417b5ade22b71bcb4c1953/media/base/android/media_codec_decoder.cc
[modify] https://crrev.com/ab7d097a56f7cba3fa417b5ade22b71bcb4c1953/media/base/android/media_decoder_job.cc
[modify] https://crrev.com/ab7d097a56f7cba3fa417b5ade22b71bcb4c1953/media/base/android/ndk_media_codec_bridge.cc
[modify] https://crrev.com/ab7d097a56f7cba3fa417b5ade22b71bcb4c1953/media/base/android/ndk_media_codec_bridge.h
[modify] https://crrev.com/ab7d097a56f7cba3fa417b5ade22b71bcb4c1953/media/base/android/sdk_media_codec_bridge.cc
[modify] https://crrev.com/ab7d097a56f7cba3fa417b5ade22b71bcb4c1953/media/base/android/sdk_media_codec_bridge.h
[modify] https://crrev.com/ab7d097a56f7cba3fa417b5ade22b71bcb4c1953/media/base/android/sdk_media_codec_bridge_unittest.cc
[modify] https://crrev.com/ab7d097a56f7cba3fa417b5ade22b71bcb4c1953/media/filters/android/media_codec_audio_decoder.cc
[modify] https://crrev.com/ab7d097a56f7cba3fa417b5ade22b71bcb4c1953/media/gpu/android_video_decode_accelerator.cc

Sign in to add a comment