Chrome treats theme as a dark theme even though it's not dark
Reported by
merwin.m...@gmail.com,
Jun 7 2016
|
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.24 Safari/537.36 Steps to reproduce the problem: 1. Launch Google 2. 3. What is the expected behavior? I would like my navigation icons to be visible. What went wrong? Not sure if this is a feature or bug. It is incredibly annoying. There's very small difference between usable icons and greyed out icons. No option to change back to darker arrows or bookmarks. Did this work before? Yes In the previous version Chrome version: 52.0.2743.24 Channel: beta OS Version: OS X 10.10.5 Flash Version: Shockwave Flash 22.0 r0 Not sure where else to voice this. Again, I'm not sure if this is a feature or a bug. However, it doesn't feel right. Perhaps I am unreasonable, but I hate it and it frustrates me that I can't change it back.
,
Jun 8 2016
This color is by design. Assigning to sgabriel@ for review.
,
Jun 8 2016
It's not in incognito. However, it does appear to be theme related. Thank you.
,
Jun 9 2016
merwin.miles@ - please let me know the name of the theme you're using. I want to investigate more.
,
Jun 9 2016
Apologies shrike@, I applied the theme over a year old, and I just updated to a newer theme in order to address this issue. If there is a library that stores old themes, I don't know where it would be. The only information I found says that you must find the theme in the WebStore again, but I don't remember the name of the theme. The only thing I can go on is the color of the tab-bar. If you want to try that way, I'm attaching a picture of that, but I didn't have any luck myself. Good luck!
,
Jun 9 2016
May be this is similar: https://chrome.google.com/webstore/detail/project-cupid-theme/eabnodlokhenjkhaoahjkomffchhpnjl?hl=en-US Icons are very hard to see and the dropdown is black in normal window.
,
Jun 9 2016
The faint icon problem is being tracked in Issue 618763 . Chrome examines themes and guesses whether it is "light" or "dark." For some reason Chrome is thinking the theme in #7 and being used by the original reporter are dark, which doesn't seem like the right decision. That's what I will be looking into in this bug.
,
Jun 15 2016
,
Jun 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4acec7a4f8fe1e3e50785a7a601499c2f7619b5 commit f4acec7a4f8fe1e3e50785a7a601499c2f7619b5 Author: shrike <shrike@chromium.org> Date: Thu Jun 16 16:24:12 2016 [Mac][Material Design] Adjust cutoff for detecting a "dark" theme. Chrome looks at the whiteComponent of a theme's custom toolbar color to decide if the theme is "dark." The line between ligth and dark is an empirical value - this cl adjusts the cutoff in hopes of getting closer to the right value. R=tapted@chromium.org BUG= 614806 , 617993 Review-Url: https://codereview.chromium.org/2068243002 Cr-Commit-Position: refs/heads/master@{#400168} [modify] https://crrev.com/f4acec7a4f8fe1e3e50785a7a601499c2f7619b5/chrome/browser/ui/cocoa/chrome_browser_window.mm
,
Jun 16 2016
,
Jun 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75175ca5f6abba3c5d15cbbc1080ce8f5889a946 commit 75175ca5f6abba3c5d15cbbc1080ce8f5889a946 Author: Jayson Adams <shrike@chromium.org> Date: Fri Jun 17 22:09:11 2016 [Mac][Material Design] Adjust cutoff for detecting a "dark" theme. Chrome looks at the whiteComponent of a theme's custom toolbar color to decide if the theme is "dark." The line between ligth and dark is an empirical value - this cl adjusts the cutoff in hopes of getting closer to the right value. R=tapted@chromium.org BUG= 614806 , 617993 Review-Url: https://codereview.chromium.org/2068243002 Cr-Commit-Position: refs/heads/master@{#400168} (cherry picked from commit f4acec7a4f8fe1e3e50785a7a601499c2f7619b5) Review URL: https://codereview.chromium.org/2077743004 . Cr-Commit-Position: refs/branch-heads/2743@{#384} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/75175ca5f6abba3c5d15cbbc1080ce8f5889a946/chrome/browser/ui/cocoa/chrome_browser_window.mm
,
Jun 22 2016
Tested the issue on Mac 10.11.5 using 52.0.2743.49 as per steps in bug 614806 .Observed that icons are gray and the dropdown is white. Please find attached screencast. Marking it as TE-Verified. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by meh...@chromium.org
, Jun 7 2016Labels: Proj-MaterialDesign-NativeUI