New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 617966 link

Starred by 1 user
Status: Fixed
Owner:
█ sfiera@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocked on:
issue 603026
Blocking:
issue 631990



Sign in to add a comment

Build ntp_tiles on iOS

Project Member Reported by sfiera@chromium.org, Jun 7 2016 
In order for ntp_snippets to use ntp_tiles, it will have to be buildable on iOS. Currently, this is not possible because of dependencies on SkImage/JPEGCodec (and possibly other, as yet unknown reasons).

crrev.com/2041353002 enables ntp_tiles on iOS; it's not ready for submission yet but can be patched into other CLs to check compatibility while working.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08009fe141ab0469b4d9efed41a8453a0f409bb2

commit 08009fe141ab0469b4d9efed41a8453a0f409bb2
Author: sfiera <sfiera@chromium.org>
Date: Wed Jun 15 17:07:26 2016

Move ntp_tiles classes to namespace ntp_tiles.

BUG= 617966 

Review-Url: https://codereview.chromium.org/2069763003
Cr-Commit-Position: refs/heads/master@{#399931}

[modify] https://crrev.com/08009fe141ab0469b4d9efed41a8453a0f409bb2/chrome/browser/android/ntp/most_visited_sites_bridge.cc
[modify] https://crrev.com/08009fe141ab0469b4d9efed41a8453a0f409bb2/chrome/browser/android/ntp/most_visited_sites_bridge.h
[modify] https://crrev.com/08009fe141ab0469b4d9efed41a8453a0f409bb2/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/08009fe141ab0469b4d9efed41a8453a0f409bb2/chrome/browser/ui/webui/popular_sites_internals_message_handler.cc
[modify] https://crrev.com/08009fe141ab0469b4d9efed41a8453a0f409bb2/chrome/browser/ui/webui/popular_sites_internals_message_handler.h
[modify] https://crrev.com/08009fe141ab0469b4d9efed41a8453a0f409bb2/components/ntp_tiles/most_visited_sites.cc
[modify] https://crrev.com/08009fe141ab0469b4d9efed41a8453a0f409bb2/components/ntp_tiles/most_visited_sites.h
[modify] https://crrev.com/08009fe141ab0469b4d9efed41a8453a0f409bb2/components/ntp_tiles/most_visited_sites_unittest.cc
[modify] https://crrev.com/08009fe141ab0469b4d9efed41a8453a0f409bb2/components/ntp_tiles/popular_sites.cc
[modify] https://crrev.com/08009fe141ab0469b4d9efed41a8453a0f409bb2/components/ntp_tiles/popular_sites.h

Comment 2 by sfiera@chromium.org, Jun 17 2016

Labels: zine-mr-iter-20
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33a73461966a7c727e9400bb61b39c2bea188276

commit 33a73461966a7c727e9400bb61b39c2bea188276
Author: sfiera <sfiera@chromium.org>
Date: Mon Jul 04 15:47:25 2016

Remove dead ntp_tiles thumbnail-related code.

Included a reference to SkBitmap, which won't compile on iOS.

BUG= 617966 

Review-Url: https://codereview.chromium.org/2119223002
Cr-Commit-Position: refs/heads/master@{#403688}

[modify] https://crrev.com/33a73461966a7c727e9400bb61b39c2bea188276/components/ntp_tiles/most_visited_sites.h

Comment 4 by sfiera@chromium.org, Jul 18 2016

Labels: zine-16-07-18

Comment 5 by sfiera@chromium.org, Jul 25 2016

Labels: -Pri-3 zine-16-07-25 Pri-2
Last week: build access, test compilation. This week: actual progress?

Comment 6 by sfiera@chromium.org, Jul 27 2016

Blocking: 631990

Comment 9 by sfiera@chromium.org, Aug 1 2016

Labels: zine-16-08-01
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff9d227b16b1f6d34677c0bfe19153526c7bbfa7

commit ff9d227b16b1f6d34677c0bfe19153526c7bbfa7
Author: sfiera <sfiera@chromium.org>
Date: Tue Aug 02 07:59:52 2016

Add //components/ntp_tiles/ to iOS build.

BUG= 617966 

Review-Url: https://codereview.chromium.org/2192543003
Cr-Commit-Position: refs/heads/master@{#409153}

[modify] https://crrev.com/ff9d227b16b1f6d34677c0bfe19153526c7bbfa7/components/BUILD.gn
[modify] https://crrev.com/ff9d227b16b1f6d34677c0bfe19153526c7bbfa7/components/components_tests.gyp

Comment 11 by sfiera@chromium.org, Aug 2 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment