The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a43c3ede6d7db6e9ec25c80db8fbcd5ed80ad0f

commit 7a43c3ede6d7db6e9ec25c80db8fbcd5ed80ad0f
Author: etiennep <etiennep@google.com>
Date: Tue Jun 07 17:40:38 2016

Refactor rel32 searching process for x64 to make it more similar to x86.

I created a base class Rel32Finder from which derives both Rel32FinderX86 and Rel32Finder64.
This makes ParseRel32RelocsFromSection method more similar in x64 and x86.
Note that I removed the Win32 part of the name because it may be used by DisassemblerElf.
I created test cases for Rel32FinderX64 which extends those for Rel32FinderX86.

BUG= 617965 

Review-Url: https://codereview.chromium.org/2008253004
Cr-Commit-Position: refs/heads/master@{#398326}

[modify] https://crrev.com/7a43c3ede6d7db6e9ec25c80db8fbcd5ed80ad0f/courgette/BUILD.gn
[modify] https://crrev.com/7a43c3ede6d7db6e9ec25c80db8fbcd5ed80ad0f/courgette/courgette.gyp
[modify] https://crrev.com/7a43c3ede6d7db6e9ec25c80db8fbcd5ed80ad0f/courgette/disassembler_win32_x64.cc
[modify] https://crrev.com/7a43c3ede6d7db6e9ec25c80db8fbcd5ed80ad0f/courgette/disassembler_win32_x86.cc
[add] https://crrev.com/7a43c3ede6d7db6e9ec25c80db8fbcd5ed80ad0f/courgette/rel32_finder.cc
[rename] https://crrev.com/7a43c3ede6d7db6e9ec25c80db8fbcd5ed80ad0f/courgette/rel32_finder.h
[rename] https://crrev.com/7a43c3ede6d7db6e9ec25c80db8fbcd5ed80ad0f/courgette/rel32_finder_unittest.cc
[add] https://crrev.com/7a43c3ede6d7db6e9ec25c80db8fbcd5ed80ad0f/courgette/rel32_finder_x64.cc
[add] https://crrev.com/7a43c3ede6d7db6e9ec25c80db8fbcd5ed80ad0f/courgette/rel32_finder_x64.h
[rename] https://crrev.com/7a43c3ede6d7db6e9ec25c80db8fbcd5ed80ad0f/courgette/rel32_finder_x86.cc
[add] https://crrev.com/7a43c3ede6d7db6e9ec25c80db8fbcd5ed80ad0f/courgette/rel32_finder_x86.h
[add] https://crrev.com/7a43c3ede6d7db6e9ec25c80db8fbcd5ed80ad0f/courgette/testdata/rel32_x64_01.txt
[add] https://crrev.com/7a43c3ede6d7db6e9ec25c80db8fbcd5ed80ad0f/courgette/testdata/rel32_x64_02.txt
[add] https://crrev.com/7a43c3ede6d7db6e9ec25c80db8fbcd5ed80ad0f/courgette/testdata/rel32_x64_03.txt
[rename] https://crrev.com/7a43c3ede6d7db6e9ec25c80db8fbcd5ed80ad0f/courgette/testdata/rel32_x86_01.txt
[rename] https://crrev.com/7a43c3ede6d7db6e9ec25c80db8fbcd5ed80ad0f/courgette/testdata/rel32_x86_02.txt
[rename] https://crrev.com/7a43c3ede6d7db6e9ec25c80db8fbcd5ed80ad0f/courgette/testdata/rel32_x86_03.txt
[rename] https://crrev.com/7a43c3ede6d7db6e9ec25c80db8fbcd5ed80ad0f/courgette/testdata/rel32_x86_04.txt

Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot