Issue 617962 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	afakhry@chromium.org
Closed:	Jun 2016
Cc:	xiy...@chromium.org jdufault@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
VerifyIn-53 VerifyIn-54 VerifyIn-55 VerifyIn-56 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

enterpriseInfo property doesn't exist in offline-gaia.

Project Member Reported by afakhry@chromium.org, Jun 7 2016

Issue description

This line here: https://cs.chromium.org/chromium/src/ui/login/display_manager.js?q=enterpriseInfo+f:.*%5C.js&sq=package:chromium&l=1021&dr=C

produces the following error:

[729:729:0523/114830:ERROR:CONSOLE(2836)] "Uncaught TypeError: Cannot set property 'enterpriseInfo' of null", source: chrome://oobe/lock.js (2836)

This property was removed recently. Also, it seems the DisplayManager can't access $('offline-gaia') this way.

Comment 1 by xiy...@chromium.org, Jun 7 2016

Cc: jdufault@chromium.org

I noted the log is from lock.js, which means we are showing a lock screen rather than login screen. And offline-gaia probably no longer exists on lock screen after recent optimization on lock screen loading time.

We probably should do a null check in DisplayManager.setEnterpriseInfo now.

Comment 2 by jdufault@chromium.org, Jun 8 2016

Yes, the null check is reasonable.

lock.js already stubs out a number of Oobe methods, so an alternative is to stub the method for the lockscreen.

So the CL would be moving the current Oobe.setEnterpriseInfo definition from login_shared.js to login_non_lock_shared.js and then adding a dummy setEnterpriseInfo function to lock.js.

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca6500c0f9f7dc2b8a8f865ca2ccf2df707b1449

commit ca6500c0f9f7dc2b8a8f865ca2ccf2df707b1449
Author: afakhry <afakhry@chromium.org>
Date: Wed Jun 08 18:25:09 2016

Fix SAML single-password scrapping authenticating with an empty password

Fix a JS syntax error that led to authentication with an empty password.
Also, remove setting enterpriseInfo in <offline-gaia> as it doesn't have
this property anymore.

BUG=618279, 617962 
TEST=manually with login/logout, lock/unlock.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2049103002
Cr-Commit-Position: refs/heads/master@{#398624}

[modify] https://crrev.com/ca6500c0f9f7dc2b8a8f865ca2ccf2df707b1449/chrome/browser/chromeos/login/saml/saml_browsertest.cc
[modify] https://crrev.com/ca6500c0f9f7dc2b8a8f865ca2ccf2df707b1449/chrome/browser/resources/gaia_auth_host/authenticator.js
[modify] https://crrev.com/ca6500c0f9f7dc2b8a8f865ca2ccf2df707b1449/ui/login/display_manager.js