New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 617948 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Android MediaRouter only (left Chro...
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , All
Pri: 1
Type: Bug



Sign in to add a comment

Measure autoplay behaviour based on a few parameters

Project Member Reported by mlamouri@chromium.org, Jun 7 2016

Issue description

We want to add the following histograms
Audio.Autoplay
Video.Autoplay
Video.Autoplay.Muted

Each will have the following vallues:
- play() success
- play() failure
- autoplay attribute success
- autoplay attribute failure

So we will know how many media elements autoplay and using which method. With a sub-set for muted videos (Video.Autoplay will include muted videos).

Targetting M52 because ideally, we would like to send this there for early data.
 
Labels: Proj-Autoplay
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 8 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b69344ad79fc2e36f8eea0e8f0fad3905395cb48

commit b69344ad79fc2e36f8eea0e8f0fad3905395cb48
Author: zqzhang <zqzhang@chromium.org>
Date: Thu Jun 09 13:10:10 2016

[Media, Autoplay] Add UMA to record autoplay source

This CL adds UMA to record the autoplay source, which could be the
autoplay attribute of HTMLMediaElement, or the `play()` method.

BUG= 617948 

Review-Url: https://codereview.chromium.org/2044373002
Cr-Commit-Position: refs/heads/master@{#398855}

[modify] https://crrev.com/b69344ad79fc2e36f8eea0e8f0fad3905395cb48/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/b69344ad79fc2e36f8eea0e8f0fad3905395cb48/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/b69344ad79fc2e36f8eea0e8f0fad3905395cb48/tools/metrics/histograms/histograms.xml

Labels: -M-53 -MovedFrom-52 Merge-Request-52 M-52

Comment 5 by tin...@google.com, Jun 9 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 9 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d99c3324728e82e364e395f483b37b6a3a3f6ae1

commit d99c3324728e82e364e395f483b37b6a3a3f6ae1
Author: Zhiqiang Zhang <zqzhang@google.com>
Date: Thu Jun 09 14:45:28 2016

[Media, Autoplay] Add UMA to record autoplay source

This CL adds UMA to record the autoplay source, which could be the
autoplay attribute of HTMLMediaElement, or the `play()` method.

BUG= 617948 

Review-Url: https://codereview.chromium.org/2044373002
Cr-Commit-Position: refs/heads/master@{#398855}
(cherry picked from commit b69344ad79fc2e36f8eea0e8f0fad3905395cb48)

Review URL: https://codereview.chromium.org/2056743002 .

Cr-Commit-Position: refs/branch-heads/2743@{#293}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/d99c3324728e82e364e395f483b37b6a3a3f6ae1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/d99c3324728e82e364e395f483b37b6a3a3f6ae1/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/d99c3324728e82e364e395f483b37b6a3a3f6ae1/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b69344ad79fc2e36f8eea0e8f0fad3905395cb48

commit b69344ad79fc2e36f8eea0e8f0fad3905395cb48
Author: zqzhang <zqzhang@chromium.org>
Date: Thu Jun 09 13:10:10 2016

[Media, Autoplay] Add UMA to record autoplay source

This CL adds UMA to record the autoplay source, which could be the
autoplay attribute of HTMLMediaElement, or the `play()` method.

BUG= 617948 

Review-Url: https://codereview.chromium.org/2044373002
Cr-Commit-Position: refs/heads/master@{#398855}

[modify] https://crrev.com/b69344ad79fc2e36f8eea0e8f0fad3905395cb48/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/b69344ad79fc2e36f8eea0e8f0fad3905395cb48/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/b69344ad79fc2e36f8eea0e8f0fad3905395cb48/tools/metrics/histograms/histograms.xml

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d99c3324728e82e364e395f483b37b6a3a3f6ae1

commit d99c3324728e82e364e395f483b37b6a3a3f6ae1
Author: Zhiqiang Zhang <zqzhang@google.com>
Date: Thu Jun 09 14:45:28 2016

[Media, Autoplay] Add UMA to record autoplay source

This CL adds UMA to record the autoplay source, which could be the
autoplay attribute of HTMLMediaElement, or the `play()` method.

BUG= 617948 

Review-Url: https://codereview.chromium.org/2044373002
Cr-Commit-Position: refs/heads/master@{#398855}
(cherry picked from commit b69344ad79fc2e36f8eea0e8f0fad3905395cb48)

Review URL: https://codereview.chromium.org/2056743002 .

Cr-Commit-Position: refs/branch-heads/2743@{#293}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/d99c3324728e82e364e395f483b37b6a3a3f6ae1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/d99c3324728e82e364e395f483b37b6a3a3f6ae1/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/d99c3324728e82e364e395f483b37b6a3a3f6ae1/tools/metrics/histograms/histograms.xml

Labels: Needs-Feedback
zqzhang@, can you please let us know if this can be tested manually so that we can verify it at our end ?
Hi puccakayala@,

This CL is for collecting UMA. I don't really think it needs to be tested.

If you really need to test it, I'll write you some instructions to do it.

Sign in to add a comment