- move spec defined syntax from blink_idl_parser.py to idl_parser.py - remove unspeced syntax (e.g. allowing trailing comma) for compat
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/993ba2de09730a067a60b963b4b04652784b51d7 commit 993ba2de09730a067a60b963b4b04652784b51d7 Author: bashi <bashi@chromium.org> Date: Tue Jun 07 14:33:54 2016 Upstream the grammer for union types to idl_parser There is no reason to put it in blink_idl_parser.py BUG=617899 Review-Url: https://codereview.chromium.org/2048613002 Cr-Commit-Position: refs/heads/master@{#398297} [modify] https://crrev.com/993ba2de09730a067a60b963b4b04652784b51d7/third_party/WebKit/Source/bindings/scripts/blink_idl_parser.py [modify] https://crrev.com/993ba2de09730a067a60b963b4b04652784b51d7/tools/idl_parser/idl_parser.py [modify] https://crrev.com/993ba2de09730a067a60b963b4b04652784b51d7/tools/idl_parser/test_parser/interface_web.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36889c50c1e61023e78aa27e5876285d0d79cb25 commit 36889c50c1e61023e78aa27e5876285d0d79cb25 Author: bashi <bashi@chromium.org> Date: Thu Jun 09 04:57:49 2016 Clean-up blink_idl_parser - Move p_CallbackOrInterface to the base parser - Remove p_TypeSuffix. This is already handled by the base parser BUG=617899 Review-Url: https://codereview.chromium.org/2050823003 Cr-Commit-Position: refs/heads/master@{#398790} [modify] https://crrev.com/36889c50c1e61023e78aa27e5876285d0d79cb25/third_party/WebKit/Source/bindings/scripts/blink_idl_parser.py [modify] https://crrev.com/36889c50c1e61023e78aa27e5876285d0d79cb25/tools/idl_parser/idl_parser.py
Changed the summary so that we can use this bug not only for parser clean-ups but also other binding related scripts.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5be6fa30d6a673a617bed7f02281cda1f9064765 commit 5be6fa30d6a673a617bed7f02281cda1f9064765 Author: bashi <bashi@chromium.org> Date: Thu Jul 21 07:15:58 2016 Rename Tools/Scripts/webkitpy/bindings/main.py to bindings_tests.py Some scripts in Source/bindings/scripts aren't executed while building chromium. These scripts should be placed in another place and Tools/Scripts/webkitpy/bindings is a good candidate to put tool-ish scripts. This CL renames main.py in the directory so that we can put other scripts in the directory. Also, I did some clean-ups to pass check-webkit-style. BUG=617899 Review-Url: https://codereview.chromium.org/2166223002 Cr-Commit-Position: refs/heads/master@{#406796} [modify] https://crrev.com/5be6fa30d6a673a617bed7f02281cda1f9064765/third_party/WebKit/Tools/Scripts/run-bindings-tests [rename] https://crrev.com/5be6fa30d6a673a617bed7f02281cda1f9064765/third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py [modify] https://crrev.com/5be6fa30d6a673a617bed7f02281cda1f9064765/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1b1fb569a15770e39c140a812bb8edae58ce11b commit e1b1fb569a15770e39c140a812bb8edae58ce11b Author: bashi <bashi@chromium.org> Date: Thu Jul 21 21:46:00 2016 Move bindings tooling scripts to Tools/Scripts/webkitpy/bindings These scripts are not a part of code generator so it would be better to put them in Tools/Scripts/webkitpy/bindings. BUG=617899 Review-Url: https://codereview.chromium.org/2169673003 Cr-Commit-Position: refs/heads/master@{#406957} [delete] https://crrev.com/70b502aef44c4f6f9db8d1abff3ff8d4cde9eab0/third_party/WebKit/Source/bindings/scripts/testdata/test_filepath.txt [rename] https://crrev.com/e1b1fb569a15770e39c140a812bb8edae58ce11b/third_party/WebKit/Tools/Scripts/webkitpy/bindings/collect_idls_into_json.py [rename] https://crrev.com/e1b1fb569a15770e39c140a812bb8edae58ce11b/third_party/WebKit/Tools/Scripts/webkitpy/bindings/collect_idls_into_json_test.py [rename] https://crrev.com/e1b1fb569a15770e39c140a812bb8edae58ce11b/third_party/WebKit/Tools/Scripts/webkitpy/bindings/generate_idl_diff.py [rename] https://crrev.com/e1b1fb569a15770e39c140a812bb8edae58ce11b/third_party/WebKit/Tools/Scripts/webkitpy/bindings/generate_idl_diff_test.py [rename] https://crrev.com/e1b1fb569a15770e39c140a812bb8edae58ce11b/third_party/WebKit/Tools/Scripts/webkitpy/bindings/print_idl_diff.py [rename] https://crrev.com/e1b1fb569a15770e39c140a812bb8edae58ce11b/third_party/WebKit/Tools/Scripts/webkitpy/bindings/testdata/new_blink_idls.json [rename] https://crrev.com/e1b1fb569a15770e39c140a812bb8edae58ce11b/third_party/WebKit/Tools/Scripts/webkitpy/bindings/testdata/old_blink_idls.json [add] https://crrev.com/e1b1fb569a15770e39c140a812bb8edae58ce11b/third_party/WebKit/Tools/Scripts/webkitpy/bindings/testdata/test_filepath.txt [rename] https://crrev.com/e1b1fb569a15770e39c140a812bb8edae58ce11b/third_party/WebKit/Tools/Scripts/webkitpy/bindings/testdata/test_interface.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ca6e02d38f91102e6da13149743b523b4d20a63 commit 4ca6e02d38f91102e6da13149743b523b4d20a63 Author: peria <peria@chromium.org> Date: Mon Sep 26 18:41:23 2016 Pass file names list to compute_interfaces_info_individual.py in one way This is a refactoring change around IDL compiler. BUG=617899 Review-Url: https://codereview.chromium.org/2372463002 Cr-Commit-Position: refs/heads/master@{#420945} [modify] https://crrev.com/4ca6e02d38f91102e6da13149743b523b4d20a63/third_party/WebKit/Source/bindings/core/BUILD.gn [modify] https://crrev.com/4ca6e02d38f91102e6da13149743b523b4d20a63/third_party/WebKit/Source/bindings/modules/BUILD.gn [modify] https://crrev.com/4ca6e02d38f91102e6da13149743b523b4d20a63/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py [modify] https://crrev.com/4ca6e02d38f91102e6da13149743b523b4d20a63/third_party/WebKit/Source/bindings/scripts/scripts.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb12baa9349003273ebf3d9acfdecda482dfc595 commit fb12baa9349003273ebf3d9acfdecda482dfc595 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Thu Jun 22 07:19:09 2017 bindings: Remove custom 'ConstValue' rule It seems that we don't need this custom rule anymore. The base parser has p_ConstValue() rule and it covers all blink IDL files. BUG=617899 Change-Id: Iada96f929639faed056b3a468cdcfe661af80a8e Reviewed-on: https://chromium-review.googlesource.com/544740 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#481471} [modify] https://crrev.com/fb12baa9349003273ebf3d9acfdecda482dfc595/third_party/WebKit/Source/bindings/scripts/blink_idl_parser.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23e996b5055fc9de59db10ea8246a2ff386753c2 commit 23e996b5055fc9de59db10ea8246a2ff386753c2 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Thu Jun 22 23:00:10 2017 Remove PPAPI related code from tools/idl_parser It seems there was an intention of merging lexer/parser for PPAPI IDL and WebIDL but no one has been working on it recently. PPAPI has its own lexer/parser in ppapi/generators. Blink is the only user of tools/idl_parser in the code base with some custom extensions (See third_party/WebKit/Source/bindings/scripts/blink_idl_parser.py). The grammar of WebIDL has been actively changing and maintaining both idl_parser.py and blink_idl_parser.py is troublesome. Let's remove PPAPI support from tools/idl_parser so that we can easily keep the parser up-to-date. BUG=617899 Change-Id: Ia4b8c7918245cce57c7a14326e5fc5c48ba42127 Reviewed-on: https://chromium-review.googlesource.com/544401 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#481704} [modify] https://crrev.com/23e996b5055fc9de59db10ea8246a2ff386753c2/tools/idl_parser/idl_lexer.py [modify] https://crrev.com/23e996b5055fc9de59db10ea8246a2ff386753c2/tools/idl_parser/idl_lexer_test.py [modify] https://crrev.com/23e996b5055fc9de59db10ea8246a2ff386753c2/tools/idl_parser/idl_parser.py [modify] https://crrev.com/23e996b5055fc9de59db10ea8246a2ff386753c2/tools/idl_parser/idl_parser_test.py [delete] https://crrev.com/fc185a85198149b326df53956fe8e30401215d3a/tools/idl_parser/idl_ppapi_lexer.py [delete] https://crrev.com/fc185a85198149b326df53956fe8e30401215d3a/tools/idl_parser/idl_ppapi_parser.py [delete] https://crrev.com/fc185a85198149b326df53956fe8e30401215d3a/tools/idl_parser/test_lexer/keywords_ppapi.in [delete] https://crrev.com/fc185a85198149b326df53956fe8e30401215d3a/tools/idl_parser/test_lexer/values_ppapi.in [delete] https://crrev.com/fc185a85198149b326df53956fe8e30401215d3a/tools/idl_parser/test_parser/enum_ppapi.idl [delete] https://crrev.com/fc185a85198149b326df53956fe8e30401215d3a/tools/idl_parser/test_parser/extattr_ppapi.idl [delete] https://crrev.com/fc185a85198149b326df53956fe8e30401215d3a/tools/idl_parser/test_parser/inline_ppapi.idl [delete] https://crrev.com/fc185a85198149b326df53956fe8e30401215d3a/tools/idl_parser/test_parser/label_ppapi.idl [delete] https://crrev.com/fc185a85198149b326df53956fe8e30401215d3a/tools/idl_parser/test_parser/struct_ppapi.idl [delete] https://crrev.com/fc185a85198149b326df53956fe8e30401215d3a/tools/idl_parser/test_parser/typedef_ppapi.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a50b4ecbbf6f9b304fef48c6afc7327999a13d02 commit a50b4ecbbf6f9b304fef48c6afc7327999a13d02 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Fri Jun 23 02:27:16 2017 IDL parser: Merge custom rules to the base parser Upstream some rules in blink_idl_parser to idl_parser. BUG=617899 Change-Id: Ib9c0e68b1e81ab41147e01c5281e3e7f8366999d Reviewed-on: https://chromium-review.googlesource.com/544724 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#481790} [modify] https://crrev.com/a50b4ecbbf6f9b304fef48c6afc7327999a13d02/third_party/WebKit/Source/bindings/scripts/blink_idl_parser.py [modify] https://crrev.com/a50b4ecbbf6f9b304fef48c6afc7327999a13d02/tools/idl_parser/idl_parser.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e46f03a4ddae8ac970c9e8fadba8dce49931e49 commit 4e46f03a4ddae8ac970c9e8fadba8dce49931e49 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Fri Jun 23 13:07:18 2017 IDL parser: Ignore comments Before this CL the base lexer treated comments as tokens and the base parser had some custom rules to handle special comments like copyrights. Blink's lexer/parser needed to extend the base lexer/parser to remove comments as otherwise comments must be explicitly included in the grammar. Since the base parser is only used by Blink and Blink doesn't need comments (at least now), it makes sense to ignore comments in the base lexer/parser. This enables us to remove all custom rules from BlinkIDLParser. BUG=617899 Change-Id: I6ead510680457dfb13ed9797ac056c34c185e292 Reviewed-on: https://chromium-review.googlesource.com/544424 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#481863} [modify] https://crrev.com/4e46f03a4ddae8ac970c9e8fadba8dce49931e49/third_party/WebKit/Source/bindings/scripts/blink_idl_lexer.py [modify] https://crrev.com/4e46f03a4ddae8ac970c9e8fadba8dce49931e49/third_party/WebKit/Source/bindings/scripts/blink_idl_parser.py [modify] https://crrev.com/4e46f03a4ddae8ac970c9e8fadba8dce49931e49/tools/idl_parser/idl_lexer.py [modify] https://crrev.com/4e46f03a4ddae8ac970c9e8fadba8dce49931e49/tools/idl_parser/idl_parser.py [modify] https://crrev.com/4e46f03a4ddae8ac970c9e8fadba8dce49931e49/tools/idl_parser/test_lexer/values.in
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/186b4b9f09be908f33e2d94248a2c1c2123f0e86 commit 186b4b9f09be908f33e2d94248a2c1c2123f0e86 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Sun Jun 25 07:29:16 2017 IDL parser: Remove outdated number comments These numbers aren't used any more in the spec grammar[1]. [1] https://heycam.github.io/webidl/#idl-grammar BUG=617899 Change-Id: I2754bdf77aed75577769920b84517df1aa264a9c Reviewed-on: https://chromium-review.googlesource.com/547079 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#482170} [modify] https://crrev.com/186b4b9f09be908f33e2d94248a2c1c2123f0e86/tools/idl_parser/idl_parser.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0680af0b0a7b0a4eec1f792017085bba13493e88 commit 0680af0b0a7b0a4eec1f792017085bba13493e88 Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Sun Jul 02 18:25:50 2017 bindings: Remove support for exception interfaces. They were removed from the WebIDL spec in 2014 ("Removed IDL exceptions, baked in DOMException, and added Error and DOMException as types"): https://github.com/heycam/webidl/commit/50e172ec079db073c3724c9beac1b576fb5dbc47 Support for exception interfaces was implemented by treating them like WebIDL interfaces and setting |is_exception| in IdlException (which inherited from IdlInterface). Since DOMException was the only exception interface we had in the tree, we can just turn it into a proper interface, check for its name when we need to set |is_exception| and remove all the lexer/parser/bindings scaffolding we had. V8DOMException.{cpp,h} generated after the new DOMException.idl have been verified to be identical to their previous version. There is work upstream to make DOMException a proper interface (see https://github.com/heycam/webidl/pull/378). This change can go in regardless of the upstream pull request upstream takes, as exception interfaces have been dead and gone for years. Bug: 617899, 737497 Change-Id: Iea16c7da733180cd61b14471d0758d5dd68158dc Reviewed-on: https://chromium-review.googlesource.com/558088 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#483921} [modify] https://crrev.com/0680af0b0a7b0a4eec1f792017085bba13493e88/third_party/WebKit/Source/bindings/scripts/idl_definitions.py [modify] https://crrev.com/0680af0b0a7b0a4eec1f792017085bba13493e88/third_party/WebKit/Source/bindings/scripts/idl_reader.py [modify] https://crrev.com/0680af0b0a7b0a4eec1f792017085bba13493e88/third_party/WebKit/Source/bindings/scripts/utilities.py [modify] https://crrev.com/0680af0b0a7b0a4eec1f792017085bba13493e88/third_party/WebKit/Source/bindings/scripts/v8_interface.py [delete] https://crrev.com/829f2e0b37d0175ac65aee0cbc9a603fcc994db7/third_party/WebKit/Source/bindings/tests/idls/core/TestException.idl [delete] https://crrev.com/829f2e0b37d0175ac65aee0cbc9a603fcc994db7/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp [delete] https://crrev.com/829f2e0b37d0175ac65aee0cbc9a603fcc994db7/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.h [modify] https://crrev.com/0680af0b0a7b0a4eec1f792017085bba13493e88/third_party/WebKit/Source/core/dom/DOMException.idl [modify] https://crrev.com/0680af0b0a7b0a4eec1f792017085bba13493e88/tools/idl_parser/idl_lexer.py [modify] https://crrev.com/0680af0b0a7b0a4eec1f792017085bba13493e88/tools/idl_parser/idl_parser.py [modify] https://crrev.com/0680af0b0a7b0a4eec1f792017085bba13493e88/tools/idl_parser/test_lexer/keywords.in [delete] https://crrev.com/829f2e0b37d0175ac65aee0cbc9a603fcc994db7/tools/idl_parser/test_parser/exception_web.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21a9816c40cb184138a763b5ef0033884d5c715d commit 21a9816c40cb184138a763b5ef0033884d5c715d Author: Kenichi Ishibashi <bashi@chromium.org> Date: Fri Jul 21 17:29:39 2017 idl_parser: Add unittests for "implements" definitions The "PROP" pattern match checks and other checks except for "TREE" are currently broken and it's somewhat difficult to make them workable. It would be easier to check AST nodes directly. This CL drops "PROP" checks and adds some unittests. Follow-up CLs will remove other checks except for "TREE". BUG=617899 Change-Id: Ifb7041ab971fc584b0a43e8ce465e2e30905f9d4 Reviewed-on: https://chromium-review.googlesource.com/581129 Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#488690} [modify] https://crrev.com/21a9816c40cb184138a763b5ef0033884d5c715d/tools/idl_parser/idl_parser_test.py [modify] https://crrev.com/21a9816c40cb184138a763b5ef0033884d5c715d/tools/idl_parser/test_parser/callback_web.idl [modify] https://crrev.com/21a9816c40cb184138a763b5ef0033884d5c715d/tools/idl_parser/test_parser/dictionary_web.idl [modify] https://crrev.com/21a9816c40cb184138a763b5ef0033884d5c715d/tools/idl_parser/test_parser/enum_web.idl [delete] https://crrev.com/de2037a5b5e0d6ffd72547f3438a3790e46ebb08/tools/idl_parser/test_parser/implements_web.idl [modify] https://crrev.com/21a9816c40cb184138a763b5ef0033884d5c715d/tools/idl_parser/test_parser/interface_web.idl [modify] https://crrev.com/21a9816c40cb184138a763b5ef0033884d5c715d/tools/idl_parser/test_parser/typedef_web.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/538f3f51fcb40c196e0e9b80f12d35ed07f5e09b commit 538f3f51fcb40c196e0e9b80f12d35ed07f5e09b Author: Lisa Suzuki <lisabelle@google.com> Date: Mon Aug 14 05:01:32 2017 idl_parser: Add unittest for enum This CL converts two pattern-match based tests for enum definitions to unittests. Follow-up CLs will convert the rest of pattern-match based tests. Bug: 617899 Change-Id: I33329dec022bc8c36cf1501674e67a3dd8fefbbd Reviewed-on: https://chromium-review.googlesource.com/612036 Commit-Queue: Lisa Suzuki <lisabelle@google.com> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#494013} [modify] https://crrev.com/538f3f51fcb40c196e0e9b80f12d35ed07f5e09b/tools/idl_parser/idl_parser_test.py [modify] https://crrev.com/538f3f51fcb40c196e0e9b80f12d35ed07f5e09b/tools/idl_parser/test_parser/enum_web.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf5bdd52f63a57bb635eacf62e05837dede3dbc3 commit cf5bdd52f63a57bb635eacf62e05837dede3dbc3 Author: Lisa Suzuki <lisabelle@google.com> Date: Tue Aug 15 07:17:54 2017 idl_parser: Change test style for enum In the last CL(review URL: https://chromium-review.googlesource.com/c/612036), I converted 2 pattern-match based tests for enum definitions to unittests. In this CL, I added the rest of the unittests. Now all pattern-match based tests for enum definitions are replaced with unittests. In more detail: - replaced pattern-match based tests with unittests - testTrailingCommaIsAllowed - testErrorMissingCommaBetweenIdentifiers - testErrorExtraCommaBetweenIdentifiers - testUnexpectedKeywordError - testUnexpectedIdentifierError - removed two patterns which are the same as existing unittest (tools/idl_parser/idl_parser_test.py: Line 116: unittestTestEnums.testBasic() ) - deleted a file of pattern-matches - because all pattern-matches are replaced with unittests - (small improvement) - tools/idl_parser/idl_parser_test.py : Line 130: idl_txt -> idl_text Bug: 617899 Change-Id: I271e2214013e7dbb14fe7e243bc99d0f2b86ccdb Reviewed-on: https://chromium-review.googlesource.com/614925 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Lisa Suzuki <lisabelle@google.com> Cr-Commit-Position: refs/heads/master@{#494341} [modify] https://crrev.com/cf5bdd52f63a57bb635eacf62e05837dede3dbc3/tools/idl_parser/idl_parser_test.py [delete] https://crrev.com/d2e208d4142087c53818440694a976c88d2293ce/tools/idl_parser/test_parser/enum_web.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/782b1ce6c8b06502dcbe8374229bfa44a8fb21e1 commit 782b1ce6c8b06502dcbe8374229bfa44a8fb21e1 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Thu Aug 17 10:11:43 2017 idl_parser: Remove "BUILD" tree matching tests We converted all "BUILD" tests to unit tests and we no longer need to support it. Bug: 617899 Change-Id: I696fe6a6b742de1f26b478338867149741f9b155 Reviewed-on: https://chromium-review.googlesource.com/617821 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#495125} [modify] https://crrev.com/782b1ce6c8b06502dcbe8374229bfa44a8fb21e1/tools/idl_parser/idl_parser_test.py [modify] https://crrev.com/782b1ce6c8b06502dcbe8374229bfa44a8fb21e1/tools/idl_parser/test_parser/callback_web.idl [modify] https://crrev.com/782b1ce6c8b06502dcbe8374229bfa44a8fb21e1/tools/idl_parser/test_parser/dictionary_web.idl [modify] https://crrev.com/782b1ce6c8b06502dcbe8374229bfa44a8fb21e1/tools/idl_parser/test_parser/interface_web.idl [modify] https://crrev.com/782b1ce6c8b06502dcbe8374229bfa44a8fb21e1/tools/idl_parser/test_parser/typedef_web.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a382270e937e909bfd48b43baca968ba82db7d24 commit a382270e937e909bfd48b43baca968ba82db7d24 Author: Lisa Suzuki <lisabelle@google.com> Date: Mon Aug 21 10:17:42 2017 idl_parser: Made unittests for Extended Attribute In this CL I made 7 unittests for Extend Attribute definitions. There are 5 main patterns for Extended Attribute and I made tests for each ( 0) ~ 4) below ). In addition to them, I made 1 test for a combination of 2 patterns of Extended Attributes (5)) and 1 error test(6)). I don't think these tests for Extended Attribute are enough, and please tell me what kind of tests I should add. detail of this CL: (tools/idl_parser/idl_parser_test.py: Line 176 ~ 323) - 7 tests -0) testNoArguments -1) testArgumentList -2) testNamedArgumentList -3) testIdentifier -4) testIdentifierList -5) testCombinationOfExtendedAttributes -6) testErrorTrailingComma - made slight changes of coding style in other tests Bug: 617899 Change-Id: I97816867f3a2c645ac6359bbff71d7220c3e69e3 Reviewed-on: https://chromium-review.googlesource.com/620333 Commit-Queue: Lisa Suzuki <lisabelle@google.com> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#495902} [modify] https://crrev.com/a382270e937e909bfd48b43baca968ba82db7d24/tools/idl_parser/idl_parser.py [modify] https://crrev.com/a382270e937e909bfd48b43baca968ba82db7d24/tools/idl_parser/idl_parser_test.py [modify] https://crrev.com/a382270e937e909bfd48b43baca968ba82db7d24/tools/idl_parser/test_parser/interface_web.idl
Comment 1 by bugdroid1@chromium.org
, Jun 7 2016