GN: Need mechanism to share parts of a .gn config |
|||||||||
Issue descriptionV8 rolls src/build as a dependency but has its own .gn file. Each time e.g. somebody adds something to build that requires an exec_script whitelist, V8's gn run breaks, as the whitelisting is only added to chromium's .gn and not V8's. Instead of sharing, it would be even better to whitelist all files in build as these are third_party deps from a v8 p-o-v. Is there a wildcard for files available? Example breakage: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20swarming%20staging/builds/2899/steps/gn/logs/stdio From this roll: https://codereview.chromium.org/2046883002 Breaking change on the chromium side (the whitelisting in .gn existed already before this commit): https://chromium.googlesource.com/chromium/src/build/+/aa9fdeb08461f379855639c5dca1d0c173a5eed8
,
Jun 7 2016
,
Jun 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/2254abbfe4dec3d7090e06432e2abf311b754132 commit 2254abbfe4dec3d7090e06432e2abf311b754132 Author: machenbach <machenbach@chromium.org> Date: Tue Jun 07 07:47:59 2016 [gn] Port exec_script whitelist from chromium/src/build BUG= chromium:617873 NOTRY=true TBR=jochen@chromium.org, vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2046563004 Cr-Commit-Position: refs/heads/master@{#36773} [modify] https://crrev.com/2254abbfe4dec3d7090e06432e2abf311b754132/.gn
,
Jun 21 2016
,
Aug 7 2016
,
Aug 10 2016
,
Aug 17 2016
import() may work from the .gn context. If that works we can put some of this stuff in //build.
,
Nov 17 2016
import() appears to work fine. I've uploaded something to https://codereview.chromium.org/2512043002 . Let me know what you think.
,
Nov 18 2016
,
Nov 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1cfa53187039597e5cdaa302cab1921a57060dce commit 1cfa53187039597e5cdaa302cab1921a57060dce Author: dpranke <dpranke@chromium.org> Date: Tue Nov 22 03:07:47 2016 Move the GN exec_script whitelist for //build into //build. This change moves the list of files that are allowed to call exec_script() into a variable in a file in the //build directory, so that the list can be shared more easily by other repos that are pulling in //build via DEPS but have their own custom dotfile. R=brettw@chromium.org, machenbach@chromium.org BUG= 617873 Review-Url: https://codereview.chromium.org/2512043002 Cr-Commit-Position: refs/heads/master@{#433764} [modify] https://crrev.com/1cfa53187039597e5cdaa302cab1921a57060dce/.gn [add] https://crrev.com/1cfa53187039597e5cdaa302cab1921a57060dce/build/dotfile_settings.gni
,
Nov 22 2016
,
Nov 29 2016
Thanks for fixing! Ported to V8.
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/ad6f646a3f113df44be97edfe887cd6b737c42e7 commit ad6f646a3f113df44be97edfe887cd6b737c42e7 Author: kjellander <kjellander@webrtc.org> Date: Tue Nov 29 14:35:14 2016 Use //build/dotfile_settings.gni to reduce blocked auto-rolls This was added in https://codereview.chromium.org/2512043002 BUG= chromium:617873 NOTRY=True Review-Url: https://codereview.webrtc.org/2534913002 Cr-Commit-Position: refs/heads/master@{#15297} [modify] https://crrev.com/ad6f646a3f113df44be97edfe887cd6b737c42e7/.gn |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by machenb...@chromium.org
, Jun 7 2016Labels: Proj-GN-Migration