Issue metadata
Sign in to add a comment
|
Regression:Text on bookmark bar is not displayed properly after installing 'the space' theme.
Reported by
vku...@etouch.net,
Jun 7 2016
|
||||||||||||||||||||||||
Issue descriptionChrome Version: 53.0.2760.0 (Official Build) 851eb42016eeca7ac932921164bb1fdb3a5844b3-refs/heads/master@{#397956} (64 Bit) OS:Mac (10.10.5 , 10.11.4),Mac Retina (10.11.4) What steps will reproduce the problem? 1.Freshly launch chrome and install 'the space' theme from https://chrome.google.com/webstore/detail/the-space/nchoeafalnaacdkpoodkjnbogigpjabk?utm_source=chrome-ntp-icon 2.After loading the theme open NTP and observe the text 'For quick access,place your...' on bookmark bar. Actual: Text on bookmark bar is not displayed properly after installing 'the space' theme (i.e white line/color appears on text) Expected: Text on bookmark bar should be properly displayed after installing 'the space' theme. This is a regression issue broken in 'M52' and will soon update other info.
,
Jun 7 2016
Adding RB label as this is a recent regression.
,
Jun 10 2016
Able to reproduce this issue on Mac OS 10.11.5 using chrome latest canary M53-53.0.2764.0 as well. shrike@ - Any update on this bug? Could you please take a look in to it.
,
Jun 11 2016
For the moment I'm guessing it's sub-pixel antialiasing with a transparent background, but I need to investigate more.
,
Jun 15 2016
Please have a fix ready and merge it to M52 branch once it is baked in Canary before 6/22 so that it can be picked up for next beta promotion.
,
Jun 16 2016
A friendly reminder that M52 Stable is launching soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch by July 12. All changes MUST be merged into the release branch by 5pm on July 15 to make into the desktop Stable final build cut. Thank you!
,
Jun 20 2016
Just to update: Still able to reproduce the issue on Mac 10.11.5 using latest M-53(53.0.2773.0).
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eadf1aa099669f7a232ee8deed94d5b9d2da14a8 commit eadf1aa099669f7a232ee8deed94d5b9d2da14a8 Author: shrike <shrike@chromium.org> Date: Wed Jun 22 20:33:26 2016 [Mac][Material Design] Fix regression with initial bookmark bar text. [Mac][Material Design] Fix regression with initial bookmark bar text. When you have an empty bookmarks bar, the bar displays a message about adding bookmarks. With the switch to Material Design and the addition of an NSVisualEffectView, the textfields' opaque ancestor was no longer opaque, messing up subpixel anti-aliasing. This cl changes the BookmarkBarToolbarView's isOpaque: method to always return YES. The BookmarkBarToolbarView was in fact always opaque, so returning YES is correct. Doing so causes the BookmarkBarToolbarView's to be the textfields' opaque ancestor, leading to correctly-drawn text. R=tapted@chromium.org BUG= 617550 , 617856 Review-Url: https://codereview.chromium.org/2061353002 Cr-Commit-Position: refs/heads/master@{#401391} [modify] https://crrev.com/eadf1aa099669f7a232ee8deed94d5b9d2da14a8/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm
,
Jun 23 2016
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5825147fa986abde5d2a293d06d1cac8ac8314e commit d5825147fa986abde5d2a293d06d1cac8ac8314e Author: Jayson Adams <shrike@chromium.org> Date: Mon Jun 27 22:27:42 2016 [Mac][Material Design] Fix regression with initial bookmark bar text. [Mac][Material Design] Fix regression with initial bookmark bar text. When you have an empty bookmarks bar, the bar displays a message about adding bookmarks. With the switch to Material Design and the addition of an NSVisualEffectView, the textfields' opaque ancestor was no longer opaque, messing up subpixel anti-aliasing. This cl changes the BookmarkBarToolbarView's isOpaque: method to always return YES. The BookmarkBarToolbarView was in fact always opaque, so returning YES is correct. Doing so causes the BookmarkBarToolbarView's to be the textfields' opaque ancestor, leading to correctly-drawn text. R=tapted@chromium.org BUG= 617550 , 617856 Review-Url: https://codereview.chromium.org/2061353002 Cr-Commit-Position: refs/heads/master@{#401391} (cherry picked from commit eadf1aa099669f7a232ee8deed94d5b9d2da14a8) Review URL: https://codereview.chromium.org/2100323003 . Cr-Commit-Position: refs/branch-heads/2743@{#490} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/d5825147fa986abde5d2a293d06d1cac8ac8314e/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by vku...@etouch.net
, Jun 7 2016Owner: shrike@chromium.org
Status: Assigned (was: Unconfirmed)
1.2 MB
1.2 MB View Download
1.3 MB
1.3 MB View Download