OSX MD: Incognito window over regular window shows a bright top left rounded corner |
||
Issue description(Splitting out from Issue 617852 ) Chrome 53.0.2760.0 OSX 10.11.5 What steps will reproduce the problem? (1) Open a dark background app/image using an app other than Chrom (2) Open a regular window (3) On top of the regular window, open an incognito window aligned with the same top and left position What is the expected output? The incognito window does not have a border. What do you see instead? The regular window shows through as a bright quarter-circle border. (incognito-over-regular.png) This requires the top and left of the windows to be aligned, but this is common if you maximize, or use a window manager.
,
Mar 20 2017
I still run into this once in a while. ;-) If I wanted to look into a quick fix, where would I start?
,
Aug 2 2017
With the MD release of Chrome we now place an NSVisualEffectView at the top of the window, behind the tabs in the tabstrip. An NSVisualEffectView is translucent, letting some of the desktop behind the window show through. There are "light" and "dark" versions of this surface. Incognito windows use the dark version, but the result is not dark enough (it's more of a muddy gray - see attached screenshot). We make it darker with an overlay of transparent black. Originally I had suspected this thin gray edge had something to do with the overlay, noting that the problem goes away when there's no overlay. I tried a few things, the most interesting being stroking the overlay along the window edge with opaque black. The attached screenshot (magnified in Photoshop) shows that the Incognito window still has a slight ghost of a light window corner edge. I suspect this is a byproduct of the lighter NSVisualEffectView that sits beneath the overlay. It also seems like the normal browser window has a slightly different corner shape (it uses the light version of the NSVisualEffectView). The resulting bright rounded corner seems to be the faint ghost curve overlaying the exposed normal browser window corner's edge. The problem "goes away" by removing the overlay because the ghost curve no longer contrasts with the window's title bar area.
,
Aug 2 2017
Your second screenshot looks pretty good – should I be seeing that in Canary? Do I need any flags?
,
Aug 2 2017
My second screenshot shows an Incognito window against a dark background, without a regular browser underneath. For reasons explained in c#3, there doesn't appear to be a way to fix this problem.
,
Aug 2 2017
Okay, I'll give up my dreams of a pixel-perfect experience. *sniffles* :'( (But actually, I trust your judgment on pragmatism.)
,
Aug 2 2017
> (But actually, I trust your judgment on pragmatism.) I'm not saying it will be hard or a lot of work to fix this, I'm saying I don't see a way to fix it. So not really being pragmatic - there is no way forward. |
||
►
Sign in to add a comment |
||
Comment 1 by shrike@chromium.org
, Nov 16 2016