Linux client doesn't render fonts correctly |
|||||||
Issue descriptionSee screenshot. Command line arguments used to run: xyzzyz@xyzzyz:~/chromium/src$ out-engine/Default/blimp_engine_app --use-remote-compositing --disable-cached-picture-raster --blimp-client-token-path=/tmp/blimpengine-token --user-data-dir=/tmp/blimpengine --android-fonts-path=out-engine/Default/gen/third_party/blimp_fonts --enable-logging=stderr --vmodule="blimp*=1" xyzzyz@xyzzyz:~/chromium/src$ out-client/Default/blimp_shell --user-data-dir=/tmp/blimpclient --enable-logging=stderr --vmodule="*=1" --engine-ip=127.0.0.1 --engine-port=25467 --engine-transport=tcp --blimp-client-token-path=/tmp/blimpengine-token --android-fonts-path=out-engine/Default/gen/third_party/blimp_fonts
,
Jul 18 2016
,
Jul 27 2016
Looks like the Linux client is most likely entirely ignoring the specified font-path. The content-layer support for that flag is at: https://cs.chromium.org/chromium/src/content/zygote/zygote_main_linux.cc?sq=package:chromium&rcl=1469618171&l=364 There is no equivalent handling for the blimp_shell binary, though; we'll need to add that in the blimp_shell:blimp_main.cc, for example, to feed the correct font-manager to CC. Adding this to my queue of Linux blimp_shell cleanups to-do.
,
Aug 30 2016
,
Nov 14 2016
,
Nov 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6c1cd2bb6a2253e9547c091671c98ed28300685 commit f6c1cd2bb6a2253e9547c091671c98ed28300685 Author: steimel <steimel@chromium.org> Date: Tue Nov 15 00:40:55 2016 Add skia extension to allow setting default fontmgr on linux. Use it to allow the linux blimp client to use android fonts BUG= 617821 Review-Url: https://codereview.chromium.org/2500643002 Cr-Commit-Position: refs/heads/master@{#432023} [modify] https://crrev.com/f6c1cd2bb6a2253e9547c091671c98ed28300685/blimp/client/app/linux/blimp_main.cc [modify] https://crrev.com/f6c1cd2bb6a2253e9547c091671c98ed28300685/blimp/client/core/switches/blimp_client_switches.cc [modify] https://crrev.com/f6c1cd2bb6a2253e9547c091671c98ed28300685/blimp/client/core/switches/blimp_client_switches.h [modify] https://crrev.com/f6c1cd2bb6a2253e9547c091671c98ed28300685/skia/BUILD.gn [add] https://crrev.com/f6c1cd2bb6a2253e9547c091671c98ed28300685/skia/ext/fontmgr_default_linux.cc [add] https://crrev.com/f6c1cd2bb6a2253e9547c091671c98ed28300685/skia/ext/fontmgr_default_linux.h
,
Nov 15 2016
,
Nov 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbf14bb02366acf3cb250c98c10208e8f955ad53 commit cbf14bb02366acf3cb250c98c10208e8f955ad53 Author: horo <horo@chromium.org> Date: Tue Nov 15 03:48:45 2016 Revert of Add skia extension to allow setting default fontmgr on linux. Use it to allow the linux blimp clien… (patchset #4 id:60001 of https://codereview.chromium.org/2500643002/ ) Reason for revert: Caused failures at "sizes" check on Linux x64 bot. https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64 See crbug.com/665274 BUG= 665274 Original issue's description: > Add skia extension to allow setting default fontmgr on linux. Use it to allow the linux blimp client to use android fonts > > BUG= 617821 > > Committed: https://crrev.com/f6c1cd2bb6a2253e9547c091671c98ed28300685 > Cr-Commit-Position: refs/heads/master@{#432023} TBR=bungeman@chromium.org,khushalsagar@chromium.org,bungeman@google.com,steimel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 617821 Review-Url: https://codereview.chromium.org/2503763002 Cr-Commit-Position: refs/heads/master@{#432082} [modify] https://crrev.com/cbf14bb02366acf3cb250c98c10208e8f955ad53/blimp/client/app/linux/blimp_main.cc [modify] https://crrev.com/cbf14bb02366acf3cb250c98c10208e8f955ad53/blimp/client/core/switches/blimp_client_switches.cc [modify] https://crrev.com/cbf14bb02366acf3cb250c98c10208e8f955ad53/blimp/client/core/switches/blimp_client_switches.h [modify] https://crrev.com/cbf14bb02366acf3cb250c98c10208e8f955ad53/skia/BUILD.gn [delete] https://crrev.com/94ff3d8045484adcb0daba7a05465edf813679a0/skia/ext/fontmgr_default_linux.cc [delete] https://crrev.com/94ff3d8045484adcb0daba7a05465edf813679a0/skia/ext/fontmgr_default_linux.h
,
Nov 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/deb6095223d0ee029136cb1708d81c3d91257e0b commit deb6095223d0ee029136cb1708d81c3d91257e0b Author: steimel <steimel@chromium.org> Date: Fri Nov 18 20:56:43 2016 Add skia extension to allow setting default fontmgr on linux. Use it to allow the linux blimp client to use android fonts BUG= 617821 Committed: https://crrev.com/f6c1cd2bb6a2253e9547c091671c98ed28300685 Review-Url: https://codereview.chromium.org/2500643002 Cr-Original-Commit-Position: refs/heads/master@{#432023} Cr-Commit-Position: refs/heads/master@{#433292} [modify] https://crrev.com/deb6095223d0ee029136cb1708d81c3d91257e0b/blimp/client/app/linux/blimp_main.cc [modify] https://crrev.com/deb6095223d0ee029136cb1708d81c3d91257e0b/blimp/client/core/switches/blimp_client_switches.cc [modify] https://crrev.com/deb6095223d0ee029136cb1708d81c3d91257e0b/blimp/client/core/switches/blimp_client_switches.h [modify] https://crrev.com/deb6095223d0ee029136cb1708d81c3d91257e0b/skia/BUILD.gn [add] https://crrev.com/deb6095223d0ee029136cb1708d81c3d91257e0b/skia/ext/fontmgr_default_linux.cc [add] https://crrev.com/deb6095223d0ee029136cb1708d81c3d91257e0b/skia/ext/fontmgr_default_linux.h
,
Dec 9 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by xyzzyz@chromium.org
, Jun 7 2016