Improve media efficiency by suspending more often and resuming less. |
|||||
Issue descriptionCurrently we: - Don't suspend paused media immediately on background. - We resume paused media when becoming visible (despite no user interaction). - We resume playing media always (despite even a large amount of time elapsing).
,
Jun 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b8505e78452b365b861025d7b3364ca4b1e5849 commit 8b8505e78452b365b861025d7b3364ca4b1e5849 Author: dalecurtis <dalecurtis@chromium.org> Date: Fri Jun 10 21:59:17 2016 Don't resume paused media. Don't resume playing media after timeout. As titled. We shouldn't resume paused media because there's no reason to not wait for the user interaction. We shouldn't resume playing media if the user has moved on to other tasks and comes back some time later. The idle timeout for resuming playing media is 5 seconds as chosen by a dice roll. BUG= 617815 TEST=media suspends and resumes as expected. Review-Url: https://codereview.chromium.org/2039793005 Cr-Commit-Position: refs/heads/master@{#399287} [modify] https://crrev.com/8b8505e78452b365b861025d7b3364ca4b1e5849/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/8b8505e78452b365b861025d7b3364ca4b1e5849/media/blink/webmediaplayer_impl.h [modify] https://crrev.com/8b8505e78452b365b861025d7b3364ca4b1e5849/media/blink/webmediaplayer_impl_unittest.cc
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b8505e78452b365b861025d7b3364ca4b1e5849 commit 8b8505e78452b365b861025d7b3364ca4b1e5849 Author: dalecurtis <dalecurtis@chromium.org> Date: Fri Jun 10 21:59:17 2016 Don't resume paused media. Don't resume playing media after timeout. As titled. We shouldn't resume paused media because there's no reason to not wait for the user interaction. We shouldn't resume playing media if the user has moved on to other tasks and comes back some time later. The idle timeout for resuming playing media is 5 seconds as chosen by a dice roll. BUG= 617815 TEST=media suspends and resumes as expected. Review-Url: https://codereview.chromium.org/2039793005 Cr-Commit-Position: refs/heads/master@{#399287} [modify] https://crrev.com/8b8505e78452b365b861025d7b3364ca4b1e5849/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/8b8505e78452b365b861025d7b3364ca4b1e5849/media/blink/webmediaplayer_impl.h [modify] https://crrev.com/8b8505e78452b365b861025d7b3364ca4b1e5849/media/blink/webmediaplayer_impl_unittest.cc
,
Jun 23 2016
This affects the behavior of an unreleased feature, so rather than shipping and changing it we should launch it consistently for M52.
,
Jun 23 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/772333224fa164579e5b82770c6dd2e6231f2256 commit 772333224fa164579e5b82770c6dd2e6231f2256 Author: Dale Curtis <dalecurtis@chromium.org> Date: Thu Jun 23 00:15:56 2016 Merge M52: "Don't resume paused media. Don't resume playing media after timeout." As titled. We shouldn't resume paused media because there's no reason to not wait for the user interaction. We shouldn't resume playing media if the user has moved on to other tasks and comes back some time later. The idle timeout for resuming playing media is 5 seconds as chosen by a dice roll. BUG= 617815 TEST=media suspends and resumes as expected. Review-Url: https://codereview.chromium.org/2039793005 Cr-Commit-Position: refs/heads/master@{#399287} (cherry picked from commit 8b8505e78452b365b861025d7b3364ca4b1e5849) Review URL: https://codereview.chromium.org/2085133005 . Cr-Commit-Position: refs/branch-heads/2743@{#452} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/772333224fa164579e5b82770c6dd2e6231f2256/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/772333224fa164579e5b82770c6dd2e6231f2256/media/blink/webmediaplayer_impl.h [modify] https://crrev.com/772333224fa164579e5b82770c6dd2e6231f2256/media/blink/webmediaplayer_impl_unittest.cc
,
Jun 23 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sheriffbot@chromium.org
, Jun 7 2016