New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 617806 link

Starred by 8 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Linux: Dragging a window by a tab is constrained by the screen

Project Member Reported by chaorenl@chromium.org, Jun 6 2016

Issue description

Chrome Version (from the about:version page): 50.0.2661.94 (Official Build) (64-bit)
Is this the most recent version:
OS + version: Ubuntu 14.04 LTS
CPU architecture (32-bit / 64-bit): 64-bit
Window manager: Compiz
URLs (if relevant):
Behavior in Linux Firefox:
Behavior in Windows Chrome (if you have access to it):

What steps will reproduce the problem?
(1) Try to drag a tab out of a Window
(2) The tab will get stuck a short distance away from where I started dragging
(3) When I let go the tab maximizes (this might be the cause of step 2)

What is the expected result?
I should be able to drag the newly detached tab any where I want on the screen and across monitors

What happens instead?
I can only drag the tab within one screen, and the anchor point of the tab remains within an inch or so from its original location. The mouse can move freely, the tab would just get stuck at a barrier. You can see this in the attached screenshots.
This also happens when I drag a tab from a non-maximized Window. The resulting detached tab maximizes after I let go in this case too.

What I have to do to drag an arbitrary tab to an arbitrary window right now is:
1. Drag tab off of current window.
2. Let go, and it maximizes.
3. Un-maximize it.
4. Drag it to the target window.
5. Let go so it merges.


Please provide any additional information below. Attach a screenshot
and backtrace if possible.

Only happens on Linux, not on Windows or OS X.

 
start.png
119 KB View Download
drag left.png
147 KB View Download
drag right.png
149 KB View Download
Components: UI>Browser
Labels: M-53
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Linux Ubuntu 14.04 using chrome version 51.0.2704.84 and canary 53.0.2763.0.
Please find the attached screen cast for the same.
This is non regression issue as the issue seen from M35 builds.
Marking it as Utriaged to get it addressed.

Thanks,
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 6 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
> Moving this nonessential bug to the next milestone.

How is this nonessential? Is it because it's only on Linux? Or it's just something the bot says when no one's touching this issue?
Moving tabs around is a common user action, and this bug is extremely visible and annoying.
It's amazing that no one has reported this issue that's existed since M35. I can't be the only person annoyed by this. Do we just not have that many Linux users?
Cc: e...@chromium.org
Labels: -Pri-3 Pri-2
Owner: thomasanderson@chromium.org
Hi chaorenl@
I'm guessing you're using Compiz/Unity?  Goobuntu 14.04 with nvidia graphics drivers?
Can you please attach a screencast so I can better understand what's going on


> I'm guessing you're using Compiz/Unity?  Goobuntu 14.04 with nvidia graphics drivers?

Yes, and yes.

> Can you please attach a screencast so I can better understand what's going on

I thought kavvaru@ reproduced this, and attached a screecast, but here's mine.
capture.webm
26.5 MB Download
Cc: thomasanderson@chromium.org pkasting@chromium.org
 Issue 635192  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbb8975f1693f4fb33d54f62bbef19a70a4bc724

commit fbb8975f1693f4fb33d54f62bbef19a70a4bc724
Author: thomasanderson <thomasanderson@google.com>
Date: Wed Oct 12 23:47:31 2016

Linux Aura: Make tab dragging great again

This CL uses _NET_WM_MOVERESIZE to handle tab dragging for managed windows on
select window managers.

This fixes various issues I've seen with tab dragging including:
* Window movement is no longer constrained by screen bounds
* Windows animating in during tab dragging is minimized
* Tab dragging is improved on tiling WMs
* Better integration with desktop environment (you can now drag to the top of
  the screen to maximize if the DE supports it, or drag left/right between
  workspaces)

BUG=416119,617806,635195
R=erg@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2410773002
Cr-Commit-Position: refs/heads/master@{#424909}

[modify] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/ui/base/x/x11_util.cc
[modify] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/ui/base/x/x11_util.h
[modify] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/ui/views/BUILD.gn
[modify] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
[modify] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h
[add] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/ui/views/widget/desktop_aura/x11_desktop_window_move_client_managed.cc
[add] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/ui/views/widget/desktop_aura/x11_desktop_window_move_client_managed.h
[modify] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/ui/views/widget/desktop_aura/x11_window_event_filter.cc
[modify] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/ui/views/widget/desktop_aura/x11_window_event_filter.h
[modify] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/ui/wm/public/window_move_client.h

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3

commit ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3
Author: thomasanderson <thomasanderson@chromium.org>
Date: Tue Nov 01 20:31:03 2016

Revert of Linux Aura: Make tab dragging great again (patchset #4 id:60001 of https://codereview.chromium.org/2410773002/ )

Reason for revert:
Suspecting this is causing 661248, so conservatively reverting.

Original issue's description:
> Linux Aura: Make tab dragging great again
>
> This CL uses _NET_WM_MOVERESIZE to handle tab dragging for managed windows on
> select window managers.
>
> This fixes various issues I've seen with tab dragging including:
> * Window movement is no longer constrained by screen bounds
> * Windows animating in during tab dragging is minimized
> * Tab dragging is improved on tiling WMs
> * Better integration with desktop environment (you can now drag to the top of
>   the screen to maximize if the DE supports it, or drag left/right between
>   workspaces)
>
> BUG=416119,617806,635195
> R=erg@chromium.org,sky@chromium.org
>
> Committed: https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724
> Cr-Commit-Position: refs/heads/master@{#424909}

TBR=erg@chromium.org,sky@chromium.org,derat@chromium.org,thomasanderson@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=416119,617806,635195

BUG= 661248 

Review-Url: https://codereview.chromium.org/2467053002
Cr-Commit-Position: refs/heads/master@{#429093}

[modify] https://crrev.com/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3/ui/base/x/x11_util.cc
[modify] https://crrev.com/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3/ui/base/x/x11_util.h
[modify] https://crrev.com/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3/ui/views/BUILD.gn
[modify] https://crrev.com/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
[modify] https://crrev.com/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h
[delete] https://crrev.com/4025c2cba57945b8b51ef021e2915906f3c71b0d/ui/views/widget/desktop_aura/x11_desktop_window_move_client_managed.cc
[delete] https://crrev.com/4025c2cba57945b8b51ef021e2915906f3c71b0d/ui/views/widget/desktop_aura/x11_desktop_window_move_client_managed.h
[modify] https://crrev.com/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3/ui/views/widget/desktop_aura/x11_window_event_filter.cc
[modify] https://crrev.com/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3/ui/views/widget/desktop_aura/x11_window_event_filter.h
[modify] https://crrev.com/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3/ui/wm/public/window_move_client.h

Ping? It's been several months since the fix was reverted. Any chance of fixing it again? Or is  crbug.com/661248  making this infeasible?
Status: Assigned (was: Untriaged)
Summary: Linux: Dragging a window by a tab is constrained by the screen (was: Can't freely drag tabs off of windows on Linux)
Cc: sandeepkumars@chromium.org mmanchala@chromium.org
 Issue 719436  has been merged into this issue.
Cc: durga.behera@chromium.org rponnada@chromium.org
 Issue 376380  has been merged into this issue.

Comment 14 by e...@chromium.org, Mar 9 2018

Cc: -e...@chromium.org
Un-cc-ing me from all bugs on my final day.
Still happening as of Version 69.0.3452.0 (Official Build) dev (64-bit).

Sign in to add a comment