New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 617805 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 2
Type: Bug

Blocked on:
issue 617866



Sign in to add a comment

SVG rendering broken with Chromium path rendering

Project Member Reported by vmi...@chromium.org, Jun 6 2016

Issue description

Version: r398134
OS: Android

Testing on Pixel C where the Chromium path rendering extension is available.

The following SVG rendering test appears all black: http://vmiura.github.io/svg-anim/svg-anim.html?1,tiger


 
Cc: kbr@chromium.org
Labels: OS-Android OS-Linux
Reproduced on Linux with GeForce GTX 950 also.

+kbr@ as we have a blind spot in our GPU hardware testing here.
Owner: kkinnu...@nvidia.com
Status: Assigned (was: Available)
fixed in https://chromiumcodereview.appspot.com/2031263002/
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b4f64f3c1564a04a688ea3fcefe3f5c4fe339fa

commit 3b4f64f3c1564a04a688ea3fcefe3f5c4fe339fa
Author: vmiura <vmiura@chromium.org>
Date: Tue Jun 07 05:27:57 2016

Strengthen GpuRasterizationConcavePathsPagetest test.

This test was passing when the entire 'pacman' image area was filled
with the 'interior' color.  This change ensures that we test pixels on
the exterior and interior of the paths, within the pacman's bounds.

R=kbr@chromium.org
BUG= 617805 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2042143002
Cr-Commit-Position: refs/heads/master@{#398234}

[modify] https://crrev.com/3b4f64f3c1564a04a688ea3fcefe3f5c4fe339fa/content/test/gpu/page_sets/gpu_rasterization_tests.py

Comment 4 by kbr@chromium.org, Jun 7 2016

Blockedon: 617866
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f11e62040635b57dccb826c1124ba53afc485792

commit f11e62040635b57dccb826c1124ba53afc485792
Author: geofflang <geofflang@chromium.org>
Date: Tue Jun 07 17:10:37 2016

Revert of Strengthen GpuRasterizationConcavePathsPagetest test. (patchset #1 id:1 of https://codereview.chromium.org/2042143002/ )

Reason for revert:
Broke the GpuRasterization.ConcavePaths test on Nexus 9. https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Debug%20%28Nexus%209%29/builds/1470

Original issue's description:
> Strengthen GpuRasterizationConcavePathsPagetest test.
>
> This test was passing when the entire 'pacman' image area was filled
> with the 'interior' color.  This change ensures that we test pixels on
> the exterior and interior of the paths, within the pacman's bounds.
>
> R=kbr@chromium.org
> BUG= 617805 
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/3b4f64f3c1564a04a688ea3fcefe3f5c4fe339fa
> Cr-Commit-Position: refs/heads/master@{#398234}

TBR=kbr@chromium.org,vmiura@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 617805 

Review-Url: https://codereview.chromium.org/2040143003
Cr-Commit-Position: refs/heads/master@{#398317}

[modify] https://crrev.com/f11e62040635b57dccb826c1124ba53afc485792/content/test/gpu/page_sets/gpu_rasterization_tests.py

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0c04c06222dfe91da2ae24f69ee45a4d5cfc585

commit d0c04c06222dfe91da2ae24f69ee45a4d5cfc585
Author: kbr <kbr@chromium.org>
Date: Tue Jun 07 17:39:37 2016

Reland of Strengthen GpuRasterizationConcavePathsPagetest test. (patchset #1 id:1 of https://codereview.chromium.org/2040143003/ )

Reason for revert:
The test is more correct than it was. Chrome on the Nexus 9 is broken. Let's add a suppression instead of reverting the test.

Original issue's description:
> Revert of Strengthen GpuRasterizationConcavePathsPagetest test. (patchset #1 id:1 of https://codereview.chromium.org/2042143002/ )
>
> Reason for revert:
> Broke the GpuRasterization.ConcavePaths test on Nexus 9. https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Debug%20%28Nexus%209%29/builds/1470
>
> Original issue's description:
> > Strengthen GpuRasterizationConcavePathsPagetest test.
> >
> > This test was passing when the entire 'pacman' image area was filled
> > with the 'interior' color.  This change ensures that we test pixels on
> > the exterior and interior of the paths, within the pacman's bounds.
> >
> > R=kbr@chromium.org
> > BUG= 617805 
> > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Committed: https://crrev.com/3b4f64f3c1564a04a688ea3fcefe3f5c4fe339fa
> > Cr-Commit-Position: refs/heads/master@{#398234}
>
> TBR=kbr@chromium.org,vmiura@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 617805 
>
> Committed: https://crrev.com/f11e62040635b57dccb826c1124ba53afc485792
> Cr-Commit-Position: refs/heads/master@{#398317}

TBR=vmiura@chromium.org,geofflang@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 617805 

Review-Url: https://codereview.chromium.org/2046023002
Cr-Commit-Position: refs/heads/master@{#398325}

[modify] https://crrev.com/d0c04c06222dfe91da2ae24f69ee45a4d5cfc585/content/test/gpu/page_sets/gpu_rasterization_tests.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/737f0b91ba323760e33dc2b5b7d8a7be765cb979

commit 737f0b91ba323760e33dc2b5b7d8a7be765cb979
Author: kbr <kbr@chromium.org>
Date: Tue Jun 07 18:08:45 2016

Suppress GpuRasterization.ConcavePaths on Nexus 9.

The test's failing because of a legitimate bug. This suppression should
be removed after the bug's fixed.

BUG= 617805 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=vmiura@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2046523006
Cr-Commit-Position: refs/heads/master@{#398339}

[modify] https://crrev.com/737f0b91ba323760e33dc2b5b7d8a7be765cb979/content/test/gpu/gpu_tests/gpu_rasterization_expectations.py

Comment 8 by kbr@chromium.org, Jun 8 2016

Hmm. I hadn't realized https://codereview.chromium.org/2031263002/ had landed earlier today. Kimmo, could you please triple-check whether the suppression that landed above is necessary? If the test's still failing on the N9, could you take a look and see why? If it isn't, would you mind removing the failing suppression? Thanks.

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/122efd4d59a2a7fbef4a20a08866ab9a6c9e6145

commit 122efd4d59a2a7fbef4a20a08866ab9a6c9e6145
Author: kkinnunen <kkinnunen@nvidia.com>
Date: Wed Jun 08 19:04:43 2016

Enable GpuRasterization.ConcavePaths on Nexus devices

Enable GpuRasterization.ConcavePaths on Nexus devices.

The test inspects browser screenshot pixels.

In order to take a screenshot, device pixel ratio is used
to scale the screenshot rect.

In order to correlate logical pixels to physical pixels with device
pixel ratio, viewport scale needs to be set to 1.

BUG= 617805 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2045993004
Cr-Commit-Position: refs/heads/master@{#398629}

[modify] https://crrev.com/122efd4d59a2a7fbef4a20a08866ab9a6c9e6145/content/test/data/gpu/concave_paths.html
[modify] https://crrev.com/122efd4d59a2a7fbef4a20a08866ab9a6c9e6145/content/test/gpu/gpu_tests/gpu_rasterization_expectations.py

Status: Fixed (was: Assigned)

Sign in to add a comment