Issue metadata
Sign in to add a comment
|
Bookmark bar menu mouseover lags |
||||||||||||||||||||||
Issue descriptionVersion: 52.0.2743.24 beta OS: 10.11 - make sure you have a lot of bookmarks in your "other bookmarks" folder (i have enough to scroll but not sure if that's important). - Open a new tab - Click "other bookmarks" menu button on far right - mouse up and down through list expected: - mouseover hover follows mouse without lag actual: - so much lag, it takes seconds to catch up to the mouse if you move quickly. This does not reproduce with M51stable.
,
Jun 9 2016
@pinkerton, can you please also let us the know if this is noticed on a Retina or non-retina ?
,
Jun 9 2016
Able to reproduce the issue on MacBook Pro Retina chrome version 52.0.2743.24 and canary - mouseover lags with mouse movement This is working fine in stable version 51.0.2704.84 and hence a regression. This got regressed in M52 and below is the info Manual Bisect Info: Good build: 52.0.2741.0 Bad build: 52.0.2742.0 CL : https://chromium.googlesource.com/chromium/src/+log/52.0.2741.0..52.0.2742.0?pretty=fuller&n=10000 Suspecting : https://codereview.chromium.org/1987203003 Please reassign if this is not related to your change.
,
Jun 15 2016
just to update Issue is repro on MacBook Pro Retina chrome version canary #53.0.2768.0 shrike@, Could you please take a look
,
Jun 16 2016
,
Jun 16 2016
A friendly reminder that M52 Stable is launching soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch by July 12. All changes MUST be merged into the release branch by 5pm on July 15 to make into the desktop Stable final build cut. Thank you!
,
Jun 20 2016
Just to update: Still able to reproduce the issue on Mac 10.11.5 using latest M-53(53.0.2773.0).
,
Jun 23 2016
shrike@ : Could you please take a look into this and update as the issue persists on latest canary 53.0.2777.0.
,
Jun 23 2016
cl is ready except for fixing a broken test. Hopefully will land this today.
,
Jun 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4e9a989d00a4753d2d6e1f5229da4ae9a302b5d commit b4e9a989d00a4753d2d6e1f5229da4ae9a302b5d Author: shrike <shrike@chromium.org> Date: Thu Jun 23 18:47:03 2016 [Mac][Material Design] Improve bookmark folder menu performance. This cl fixes a problem where if you move the mouse over an open bookmark folder window, if you move the mouse fast enough the hover state drawing begins to lag the mouse position. R=tapted@chromium.org BUG= 617803 Review-Url: https://codereview.chromium.org/2073753004 Cr-Commit-Position: refs/heads/master@{#401663} [modify] https://crrev.com/b4e9a989d00a4753d2d6e1f5229da4ae9a302b5d/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm [modify] https://crrev.com/b4e9a989d00a4753d2d6e1f5229da4ae9a302b5d/chrome/browser/ui/cocoa/bookmarks/bookmark_button.h
,
Jun 27 2016
Does this still need to be merged?
,
Jun 27 2016
,
Jun 27 2016
** IMPORTANT change in M52 merge date due to first 2 weeks of July no release weeks ** M52 Stable is launching very soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged ASAP. All changes MUST be merged into the release branch by 5pm on July 1 to make into the desktop Stable final build cut. Thank you!
,
Jun 27 2016
,
Jun 27 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 27 2016
Re: #12, yes, but I needed to confirm that it was working in the Canary before asking for a merge, and a new Canary wasn't pushed until maybe 15 minutes ago.
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db6231c47a1c77461238237f14eb77464093c612 commit db6231c47a1c77461238237f14eb77464093c612 Author: Jayson Adams <shrike@chromium.org> Date: Mon Jun 27 21:56:02 2016 [Mac][Material Design] Improve bookmark folder menu performance. This cl fixes a problem where if you move the mouse over an open bookmark folder window, if you move the mouse fast enough the hover state drawing begins to lag the mouse position. R=tapted@chromium.org BUG= 617803 Review-Url: https://codereview.chromium.org/2073753004 Cr-Commit-Position: refs/heads/master@{#401663} (cherry picked from commit b4e9a989d00a4753d2d6e1f5229da4ae9a302b5d) Review URL: https://codereview.chromium.org/2096303003 . Cr-Commit-Position: refs/branch-heads/2743@{#489} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/db6231c47a1c77461238237f14eb77464093c612/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm [modify] https://crrev.com/db6231c47a1c77461238237f14eb77464093c612/chrome/browser/ui/cocoa/bookmarks/bookmark_button.h
,
Jun 27 2016
,
Jun 30 2016
Tested the issue on Mac 10.11.5 Retina using chrome version 52.0.2743.60. mouseover hover followed mouse without any lag. Please find the attached screen cast for the same. Adding TE-Verified label Thanks, |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ligim...@chromium.org
, Jun 8 2016