"ExtensionStorageMonitorTest.UninstallExtension" is flaky |
||||||||
Issue description"ExtensionStorageMonitorTest.UninstallExtension" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOQsSBUZsYWtlIi5FeHRlbnNpb25TdG9yYWdlTW9uaXRvclRlc3QuVW5pbnN0YWxsRXh0ZW5zaW9uDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jun 10 2016
Detected 3 new flakes for test/step "ExtensionStorageMonitorTest.UninstallExtension". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOQsSBUZsYWtlIi5FeHRlbnNpb25TdG9yYWdlTW9uaXRvclRlc3QuVW5pbnN0YWxsRXh0ZW5zaW9uDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Jun 10 2016
ping? This is an assert popping: [28233:28233:0610/122918:ERROR:extension_function_dispatcher.cc(615)] Permission denied for test.log [28233:28233:0610/122918:FATAL:extension_function.cc(452)] Check failed: extensions::ExtensionsBrowserClient::Get()->IsShuttingDown() || did_respond_ || ignore_all_did_respond_for_testing_do_not_use. test.log #0 0x000001a6a59e base::debug::StackTrace::StackTrace() #1 0x000001a7efca logging::LogMessage::~LogMessage() #2 0x000005b66b22 SyncExtensionFunction::~SyncExtensionFunction() #3 0x000000679409 extensions::(anonymous namespace)::FakeSerialGetDevicesFunction::~FakeSerialGetDevicesFunction() #4 0x000005b69143 extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal() #5 0x000005b68bcf extensions::ExtensionFunctionDispatcher::Dispatch() #6 0x000005b85573 _ZN3IPC8MessageTI29ExtensionHostMsg_Request_MetaSt5tupleIJ31ExtensionHostMsg_Request_ParamsEEvE8DispatchIN10extensions28ExtensionWebContentsObserverES8_N7content15RenderFrameHostEMS8_FvPSA_RKS3_EEEbPKNS_7MessageEPT_PT0_PT1_T2_ #7 0x000005b854ba extensions::ExtensionWebContentsObserver::OnMessageReceived() #8 0x00000593fe3d extensions::ChromeExtensionWebContentsObserver::OnMessageReceived() #9 0x00000307e442 content::WebContentsImpl::OnMessageReceived() #10 0x000002f228e1 content::RenderFrameHostImpl::OnMessageReceived() #11 0x000002fc5336 content::RenderProcessHostImpl::OnMessageReceived() #12 0x000002e71c45 IPC::ChannelProxy::Context::OnDispatchMessage() #13 0x000001aeb129 base::debug::TaskAnnotator::RunTask() #14 0x000001a859b5 base::MessageLoop::RunTask() #15 0x000001a85ca8 base::MessageLoop::DeferOrRunPendingTask() #16 0x000001a85fcb base::MessageLoop::DoWork() #17 0x000001ae844a base::(anonymous namespace)::WorkSourceDispatch() #18 0x7f41503d7d13 g_main_context_dispatch #19 0x7f41503d8060 <unknown> #20 0x7f41503d8124 g_main_context_iteration #21 0x000001ae81dd base::MessagePumpGlib::Run() #22 0x000001a8553d base::MessageLoop::RunHandler() #23 0x000001aa2720 base::RunLoop::Run() #24 0x00000617bd9c content::RunThisRunLoop() #25 0x00000617bed7 content::RunAllPendingInMessageLoop() #26 0x000001a5ab60 InProcessBrowserTest::RunTestOnMainThreadLoop() #27 0x000001b22654 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #28 0x00000638c641 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #29 0x00000638b741 ChromeBrowserMainParts::PreMainMessageLoopRun() #30 0x00000206b6a1 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #31 0x000002ec6335 content::BrowserMainLoop::PreMainMessageLoopRun() #32 0x00000305d4e7 content::StartupTaskRunner::RunAllTasksNow() #33 0x000002ec4bd4 content::BrowserMainLoop::CreateStartupTasks() #34 0x000003144882 content::BrowserMainRunnerImpl::Initialize() #35 0x000006bea1f6 content::BrowserMain() #36 0x00000615b4ee content::ContentMainRunnerImpl::Run() #37 0x000006159ed0 content::ContentMain() #38 0x000001b22008 content::BrowserTestBase::SetUp() #39 0x000001a5907b InProcessBrowserTest::SetUp() #40 0x000001e60928 testing::Test::Run() #41 0x000001e6169a testing::TestInfo::Run() #42 0x000001e61b23 testing::TestCase::Run() #43 0x000001e68d19 testing::internal::UnitTestImpl::RunAllTests() #44 0x000001e689be testing::UnitTest::Run() #45 0x000001b00db6 base::TestSuite::Run() #46 0x000001a1201b ChromeTestSuiteRunner::RunTestSuite() #47 0x000006178bce content::LaunchTests() #48 0x0000011798f7 main #49 0x7f414c17e7ed __libc_start_main #50 0x0000005cb5e1 <unknown>
,
Jun 10 2016
Note, this is happening after the test is done, some stale message / task happening, maybe a leftover observer?
,
Jun 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef73472f18af646c51619f5d947e0124b185682c commit ef73472f18af646c51619f5d947e0124b185682c Author: piman <piman@chromium.org> Date: Fri Jun 10 23:15:57 2016 Disable flaky test ExtensionStorageMonitorTest.UninstallExtension TBR=rockot@chromium.org BUG=617801 Review-Url: https://codereview.chromium.org/2058913002 Cr-Commit-Position: refs/heads/master@{#399312} [modify] https://crrev.com/ef73472f18af646c51619f5d947e0124b185682c/chrome/browser/extensions/extension_storage_monitor_browsertest.cc
,
Jun 13 2016
,
Jun 13 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef73472f18af646c51619f5d947e0124b185682c commit ef73472f18af646c51619f5d947e0124b185682c Author: piman <piman@chromium.org> Date: Fri Jun 10 23:15:57 2016 Disable flaky test ExtensionStorageMonitorTest.UninstallExtension TBR=rockot@chromium.org BUG=617801 Review-Url: https://codereview.chromium.org/2058913002 Cr-Commit-Position: refs/heads/master@{#399312} [modify] https://crrev.com/ef73472f18af646c51619f5d947e0124b185682c/chrome/browser/extensions/extension_storage_monitor_browsertest.cc
,
Jun 27 2016
,
Jun 27 2016
I suspect that 5faf50626a19355c80218096e55a9c709634f241 from Issue 585080 was the cause of these flakes.
,
Jun 28 2016
The issue linked above includes changes that make the checks for things that affect Chrome's lifetime more strict. Looks to me like the test is not cleaned up properly. SyncExtensionFunction should be destroyed when completing the tests, not after the rest of the browser process is gone (IsShuttingDown() returns true). I suppose something fishy is going on with a posted task. I'm unfamiliar with the extension code and its tests though, so I'm not sure how this should be addressed best.
,
Jun 28 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by battre@chromium.org
, Jun 8 2016Owner: tmdiep@chromium.org
Status: Assigned (was: Untriaged)