New issue
Advanced search Search tips

Issue 617789 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Get mru tracking working in ash for mus

Project Member Reported by sky@chromium.org, Jun 6 2016

Issue description

It's currently aura only.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/948acf4e7e86ad43245929648514d00a805eae5e

commit 948acf4e7e86ad43245929648514d00a805eae5e
Author: sky <sky@chromium.org>
Date: Tue Jun 07 17:04:48 2016

Converts MruWindowTracker to work with common types

BUG= 617789 
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2042913002
Cr-Commit-Position: refs/heads/master@{#398315}

[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/accelerators/accelerator_commands.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/ash.gyp
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/aura/wm_shell_aura.h
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/aura/wm_window_aura.h
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/common/shell_window_ids.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/common/shell_window_ids.h
[add] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/common/wm/focus_rules.cc
[add] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/common/wm/focus_rules.h
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/common/wm_shell.h
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/common/wm_window.h
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/common/wm_window_observer.h
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/focus_cycler.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/mus/bridge/wm_window_mus.h
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/shell.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/wm/ash_focus_rules.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/wm/ash_focus_rules.h
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/wm/maximize_mode/maximize_mode_window_manager.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/wm/mru_window_tracker.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/wm/mru_window_tracker.h
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/wm/mru_window_tracker_unittest.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/wm/window_cycle_controller.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/wm/window_cycle_controller.h
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/wm/window_cycle_controller_unittest.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/wm/window_cycle_list.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/wm/window_cycle_list.h
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/wm/window_util.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/ash/wm/window_util.h
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
[modify] https://crrev.com/948acf4e7e86ad43245929648514d00a805eae5e/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/629ab49d5929b187f6ae19722117c8001e311e2a

commit 629ab49d5929b187f6ae19722117c8001e311e2a
Author: sky <sky@chromium.org>
Date: Tue Jun 07 18:04:11 2016

Moves MruWindowTracker into common

BUG= 617789 
TEST=covered by tests
R=jamescook@chromium.org
TBR=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2045793002
Cr-Commit-Position: refs/heads/master@{#398337}

[modify] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/ash/accelerators/accelerator_commands.cc
[modify] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/ash/ash.gyp
[modify] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/ash/aura/wm_shell_aura.cc
[rename] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/ash/common/wm/mru_window_tracker.cc
[rename] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/ash/common/wm/mru_window_tracker.h
[modify] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/ash/focus_cycler.cc
[modify] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/ash/shell.cc
[modify] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/ash/wm/ash_focus_rules.cc
[modify] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/ash/wm/maximize_mode/maximize_mode_window_manager.cc
[modify] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
[modify] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/ash/wm/mru_window_tracker_unittest.cc
[modify] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/ash/wm/window_cycle_controller.cc
[modify] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/ash/wm/window_cycle_list.cc
[modify] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
[modify] https://crrev.com/629ab49d5929b187f6ae19722117c8001e311e2a/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e62002a691d8bbcd96b34284e39c81b2784832e6

commit e62002a691d8bbcd96b34284e39c81b2784832e6
Author: sky <sky@chromium.org>
Date: Tue Jun 07 21:27:40 2016

Copies MruWindowTrackerTest over for mash

This is an exact copy of that for aura (with includes sanitized for
check deps). I'm copying this first so it's easy to see what changes.

I'm TBRing as this is just a file copy, and the file isn't compiled
yet.

BUG= 617789 
TEST=test only change
R=jamescook@chromium.org
TBR=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2042423002
Cr-Commit-Position: refs/heads/master@{#398373}

[add] https://crrev.com/e62002a691d8bbcd96b34284e39c81b2784832e6/ash/mus/wm/mru_window_tracker_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50a0112bebf53aabec7f274b8932302a6cbc4fe4

commit 50a0112bebf53aabec7f274b8932302a6cbc4fe4
Author: sky <sky@chromium.org>
Date: Wed Jun 08 16:48:19 2016

Moves MruWindowTracker to WmShell

We could also go with a ShellCommon and keep WmShell pure virtual, but
as this code is temporary I'm ok with making WmShell not pure virtual.

BUG= 617789 
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2041423002
Cr-Commit-Position: refs/heads/master@{#398599}

[modify] https://crrev.com/50a0112bebf53aabec7f274b8932302a6cbc4fe4/ash/ash.gyp
[modify] https://crrev.com/50a0112bebf53aabec7f274b8932302a6cbc4fe4/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/50a0112bebf53aabec7f274b8932302a6cbc4fe4/ash/aura/wm_shell_aura.h
[modify] https://crrev.com/50a0112bebf53aabec7f274b8932302a6cbc4fe4/ash/common/wm/window_positioner.cc
[modify] https://crrev.com/50a0112bebf53aabec7f274b8932302a6cbc4fe4/ash/common/wm_shell.h
[add] https://crrev.com/50a0112bebf53aabec7f274b8932302a6cbc4fe4/ash/common/wm_shell_common.cc
[add] https://crrev.com/50a0112bebf53aabec7f274b8932302a6cbc4fe4/ash/common/wm_shell_common.h
[modify] https://crrev.com/50a0112bebf53aabec7f274b8932302a6cbc4fe4/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/50a0112bebf53aabec7f274b8932302a6cbc4fe4/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/50a0112bebf53aabec7f274b8932302a6cbc4fe4/ash/shell.cc
[modify] https://crrev.com/50a0112bebf53aabec7f274b8932302a6cbc4fe4/ash/shell.h
[modify] https://crrev.com/50a0112bebf53aabec7f274b8932302a6cbc4fe4/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/50a0112bebf53aabec7f274b8932302a6cbc4fe4/ash/wm/overview/window_selector_controller.cc

Comment 5 by sky@chromium.org, Jun 8 2016

Status: Fixed (was: Started)
Labels: VerifyIn-53
Labels: VerifyIn-54

Comment 9 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 10 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 11 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 12 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 13 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 14 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 16 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment