New issue
Advanced search Search tips

Issue 617775 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 617187
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

test.py is broken

Project Member Reported by no...@chromium.org, Jun 6 2016

Issue description

./test.py test infra/libs/git2/test/

fails with

Running infra/libs/git2/test/...
Traceback (most recent call last):
  File "ENV/bin/expect_tests", line 29, in <module>
    expect_tests.main()
  File "/private/tmp/nodir/checkout/infra/ENV/lib/python2.7/site-packages/expect_tests/main.py", line 170, in main
    coveragerc=opts.coveragerc)
  File "/private/tmp/nodir/checkout/infra/ENV/lib/python2.7/site-packages/expect_tests/cover.py", line 98, in __init__
    self.cov = coverage.coverage(**self.opts)
  File "/private/tmp/nodir/checkout/infra/ENV/lib/python2.7/site-packages/coverage/control.py", line 140, in __init__
    "Couldn't read '%s' as a config file" % config_file
coverage.misc.CoverageException: Couldn't read '/private/tmp/nodir/checkout/infra/infra/libs/git2/test/.coveragerc' as a config file
Tests failed in modules:
  infra/libs/git2/test/

it should not.

./test.py test --no-coverage infra/libs/git2/test/ fails too

caused by https://codereview.chromium.org/1917383002/
please fix
 

Comment 1 by no...@chromium.org, Jun 6 2016

it can be reproduced on a fresh `fetch infra` checkout
Mergedinto: 617187
Status: Duplicate (was: Assigned)
I'm aware, and it was a design decision at the time. Missing coverage was more important than the ability to select subsets of tests. That feature was also broken in other subtle ways even before my change. Merging with an existing issue with a proposed temporary resolution.
Just curious: broken in which subtle ways?

Sign in to add a comment