Issue metadata
Sign in to add a comment
|
OSX MD: When backspacing in Incognito, text is black when there is no active suggestion. |
||||||||||||||||||||||
Issue descriptionChrome 53.0.2760.0 OSX 10.11.5 What steps will reproduce the problem? (1) Open an Incognito window (2) Start typing a search, then type backspace. What is the expected output? The text should stay white. What do you see instead? When you type backspace, the omnibox no longer has a suggestion, and the text turns black. See attachment. This is not a regression, since the omnibox is only newly dark in Incognito for Material Design.
,
Jun 7 2016
,
Jun 7 2016
Tested the issue on Mac 10.11.5, Windows 7, Ubuntu 14.04 using 53.0.2760.0 as per steps in comment #0. Mac(retina, non-retina display) and Linux behavior: While typing the text in omnibox, text appeared black and by using backspace the text remained black and suggestions are still shown. Windows behavior: While typing the text in omnibox, text appeared white and by using backspace the text remained white and suggestions are still shown. Please find attached screencast. lgarron@: Could you please confirm the expected behavior.
,
Jun 7 2016
I don't know what the intended behaviour is, but my expected behaviour is that the (non-highlighted) text is always white.
,
Jun 8 2016
With bisect: You are probably looking for a change made after 396538 (known good), but no later than 396550 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/b31bfdd9bed2e5e98e5a7c4423cf853fdc8e376f..2eb0e37f4286746ca0ff1d63cd501920b0f915c9 Suspecting: [Material][Mac] Removed "single color while editing text" behavior BUG= 615118 Review-Url: https://codereview.chromium.org/2017103002
,
Jun 8 2016
,
Jun 9 2016
,
Jun 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85502edfd5f031d56e28366f59b395b53d397cdb commit 85502edfd5f031d56e28366f59b395b53d397cdb Author: spqchan <spqchan@chromium.org> Date: Mon Jun 13 22:50:01 2016 [Material][Mac] Fix text color in incognito omnibox BUG= 617766 Review-Url: https://codereview.chromium.org/2056093002 Cr-Commit-Position: refs/heads/master@{#399585} [modify] https://crrev.com/85502edfd5f031d56e28366f59b395b53d397cdb/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
,
Jun 13 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85502edfd5f031d56e28366f59b395b53d397cdb commit 85502edfd5f031d56e28366f59b395b53d397cdb Author: spqchan <spqchan@chromium.org> Date: Mon Jun 13 22:50:01 2016 [Material][Mac] Fix text color in incognito omnibox BUG= 617766 Review-Url: https://codereview.chromium.org/2056093002 Cr-Commit-Position: refs/heads/master@{#399585} [modify] https://crrev.com/85502edfd5f031d56e28366f59b395b53d397cdb/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by shrike@chromium.org
, Jun 7 2016Labels: Needs-Bisect
Owner: ----
Status: Untriaged (was: Assigned)