Wrong ink drop behavior when dragging with right mouse button |
|||
Issue descriptionChrome Version: 53.0.2761.0 (Developer Build) What steps will reproduce the problem? 1. Move the mouse pointer over the reload button; 2. Press and hold down the right mouse button; 3. Move the mouse pointer a few pixel so that it is considered a drag, but don't go out of the reload button; 4. Continue to move the mouse out of the reload button; 5. Move the mouse pointer back over the reload button; 6. Release the right mouse button; 7. Click the reload button (with the left mouse button). What is the expected result? Step (1) should highlight the button. Step (2) should not show the pending ink drop ripple. Step (3) should not show the pending ink drop ripple. Step (4) should not show any ripple effect. Step (5) should not show the pending ink drop ripple. Step (6) should not show any ripple effect. Step (7) should trigger ink drop ripple and reload the page. What happens instead of that? Step (1) highlights the button (GOOD). Step (2) does not show the pending ink drop ripple (GOOD). Step (3) shows the pending ink drop ripple (BAD). Step (4) hides the pending ink drop ripple (BAD). Step (5) shows the pending ink drop ripple (BAD). Step (6) keeps the pending ink drop ripple (BAD). Step (7) crashes the browser because of the already pending ink drop ripple (BAD). I think this is caused by r397555. When dragging mouse around we should probably check for ShouldEnterPushedState() before showing pending ripple effects.
,
Jun 6 2016
I cannot reproduce step 7.
,
Jun 6 2016
Are you running a release build? It's a DCHECK that only crashes on debug builds.
,
Jun 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa592d3f01a5e00e8de1851b93ebea6593f4c7c3 commit fa592d3f01a5e00e8de1851b93ebea6593f4c7c3 Author: kylixrd <kylixrd@chromium.org> Date: Tue Jun 07 17:05:14 2016 Ink Drop is visibly shown when right-clicking and dragging on the toolbar custom button. According to the report, the button should be non-reactive and show no visible signs of being clicked on. BUG= 617764 Review-Url: https://codereview.chromium.org/2042883003 Cr-Commit-Position: refs/heads/master@{#398316} [modify] https://crrev.com/fa592d3f01a5e00e8de1851b93ebea6593f4c7c3/ui/views/controls/button/custom_button.cc
,
Jun 8 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by kylixrd@chromium.org
, Jun 6 2016