New issue
Advanced search Search tips

Issue 617758 link

Starred by 1 user
Status: Verified
Owner:
gurcheta...@chromium.org
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Clean up dEQP master control file deployment

Project Member Reported by ihf@chromium.org, Jun 6 2016 
The media-gfx/deqp package download a tarball containing the deqp sources, right now at
gs://chromeos-localmirror/distfiles/deqp-8b38db9f98e9b1ee68a2fe0e4e19f756ea1de8c2.tar.gz

(use gsutil cp gs://... . to copy)

Directory android/cts/master contains 4 files
egl-master.txt  gles2-master.txt  gles31-master.txt  gles3-master.txt

which we manually copy and commit to 
src/third_party/autotest/files/client/site_tests/graphics_dEQP/master

Instead of manually copying, install these 4 files on the DUT. Then adjust the control*master files in graphics_dEQP to use the new location on the DUT. Finally delete graphics_dEQP/master from git.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/51b8999f837f6e653194fb025add4b4f53b08ca3

commit 51b8999f837f6e653194fb025add4b4f53b08ca3
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Mon Jun 06 21:03:22 2016

graphics_dEQP: rev master/* files to 6.0_r6.

This should be done automatically in the future, see bug below.

BUG= chromium:617758 
TEST=None.

Change-Id: I749878ad980ca684c49af8527068606e49f1ff19
Reviewed-on: https://chromium-review.googlesource.com/350131
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/51b8999f837f6e653194fb025add4b4f53b08ca3/client/site_tests/graphics_dEQP/master/gles31-master.txt
[modify] https://crrev.com/51b8999f837f6e653194fb025add4b4f53b08ca3/client/site_tests/graphics_dEQP/master/gles2-master.txt
[modify] https://crrev.com/51b8999f837f6e653194fb025add4b4f53b08ca3/client/site_tests/graphics_dEQP/master/gles3-master.txt
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bfc2fc92fefca693ad60175bdb02c1dc2907516f

commit bfc2fc92fefca693ad60175bdb02c1dc2907516f
Author: Gurchetan Singh <gurchetansingh@chromium.org>
Date: Tue Jun 07 02:58:44 2016

graphics_dEQP: Change search directory for master files.

Removed dEQP master control files from CrOS tree.  They will be
installed directly on the DUT now.

BUG= chromium:617758 
TEST=In the /usr/local/autotest/ directory, ran:

./bin/autotest_client tests/graphics_dEQP/{control_file}

Verified the commands work.

CQ-DEPEND=CL:350141

Change-Id: Ie245c692c44dfb2ddb6600920ba89326b2461839
Reviewed-on: https://chromium-review.googlesource.com/350166
Commit-Ready: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[delete] https://crrev.com/47b68eeb258a34a9c3f7138dfe4f737f81431b1d/client/site_tests/graphics_dEQP/master/egl-master.txt
[modify] https://crrev.com/bfc2fc92fefca693ad60175bdb02c1dc2907516f/client/site_tests/graphics_dEQP/control.gles31-master
[delete] https://crrev.com/47b68eeb258a34a9c3f7138dfe4f737f81431b1d/client/site_tests/graphics_dEQP/master/gles3-master.txt
[delete] https://crrev.com/47b68eeb258a34a9c3f7138dfe4f737f81431b1d/client/site_tests/graphics_dEQP/master/gles31-master.txt
[modify] https://crrev.com/bfc2fc92fefca693ad60175bdb02c1dc2907516f/client/site_tests/graphics_dEQP/control.egl-master
[modify] https://crrev.com/bfc2fc92fefca693ad60175bdb02c1dc2907516f/client/site_tests/graphics_dEQP/control.gles3-master
[modify] https://crrev.com/bfc2fc92fefca693ad60175bdb02c1dc2907516f/client/site_tests/graphics_dEQP/control.gles2-master
[delete] https://crrev.com/47b68eeb258a34a9c3f7138dfe4f737f81431b1d/client/site_tests/graphics_dEQP/master/gles2-master.txt
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/658997fd19a6158ddae48a6307fe8d95cf06279e

commit 658997fd19a6158ddae48a6307fe8d95cf06279e
Author: Gurchetan Singh <gurchetansingh@chromium.org>
Date: Tue Jun 07 01:25:28 2016

media-gfx/deqp: Install master control files onto DUT

It is desirable to install certain dEQP support files directly on the
DUT.  Also removed patches that were not being used.

BUG= chromium:617758 
TEST=Ran

emerge-cyan-cheets deqp
cros deploy --board cyan-cheets $IP1 deqp

Verified the files were present.

Change-Id: If25b0396b1daf12ec33d51ec13f4ed40abe2aa1e
Reviewed-on: https://chromium-review.googlesource.com/350141
Commit-Ready: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[delete] https://crrev.com/758a0ec2ebf04c9f7b6e11003c0e4d71ed7d83ef/media-gfx/deqp/files/0005-Use-non-zero-fb-id-for-not-bound-fbo-tests.patch
[rename] https://crrev.com/658997fd19a6158ddae48a6307fe8d95cf06279e/media-gfx/deqp/deqp-2016.06.02-r2.ebuild
[delete] https://crrev.com/758a0ec2ebf04c9f7b6e11003c0e4d71ed7d83ef/media-gfx/deqp/files/0006-Query-initial-bound-fb-from-RenderContext-in-FrameBu.patch
[delete] https://crrev.com/758a0ec2ebf04c9f7b6e11003c0e4d71ed7d83ef/media-gfx/deqp/files/0004-Surfaceless-Dont-fail-checks-in-sglrGLContext-when-F.patch

Comment 4 by gurcheta...@chromium.org, Apr 25 2017

Status: Verified (was: Assigned)
►

Sign in to add a comment