New issue
Advanced search Search tips

Issue 617724 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ContentSettingsTypeToGroupName CRASH triggered

Project Member Reported by tommycli@chromium.org, Jun 6 2016

Issue description

Crash introduced by https://chromium.googlesource.com/chromium/src/+/155a202f6076fad0cd5d86bfefb5c317d8a3708e

Repro steps:

On tip of tree:

1. Modify the crash message on site_settings_helper.cc:70 to:
  NOTREACHED() << type << " is not a recognized ContentSettingType enum value.";

   This is optional, it's just to figure out which Enum value is causing the crash.

2. Navigate to chrome://md-settings/siteSettings/cookies

3. Navigate to a different URL such as google.com

Crash:

[20184:20184:0606/122257:FATAL:site_settings_helper.cc(70)] Check failed: false. 20 is not a recognized ContentSettingType enum value.
#0 0x7f63c7b513de base::debug::StackTrace::StackTrace()
#1 0x7f63c7b71c9b logging::LogMessage::~LogMessage()
#2 0x7f63c912db75 site_settings::ContentSettingsTypeToGroupName()
#3 0x7f63c912b5c3 settings::SiteSettingsHandler::OnContentSettingChanged()
#4 0x7f63c893a5c0 HostContentSettingsMap::OnContentSettingChanged()
#5 0x7f63c8929060 content_settings::ObservableProvider::NotifyObservers()
#6 0x7f63c892f457 content_settings::ContentSettingsPref::SetWebsiteSetting()
#7 0x7f63c8931076 content_settings::PrefProvider::SetWebsiteSetting()
#8 0x7f63c893910d HostContentSettingsMap::SetWebsiteSettingCustomScope()
#9 0x7f63c89392b3 HostContentSettingsMap::SetWebsiteSettingDefaultScope()
#10 0x7f63c84dd855 SiteEngagementScore::Commit()
#11 0x7f63c84df310 SiteEngagementService::HandleNavigation()
#12 0x7f63c84dbdb6 SiteEngagementService::Helper::DidFinishNavigation()
#13 0x7f63c58a53f7 content::WebContentsImpl::DidFinishNavigation()
#14 0x7f63c55cb7fc content::NavigationHandleImpl::~NavigationHandleImpl()
#15 0x7f63c55cbba9 content::NavigationHandleImpl::~NavigationHandleImpl()
#16 0x7f63c55de7e7 content::RenderFrameHostImpl::SetNavigationHandle()
#17 0x7f63c55d0e33 content::NavigatorImpl::DidNavigate()
#18 0x7f63c55d7365 content::RenderFrameHostImpl::OnDidCommitProvisionalLoad()
#19 0x7f63c55d5422 content::RenderFrameHostImpl::OnMessageReceived()
#20 0x7f63c579690a content::RenderProcessHostImpl::OnMessageReceived()
#21 0x7f63c495b6f5 IPC::ChannelProxy::Context::OnDispatchMessage()
#22 0x7f63c7b52619 base::debug::TaskAnnotator::RunTask()
#23 0x7f63c7b7c3c5 base::MessageLoop::RunTask()
#24 0x7f63c7b7c6f8 base::MessageLoop::DeferOrRunPendingTask()
#25 0x7f63c7b7ca8b base::MessageLoop::DoWork()
#26 0x7f63c7b7e919 base::MessagePumpGlib::Run()
#27 0x7f63c7b7bef1 base::MessageLoop::RunHandler()
#28 0x7f63c7baab60 base::RunLoop::Run()
#29 0x7f63c83f219a ChromeBrowserMainParts::MainMessageLoopRun()
#30 0x7f63c54f24e9 content::BrowserMainLoop::RunMainMessageLoopParts()
#31 0x7f63c54f58f8 content::BrowserMainRunnerImpl::Run()
#32 0x7f63c54edd2c content::BrowserMain()
#33 0x7f63c5eae36b content::RunNamedProcessTypeMain()
#34 0x7f63c5eaede3 content::ContentMainRunnerImpl::Run()
#35 0x7f63c5ead6b0 content::ContentMain()
#36 0x7f63c83aa3db ChromeMain
#37 0x7f63bec0bf45 __libc_start_main
#38 0x7f63c83aa2ad <unknown>

 
FYI, once this patch lands, my repro steps will no longer work - though the bug will still exist.

https://codereview.chromium.org/2041993002/
Status: Fixed (was: Untriaged)

Sign in to add a comment