New issue
Advanced search Search tips

Issue 617723 link

Starred by 1 user
Status: WontFix
Owner:
sebmarchand@chromium.org
Closed: Aug 2017
Cc:
brucedaw...@chromium.org
scottmg@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Some static libraries are really close from the MSVS 2 GB limitation

Project Member Reported by sebmarchand@chromium.org, Jun 6 2016 
Here's the list of the static libraries for an Official (all optimization enabled) 64 build of chrome and chromium_builder_perf:

https://docs.google.com/spreadsheets/d/1UBZnBvejpQk0qATtCeYHd_mPbZ4F3oUpP0J_vTw31ro/edit?usp=sharing

Some of them are getting really close from the 2GB MSVS limitation and should use the msvs_shard GYP flag (some of them already use it so we should just increase the number of shards).

This shouldn't be an issue with the GN builds.

Comment 1 by brucedaw...@chromium.org, Jun 14 2016 

> This shouldn't be an issue with the GN builds.

Source sets were supposed to avoid this problem in gn builds, but it turns out that source sets can cause pretty serious link-time performance problems, because every .obj file (and all of the symbols that it references) gets considered, whereas when linking with .lib files most .obj files can (in some builds) be ignored.

So this issue is popping up in gn builds as well, with the details changing frequently at this point.

Comment 2 by sebmarchand@chromium.org, Aug 2 2016

Labels: -Pri-1 Pri-3
Not sure if it's still an issue with GN, lowering the priority.

Comment 3 by brucedaw...@chromium.org, Aug 2 2016 

BTW, split_static_library is the GN technique for splitting up a static library. It is conceptually identical to msvs_shard. split_static_library was used as some source sets were converted to static_library targets.

Comment 4 by sebmarchand@chromium.org, Aug 10 2017

Status: WontFix (was: Untriaged)
►

Sign in to add a comment