MD Settings: Customize font settings padding looks incorrect |
||||||
Issue descriptionAre the font settings and language settings properly aligned? It looks to me like there is too much left padding on the controls: * Font dropdowns and samples * Language list and checkboxes Should the controls be aligned with the subpage header, as in Manage Passwords? Or are the card previews out of date in that regard?
,
Jun 7 2016
Thanks. The cumulative padding is definitely more than that in these places and maybe others. This is a visual polish/consistency issue that should be addressed before launch but probably not a dev blocker.
,
Jun 9 2016
,
Dec 10 2016
This is no longer an issue with the new Languages section. It sounds like the padding in Customize fonts should be 56px total instead of it's current 76px total.
,
Mar 15 2017
,
Mar 15 2017
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/566e65ab665604104285fc725c65753423b1cb92 commit 566e65ab665604104285fc725c65753423b1cb92 Author: dschuyler <dschuyler@chromium.org> Date: Thu Mar 16 00:24:10 2017 [MD settings] move font controls in MD settings This CL outdents some UI controlls to place them in the correct positions (they were indented too far). Also corrects some div tags. BUG= 617712 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2751063003 Cr-Commit-Position: refs/heads/master@{#457280} [modify] https://crrev.com/566e65ab665604104285fc725c65753423b1cb92/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html
,
Mar 16 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bettes@chromium.org
, Jun 7 2016Status: Assigned (was: Untriaged)
62.4 KB
62.4 KB View Download