Error 'AC power is not plugged' for DUT in lars & sentry & chell |
||||||||||
Issue descriptionMost of the DUT for board lars, sentry, and chell lost their 'AC power' this morning. After debugging, we suspect there's a bug on ToT, since all the 3 boards use kernel 3.18 (https://crosland.corp.google.com/log/8414.0.0..8415.0.0), in which the updates are related to cros_EC. And software calls EC to get the information of AC power. So if EC fails, software won't detect 'AC power'. Assign to build sheriff to find first, whether it's a ToT problem, and secondly, whether to kick them off from the release waterfall.
,
Jun 6 2016
,
Jun 6 2016
The issue is nobody is loading cros_usbpd-charger when in module mode. It should be loaded from cros_ec stack.
,
Jun 6 2016
,
Jun 6 2016
Revert has been chumped.
,
Jun 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/c495817bac41cb444f60ad0c9251ee104a379246 commit c495817bac41cb444f60ad0c9251ee104a379246 Author: Stephen Barber <smbarber@google.com> Date: Mon Jun 06 18:54:09 2016 Revert "CHROMIUM: config: set cros_ec drivers as loadable modules." This reverts commit 860bb18c8ec3e7290704d5e5e7191aa86a0f705e. BUG= 617704 TEST=usb pd charger shows up Change-Id: Ibd816ad703350f959143e88573547e6143647c9f Reviewed-on: https://chromium-review.googlesource.com/350050 Reviewed-by: Stephen Barber <smbarber@google.com> Commit-Queue: Stephen Barber <smbarber@google.com> Tested-by: Stephen Barber <smbarber@google.com> [modify] https://crrev.com/c495817bac41cb444f60ad0c9251ee104a379246/chromeos/config/x86_64/common.config
,
Jun 7 2016
This is more complicated than I thought. I fix the loading issue of cros_usbpd_charger, but there is still an issue with cros_ec_pd_update as a module: When I load it, I get an error: [ 0.561891] cros_ec_lpcs cros_ec_lpcs.0: Chrome EC device registered ... [ 8.840249] cros_ec_pd_update GOOG0003:00: No ec_dev device [ 8.840252] cros_ec_pd_update GOOG0003:00: Can't get num_ports [ 8.840270] cros_ec_pd_update: probe of GOOG0003:00 failed with error -22 It is because cros_ec_pd_update has a hidden dependency: the driver set pd_ec if and only if the pd_udpate sysfs attribute visible function indicates there is a pd, AND this function has been called before the probe routine.
,
Jun 7 2016
Compilation error, fix under way.
,
Jun 21 2016
Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable? If a fix is in active development, please set the status to Started. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 21 2016
This bug is no longer in the tree, so maybe we should just close it?
,
Jun 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/986f15bc71fbe2d3dc0d0e6af5bf1d8f36ae47f7 commit 986f15bc71fbe2d3dc0d0e6af5bf1d8f36ae47f7 Author: Gwendal Grignou <gwendal@chromium.org> Date: Wed Jun 08 17:57:39 2016 CHROMIUM: cros_ec: Fix module related errors - Use IF_EXIST and EXPORT_SYMBOL for sysfs entry point of cros_ec_pd_update and cros_usbpd-charger. - Fix cros_usbpd-charger driver name to match the compiled .ko. BUG= chromium:617704 TEST=On chell, check the modules load and sysfs parameters are present. Change-Id: Ic12d9f84b5df430d5a66d09f2fad636853e56266 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/350890 Reviewed-by: Guenter Roeck <groeck@google.com> [modify] https://crrev.com/986f15bc71fbe2d3dc0d0e6af5bf1d8f36ae47f7/drivers/power/cros_usbpd-charger.c [modify] https://crrev.com/986f15bc71fbe2d3dc0d0e6af5bf1d8f36ae47f7/drivers/mfd/cros_ec_dev.c [modify] https://crrev.com/986f15bc71fbe2d3dc0d0e6af5bf1d8f36ae47f7/drivers/mfd/cros_ec_pd_update.c [modify] https://crrev.com/986f15bc71fbe2d3dc0d0e6af5bf1d8f36ae47f7/drivers/power/cros_ec-charger.c
,
Jun 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/60d3926c861f690f5aa71e0603e7180bfa89a6e4 commit 60d3926c861f690f5aa71e0603e7180bfa89a6e4 Author: Gwendal Grignou <gwendal@chromium.org> Date: Wed Jun 08 18:06:47 2016 CHROMIUM: cros_ec: Clean error path at probe time Take adavantage of devm_ function to avoid a goto. Use dev_err instead of WARN. BUG= chromium:617704 TEST=load on chell. Change-Id: I05c6f43fb1c5c95e7841342ab6b35390dd3f7e97 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/350891 Reviewed-by: Guenter Roeck <groeck@google.com> [modify] https://crrev.com/60d3926c861f690f5aa71e0603e7180bfa89a6e4/drivers/power/cros_usbpd-charger.c [modify] https://crrev.com/60d3926c861f690f5aa71e0603e7180bfa89a6e4/drivers/mfd/cros_ec_pd_update.c
,
Jun 21 2016
,
Jun 21 2016
,
Jun 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/0c139927b5a0f151c5e4c519acdb49987efaf538 commit 0c139927b5a0f151c5e4c519acdb49987efaf538 Author: Gwendal Grignou <gwendal@chromium.org> Date: Tue Jun 07 17:48:40 2016 Revert "Revert "CHROMIUM: config: set cros_ec drivers as loadable modules."" This reverts commit c495817bac41 ("Revert "CHROMIUM: config: set cros_ec drivers as loadable modules."") The move to go to modules for cros_ec stack was not tested on chell, part of the stack was not loaded properly. BUG= chromium:617704 TEST=On chell, check that modules are loaded properly, power supplies are listed. On cayn, check there are no behavior changes. Change-Id: Ie229f15aa227de5598a0fbf2208757b9670dd024 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/350893 Reviewed-by: Guenter Roeck <groeck@chromium.org> [modify] https://crrev.com/0c139927b5a0f151c5e4c519acdb49987efaf538/chromeos/config/x86_64/common.config
,
Jun 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/59b2218d4d18d3d659ce373db58043a4024bafe0 commit 59b2218d4d18d3d659ce373db58043a4024bafe0 Author: Gwendal Grignou <gwendal@chromium.org> Date: Wed Jun 08 18:08:38 2016 CHROMIUM: cros_ec_pd_update: Defer probe until EC is present When cros_ec_pd_update receives an ACPI event telling a charger is available, the driver assumes the EC has already been initialized. We know the ACPI is coming from the EC, so we should wait for the cros_ec stack to be ready before failing the probe routine. BUG= chromium:617704 TEST=When the cros ec stack is in module, check we are not failing probe: Instead of: [ 0.539350] cros_ec_lpcs cros_ec_lpcs.0: Chrome EC device registered [ 2.729715] cros_ec_pd_update GOOG0003:00: No ec_dev device [ 2.737130] cros_ec_pd_update GOOG0003:00: Can't get num_ports [ 2.744195] cros_ec_pd_update: probe of GOOG0003:00 failed with error -22 We get: [ 9.231787] acpi GOOG0003:00: Driver cros_ec_pd_update requests probe deferral [ 9.266928] acpi GOOG0003:00: Driver cros_ec_pd_update requests probe deferral [ 9.270746] acpi GOOG0003:00: Driver cros_ec_pd_update requests probe deferral [ 9.302765] acpi GOOG0003:00: Driver cros_ec_pd_update requests probe deferral [ 9.428008] cros_ec_lpcs cros_ec_lpcs.0: Chrome EC device registered [ 9.437625] acpi GOOG0003:00: Driver cros_ec_pd_update requests probe deferral [ 9.502773] acpi GOOG0003:00: Driver cros_ec_pd_update requests probe deferral Change-Id: I8038bd39895c46e9c42197ef6295ec62b5645f83 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/350892 Reviewed-by: Guenter Roeck <groeck@chromium.org> [modify] https://crrev.com/59b2218d4d18d3d659ce373db58043a4024bafe0/drivers/mfd/cros_ec_pd_update.c
,
Jun 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/92fea632a8ea182ca71a2d7b350130cf12ac8e50 commit 92fea632a8ea182ca71a2d7b350130cf12ac8e50 Author: Gwendal Grignou <gwendal@chromium.org> Date: Wed Jun 22 15:50:58 2016 CHROMIUM: cros_ec: Set driver names properly. Use cros-ec-<function> driver name convention, regardless of the driver file name. Use MODULE_ALIAS when only one type of platform device is exposed by the driver. BUG= chromium:617704 TEST=check on chell cros-ec-usbpd-charger as a module is loaded properly. Change-Id: I2b87be5395d6ddcaa76265879feb2097889f0a01 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/354777 Reviewed-by: Guenter Roeck <groeck@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> [modify] https://crrev.com/92fea632a8ea182ca71a2d7b350130cf12ac8e50/drivers/power/cros_usbpd-charger.c [modify] https://crrev.com/92fea632a8ea182ca71a2d7b350130cf12ac8e50/drivers/mfd/cros_ec_dev.c [modify] https://crrev.com/92fea632a8ea182ca71a2d7b350130cf12ac8e50/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_ring.c [modify] https://crrev.com/92fea632a8ea182ca71a2d7b350130cf12ac8e50/drivers/iio/common/cros_ec_sensors/cros_ec_activity.c [modify] https://crrev.com/92fea632a8ea182ca71a2d7b350130cf12ac8e50/drivers/power/cros_ec-charger.c
,
Jun 27 2016
Still need to port these changes to 4.4.
,
Jun 27 2016
Closing... please feel free to reopen if its not fixed.
,
Jun 27 2016
,
Jul 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/771c807dc4d4fcaee19375ad9d76ce6e48063b9a commit 771c807dc4d4fcaee19375ad9d76ce6e48063b9a Author: Gwendal Grignou <gwendal@chromium.org> Date: Wed Jun 08 17:57:39 2016 CHROMIUM: cros_ec: Fix module related errors - Use IF_EXIST and EXPORT_SYMBOL for sysfs entry point of cros_ec_pd_update and cros_usbpd-charger. - Fix cros_usbpd-charger driver name to match the compiled .ko. BUG= chromium:617704 TEST=On chell, check the modules load and sysfs parameters are present. Change-Id: Ic12d9f84b5df430d5a66d09f2fad636853e56266 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/350890 Reviewed-by: Guenter Roeck <groeck@google.com> (cherry picked from commit 986f15bc71fbe2d3dc0d0e6af5bf1d8f36ae47f7) Reviewed-on: https://chromium-review.googlesource.com/358152 Reviewed-by: Guenter Roeck <groeck@chromium.org> [modify] https://crrev.com/771c807dc4d4fcaee19375ad9d76ce6e48063b9a/drivers/power/cros_usbpd-charger.c [modify] https://crrev.com/771c807dc4d4fcaee19375ad9d76ce6e48063b9a/drivers/platform/chrome/cros_ec_dev.c [modify] https://crrev.com/771c807dc4d4fcaee19375ad9d76ce6e48063b9a/drivers/mfd/cros_ec_pd_update.c [modify] https://crrev.com/771c807dc4d4fcaee19375ad9d76ce6e48063b9a/drivers/power/cros_ec-charger.c
,
Jul 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/aad6c9041478f3748a60e720d88bf41d81cc568f commit aad6c9041478f3748a60e720d88bf41d81cc568f Author: Gwendal Grignou <gwendal@chromium.org> Date: Wed Jun 22 15:50:58 2016 CHROMIUM: cros_ec: Set driver names properly. Use cros-ec-<function> driver name convention, regardless of the driver file name. Use MODULE_ALIAS when only one type of platform device is exposed by the driver. BUG= chromium:617704 TEST=check on chell cros-ec-usbpd-charger as a module is loaded properly. Change-Id: I2b87be5395d6ddcaa76265879feb2097889f0a01 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/354777 Reviewed-by: Guenter Roeck <groeck@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> (cherry picked from commit 92fea632a8ea182ca71a2d7b350130cf12ac8e50) Reviewed-on: https://chromium-review.googlesource.com/358156 Reviewed-by: Guenter Roeck <groeck@google.com> [modify] https://crrev.com/aad6c9041478f3748a60e720d88bf41d81cc568f/drivers/platform/chrome/cros_ec_dev.c [modify] https://crrev.com/aad6c9041478f3748a60e720d88bf41d81cc568f/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_ring.c [modify] https://crrev.com/aad6c9041478f3748a60e720d88bf41d81cc568f/drivers/iio/common/cros_ec_sensors/cros_ec_activity.c
,
Jul 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/0eb7b29e404cc5449d2ae4bf37b6a0dc9db52859 commit 0eb7b29e404cc5449d2ae4bf37b6a0dc9db52859 Author: Gwendal Grignou <gwendal@chromium.org> Date: Wed Jun 08 18:06:47 2016 CHROMIUM: cros_ec: Clean error path at probe time Take adavantage of devm_ function to avoid a goto. Use dev_err instead of WARN. BUG= chromium:617704 TEST=load on chell. Change-Id: I05c6f43fb1c5c95e7841342ab6b35390dd3f7e97 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/350891 Reviewed-by: Guenter Roeck <groeck@google.com> (cherry picked from commit 60d3926c861f690f5aa71e0603e7180bfa89a6e4) Reviewed-on: https://chromium-review.googlesource.com/358153 Reviewed-by: Guenter Roeck <groeck@chromium.org> [modify] https://crrev.com/0eb7b29e404cc5449d2ae4bf37b6a0dc9db52859/drivers/power/cros_usbpd-charger.c [modify] https://crrev.com/0eb7b29e404cc5449d2ae4bf37b6a0dc9db52859/drivers/mfd/cros_ec_pd_update.c |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by xixuan@chromium.org
, Jun 6 2016