Improve NetLog logging in net::BidirectionalStream |
||
Issue descriptionWhen writes are coalesced (using BidirectionalStream::SendvData), it is hard to tell from the NetLog dump. We need to improve the logging in net::BidirectionalStream. Additionally, the NetLog dump should allow us to tell when stream is ready for reading/writing, and when stream is failed.
,
Jun 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2704f5d77380f5a941a3d0f31c9bcbc0ea68fffb commit 2704f5d77380f5a941a3d0f31c9bcbc0ea68fffb Author: xunjieli <xunjieli@chromium.org> Date: Fri Jun 10 16:02:23 2016 Improve NetLog logging in net::BidirectionalStream This CL adds three additional events to net::BidirectionalStream to log when buffers are coalesced, when stream is ready, and when stream is failed. BUG= 617698 Review-Url: https://codereview.chromium.org/2044583002 Cr-Commit-Position: refs/heads/master@{#399198} [modify] https://crrev.com/2704f5d77380f5a941a3d0f31c9bcbc0ea68fffb/net/http/bidirectional_stream.cc [modify] https://crrev.com/2704f5d77380f5a941a3d0f31c9bcbc0ea68fffb/net/http/bidirectional_stream_unittest.cc [modify] https://crrev.com/2704f5d77380f5a941a3d0f31c9bcbc0ea68fffb/net/log/net_log_event_type_list.h
,
Jun 10 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2704f5d77380f5a941a3d0f31c9bcbc0ea68fffb commit 2704f5d77380f5a941a3d0f31c9bcbc0ea68fffb Author: xunjieli <xunjieli@chromium.org> Date: Fri Jun 10 16:02:23 2016 Improve NetLog logging in net::BidirectionalStream This CL adds three additional events to net::BidirectionalStream to log when buffers are coalesced, when stream is ready, and when stream is failed. BUG= 617698 Review-Url: https://codereview.chromium.org/2044583002 Cr-Commit-Position: refs/heads/master@{#399198} [modify] https://crrev.com/2704f5d77380f5a941a3d0f31c9bcbc0ea68fffb/net/http/bidirectional_stream.cc [modify] https://crrev.com/2704f5d77380f5a941a3d0f31c9bcbc0ea68fffb/net/http/bidirectional_stream_unittest.cc [modify] https://crrev.com/2704f5d77380f5a941a3d0f31c9bcbc0ea68fffb/net/log/net_log_event_type_list.h |
||
►
Sign in to add a comment |
||
Comment 1 by xunji...@chromium.org
, Jun 6 2016