Record for how long a video is playing off viewport when it started from autoplay muted |
|||||||||||||
Issue descriptionWe want to find out how long they are being played offscreen. We will have to make sure we actually record the metric given that the "back to viewport" might never happen.
,
Jun 24 2016
,
Jun 28 2016
,
Jul 6 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc74c3a6422be9a25c635021a57f7f0950c0381c commit cc74c3a6422be9a25c635021a57f7f0950c0381c Author: zqzhang <zqzhang@chromium.org> Date: Mon Aug 22 20:30:20 2016 Record the offscreen playing duration of autoplaying muted videos BUG= 617681 Review-Url: https://codereview.chromium.org/2101613002 Cr-Commit-Position: refs/heads/master@{#413522} [modify] https://crrev.com/cc74c3a6422be9a25c635021a57f7f0950c0381c/third_party/WebKit/LayoutTests/media/video-autoplay-experiment-modes-expected.txt [modify] https://crrev.com/cc74c3a6422be9a25c635021a57f7f0950c0381c/third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp [modify] https://crrev.com/cc74c3a6422be9a25c635021a57f7f0950c0381c/third_party/WebKit/Source/core/html/AutoplayUmaHelper.h [modify] https://crrev.com/cc74c3a6422be9a25c635021a57f7f0950c0381c/tools/metrics/histograms/histograms.xml
,
Aug 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36d7422fbb9f27d2a931e91edcabe473a2d55772 commit 36d7422fbb9f27d2a931e91edcabe473a2d55772 Author: megjablon <megjablon@chromium.org> Date: Tue Aug 23 02:12:37 2016 Revert "Record the offscreen playing duration of autoplaying muted videos" This reverts commit cc74c3a6422be9a25c635021a57f7f0950c0381c. Tests failing on https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak: media/autoplay-muted.html media/autoplay-unmute-offscreen.html media/autoplay-when-visible.html 15:30:48.155 15954 worker/3 media/autoplay-unmute-offscreen.html leaked 15:30:48.155 15954 Xlib: extension "RANDR" missing on display ":9". 15:30:48.155 15954 Xlib: extension "RANDR" missing on display ":9". 15:30:48.155 15954 [4:4:0822/153047:2028208541:WARNING:webmediaplayer_impl.cc(372)] Using MultibufferDataSource 15:30:48.155 15954 [4:4:0822/153047:2028209045:WARNING:webmediaplayer_impl.cc(372)] Using MultibufferDataSource 15:30:48.158 18115 [35/36] media/autoplay-unmute-offscreen.html failed unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,3]})) 15:30:48.157 15954 worker/3 media/autoplay-unmute-offscreen.html failed: 15:30:48.157 15954 worker/3 leak detected: ({"numberOfLiveActiveDOMObjects":[2,3]}) TBR=isherman@chromium.org, mlamouri@chromium.org BUG= 617681 Review-Url: https://codereview.chromium.org/2266253002 Cr-Commit-Position: refs/heads/master@{#413635} [modify] https://crrev.com/36d7422fbb9f27d2a931e91edcabe473a2d55772/third_party/WebKit/LayoutTests/media/video-autoplay-experiment-modes-expected.txt [modify] https://crrev.com/36d7422fbb9f27d2a931e91edcabe473a2d55772/third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp [modify] https://crrev.com/36d7422fbb9f27d2a931e91edcabe473a2d55772/third_party/WebKit/Source/core/html/AutoplayUmaHelper.h [modify] https://crrev.com/36d7422fbb9f27d2a931e91edcabe473a2d55772/tools/metrics/histograms/histograms.xml
,
Aug 23 2016
Hmm, the leak is flaky on debug build but 100% repro on release build. Trying to find the cause.
,
Aug 23 2016
,
Aug 23 2016
Issue 640213 has been merged into this issue.
,
Aug 23 2016
The CL is also causing a crash :( The crash is simple to fix, just add null-check when calling m_element->removeEventListener()
,
Aug 23 2016
Users experienced this crash on the following builds: Mac Canary 54.0.2837.0 - 12.62 CPM, 7 reports, 6 clients (signature blink::AutoplayUmaHelper::maybeStopRecordingMutedVideoOffscreenDuration) If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates. - Go/Fracas
,
Aug 23 2016
Users experienced this crash on the following builds: Win Canary 54.0.2837.0 - 6.44 CPM, 25 reports, 12 clients (signature blink::AutoplayUmaHelper::maybeStopRecordingMutedVideoOffscreenDuration) Win Canary 54.0.2837.0 - 15.70 CPM, 61 reports, 34 clients (signature blink::EventTarget::removeEventListener) Mac Canary 54.0.2837.0 - 15.05 CPM, 10 reports, 9 clients (signature blink::AutoplayUmaHelper::maybeStopRecordingMutedVideoOffscreenDuration) If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates. - Go/Fracas
,
Aug 23 2016
This crash has high impact on Chrome's stability. Signature: blink::EventTarget::removeEventListener. Channel: canary. Platform: win. Labeling issue 617681 with ReleaseBlock-Dev. If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates. - Go/Fracas
,
Aug 23 2016
,
Aug 24 2016
Just to update comparing to previous milestone M53dev, this is a top # 2 crasher on current M54 dev 54.0.2837.0. Currently there are 900 crash instances from 627 client Ids. Link to crashes : https://crash.corp.google.com/browse?q=product.name%3D%27Chrome%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27blink%3A%3AEventTarget%3A%3AremoveEventListener%27%20AND%20product.Version%3D%2754.0.2837.0%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D Added ReleaseBlock-Beta against M54, please modify if not appropriate.
,
Aug 24 2016
Hi Durga, Seems like I should not merge the original crbug issue into this one, which is redirecting all crash warnings here. The crash should already been fixed now. I'll remove the crbug in go/chromecrash.
,
Aug 26 2016
Issue 640951 has been merged into this issue.
,
Sep 6 2016
,
Sep 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d791630a5f638c81b21284a7a8a22778c315cdde commit d791630a5f638c81b21284a7a8a22778c315cdde Author: zqzhang <zqzhang@chromium.org> Date: Tue Sep 13 09:50:42 2016 Reland "Record the offscreen playing duration of autoplaying muted videos" Seems the memory leak has already been fixed somewhere. Relanding this CL. BUG= 617681 , 640195 TBR=mlamouri@chromium.org,isherman@chromium.org Review-Url: https://codereview.chromium.org/2331893003 Cr-Commit-Position: refs/heads/master@{#418208} [modify] https://crrev.com/d791630a5f638c81b21284a7a8a22778c315cdde/third_party/WebKit/LayoutTests/media/video-autoplay-experiment-modes-expected.txt [modify] https://crrev.com/d791630a5f638c81b21284a7a8a22778c315cdde/third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp [modify] https://crrev.com/d791630a5f638c81b21284a7a8a22778c315cdde/third_party/WebKit/Source/core/html/AutoplayUmaHelper.h [modify] https://crrev.com/d791630a5f638c81b21284a7a8a22778c315cdde/tools/metrics/histograms/histograms.xml
,
Sep 14 2016
Fixed? :)
,
Sep 14 2016
Yes! |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by mlamouri@chromium.org
, Jun 22 2016