New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 617681 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Android MediaRouter only (left Chro...
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows , Mac
Pri: 2
Type: Bug

Blocked on:
issue 640195



Sign in to add a comment

Record for how long a video is playing off viewport when it started from autoplay muted

Project Member Reported by mlamouri@chromium.org, Jun 6 2016

Issue description

We want to find out how long they are being played offscreen. We will have to make sure we actually record the metric given that the "back to viewport" might never happen.
 
Labels: -Pri-1 Pri-2
Owner: zqzh...@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 6 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36d7422fbb9f27d2a931e91edcabe473a2d55772

commit 36d7422fbb9f27d2a931e91edcabe473a2d55772
Author: megjablon <megjablon@chromium.org>
Date: Tue Aug 23 02:12:37 2016

Revert "Record the offscreen playing duration of autoplaying muted videos"

This reverts commit cc74c3a6422be9a25c635021a57f7f0950c0381c.

Tests failing on https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak:
media/autoplay-muted.html
media/autoplay-unmute-offscreen.html
media/autoplay-when-visible.html

15:30:48.155 15954 worker/3 media/autoplay-unmute-offscreen.html leaked
15:30:48.155 15954   Xlib:  extension "RANDR" missing on display ":9".
15:30:48.155 15954   Xlib:  extension "RANDR" missing on display ":9".
15:30:48.155 15954   [4:4:0822/153047:2028208541:WARNING:webmediaplayer_impl.cc(372)] Using MultibufferDataSource
15:30:48.155 15954   [4:4:0822/153047:2028209045:WARNING:webmediaplayer_impl.cc(372)] Using MultibufferDataSource
15:30:48.158 18115 [35/36] media/autoplay-unmute-offscreen.html failed unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,3]}))
15:30:48.157 15954 worker/3 media/autoplay-unmute-offscreen.html failed:
15:30:48.157 15954 worker/3  leak detected: ({"numberOfLiveActiveDOMObjects":[2,3]})

TBR=isherman@chromium.org, mlamouri@chromium.org
BUG= 617681 

Review-Url: https://codereview.chromium.org/2266253002
Cr-Commit-Position: refs/heads/master@{#413635}

[modify] https://crrev.com/36d7422fbb9f27d2a931e91edcabe473a2d55772/third_party/WebKit/LayoutTests/media/video-autoplay-experiment-modes-expected.txt
[modify] https://crrev.com/36d7422fbb9f27d2a931e91edcabe473a2d55772/third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp
[modify] https://crrev.com/36d7422fbb9f27d2a931e91edcabe473a2d55772/third_party/WebKit/Source/core/html/AutoplayUmaHelper.h
[modify] https://crrev.com/36d7422fbb9f27d2a931e91edcabe473a2d55772/tools/metrics/histograms/histograms.xml

Hmm, the leak is flaky on debug build but 100% repro on release build.
Trying to find the cause.
Blockedon: 640195
Issue 640213 has been merged into this issue.
The CL is also causing a crash :(
The crash is simple to fix, just add null-check when calling m_element->removeEventListener()
Project Member

Comment 11 by sheriffbot@chromium.org, Aug 23 2016

Labels: Fracas OS-Mac FoundIn-M-54
Users experienced this crash on the following builds:

Mac Canary 54.0.2837.0 -  12.62 CPM, 7 reports, 6 clients (signature blink::AutoplayUmaHelper::maybeStopRecordingMutedVideoOffscreenDuration)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Project Member

Comment 12 by sheriffbot@chromium.org, Aug 23 2016

Labels: OS-Windows
Users experienced this crash on the following builds:

Win Canary 54.0.2837.0 -  6.44 CPM, 25 reports, 12 clients (signature blink::AutoplayUmaHelper::maybeStopRecordingMutedVideoOffscreenDuration)
Win Canary 54.0.2837.0 -  15.70 CPM, 61 reports, 34 clients (signature blink::EventTarget::removeEventListener)
Mac Canary 54.0.2837.0 -  15.05 CPM, 10 reports, 9 clients (signature blink::AutoplayUmaHelper::maybeStopRecordingMutedVideoOffscreenDuration)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Project Member

Comment 13 by sheriffbot@chromium.org, Aug 23 2016

Labels: ReleaseBlock-Dev
This crash has high impact on Chrome's stability.
Signature: blink::EventTarget::removeEventListener.
Channel: canary. Platform: win.
Labeling  issue 617681  with ReleaseBlock-Dev.


If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Labels: -ReleaseBlock-Dev -Fracas Fracas-Wrong
Labels: ReleaseBlock-Beta
Just to update comparing to previous milestone M53dev, this is a top # 2 crasher on current M54 dev 54.0.2837.0. Currently there are 900 crash instances from 627 client Ids.
Link to crashes : https://crash.corp.google.com/browse?q=product.name%3D%27Chrome%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27blink%3A%3AEventTarget%3A%3AremoveEventListener%27%20AND%20product.Version%3D%2754.0.2837.0%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D
Added ReleaseBlock-Beta against M54, please modify if not appropriate.

Labels: -ReleaseBlock-Beta
Hi Durga,
Seems like I should not merge the original crbug issue into this one, which is redirecting all crash warnings here.

The crash should already been fixed now. I'll remove the crbug in go/chromecrash.
Issue 640951 has been merged into this issue.
Labels: -M-54 -Fracas-Wrong -FoundIn-M-54 M-55
Fixed? :)
Status: Fixed (was: Started)
Yes!

Sign in to add a comment