Delete non-(V8/overall) values from long-running V8 benchmarks |
|||||
Issue description
Please DELETE retrospectively all values satisfying the following
condition:
The name MATCHES re.compile(r'memory:chrome') and at the same time
matches NEITHER re.compile(r'renderer:subsystem:v8')
NOR re.compile(r'renderer:vmstats:overall')
in the following benchmarks:
memory.long_running_idle_gmail_tbmv2
memory.long_running_idle_gmail_background_tbmv2
For completeness, I attached lists enumerating all values that should be
removed for each benchmark.
ulan: Could you please double check that this is correct and then re-assign back to me?
,
Jun 6 2016
,
Jun 7 2016
LGTM, thank you.
,
Jun 7 2016
,
Jun 7 2016
Annie: This delete can be safely executed now (it's not blocked on anything).
,
Jun 7 2016
I've deleted the data. ulan: we got some alerts on monitored metrics being deleted: memory:chrome:all:subsystem:v8:allocated_objects_avg memory:chrome:all:subsystem:v8:allocated_objects_max memory:chrome:all:subsystem:v8_avg memory:chrome:all:subsystem:v8_max I should just update those to change 'all' to 'renderer', right?
,
Jun 8 2016
Yes, please. The correct value names to monitor are actually (uppercase used just for emphasis, the actual names are all completely lower-case): memory:chrome:RENDERER:subsystem:v8:allocated_objects_SIZE_avg memory:chrome:RENDERER:subsystem:v8:allocated_objects_SIZE_max memory:chrome:RENDERER:subsystem:v8:EFFECTIVE_SIZE_avg memory:chrome:RENDERER:subsystem:v8:EFFECTIVE_SIZE_max Thanks!
,
Jun 9 2016
Thanks for clarifying! monitoring updated as per comment 7.
,
Jun 9 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by petrcermak@chromium.org
, Jun 6 2016