New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 617634 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature


Show other hotlists

Hotlists containing this issue:
Payments-TechDebt


Sign in to add a comment

Use //components/safe_json in PaymentRequestImpl

Project Member Reported by rouslan@chromium.org, Jun 6 2016

Issue description

^^^^
 
Still to-do: Make JsonSanitizer return a sanitized JSONObject.
Labels: -Pri-1 -Type-Bug Pri-2 Type-Feature
Owner: se...@chromium.org
Status: Assigned (was: Started)
sebsg@ to the rescue: Make JsonSanitizer return a sanitized JSONObject similar to the C++ API in //components/safe_json.
Minor comment: I'd like the public java API to be named SafeJsonParser, just like the C++ side, and the JsonSanitizer should be an implementation detail of both that interface and the C++ one.
Minor comment on the minor comment: :-D In C++, the JsonSanitizer is exposed on purpose, because for Supervised User whitelists we run sanitization before writing them to disk, so we can later load them without the additional overhead. Only exposing SafeJsonParser would mean one unnecessary parsing/serialization roundtrip on Android.
Ah, I forgot we exposed JsonSanitizer directly to C++ too. Then we should have the Java API mirror the C++ one with both JsonSanitizer and SafejsonParser.
That sounds good :)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment