Use //components/safe_json in PaymentRequestImpl |
|||
Issue description^^^^
,
Jun 17 2016
Still to-do: Make JsonSanitizer return a sanitized JSONObject.
,
Jul 4 2016
sebsg@ to the rescue: Make JsonSanitizer return a sanitized JSONObject similar to the C++ API in //components/safe_json.
,
Jul 6 2016
Minor comment: I'd like the public java API to be named SafeJsonParser, just like the C++ side, and the JsonSanitizer should be an implementation detail of both that interface and the C++ one.
,
Jul 6 2016
Minor comment on the minor comment: :-D In C++, the JsonSanitizer is exposed on purpose, because for Supervised User whitelists we run sanitization before writing them to disk, so we can later load them without the additional overhead. Only exposing SafeJsonParser would mean one unnecessary parsing/serialization roundtrip on Android.
,
Jul 6 2016
Ah, I forgot we exposed JsonSanitizer directly to C++ too. Then we should have the Java API mirror the C++ one with both JsonSanitizer and SafejsonParser.
,
Jul 6 2016
That sounds good :)
,
Jun 27 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jun 7 2016