[Cronet] Make CronetEngine.StartNetLogToFile/StopNetLog synchronous. |
||
Issue descriptionCronetEngine.StartNetLogToFile and StopNetLog post asynchronous tasks to the network thread. This results truncated logs if executing those tasks is slow on the network thread (See internal bug 29114744 for more details). Since NetLog is a global and thread-safe, we could create and tear down WriteToFileNetLogObserver on any Java thread. The access needs to be protected by a lock as we might access WriteToFileNetLogObserver on multiple threads.
,
Jun 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a0656e9ea5eac86f6dedbc9ea733c6b95b58d04 commit 2a0656e9ea5eac86f6dedbc9ea733c6b95b58d04 Author: xunjieli <xunjieli@chromium.org> Date: Wed Jun 08 17:46:37 2016 [Cronet] Make StartNetLog and StopNetLog synchronous in Cronet CronetEngine.StartNetLogToFile and StopNetLog post asynchronous tasks to the network thread. This results truncated logs if executing those tasks is slow on the network thread. Since NetLog is a global and thread-safe, this CL creates and tears down WriteToFileNetLogObserver on the calling Java thread. The access to WriteToFileNetLogObserver is protected by a lock to ensure thread safety. BUG= 617632 Review-Url: https://codereview.chromium.org/2035313008 Cr-Commit-Position: refs/heads/master@{#398612} [modify] https://crrev.com/2a0656e9ea5eac86f6dedbc9ea733c6b95b58d04/components/cronet/android/cronet_url_request_context_adapter.cc [modify] https://crrev.com/2a0656e9ea5eac86f6dedbc9ea733c6b95b58d04/components/cronet/android/cronet_url_request_context_adapter.h
,
Jun 8 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by xunji...@chromium.org
, Jun 6 2016Status: Started (was: Available)