CQ config file should require fully spelled bucket names, don't guess "master." prefix. |
||||||||||||||
Issue descriptionWhat title says. The problem with current approach is that non-buildbot buckets must still be started with "master.xxxx.yyy", which is just creating confusion.
,
Jun 6 2016
,
Jun 20 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/4d8b1476957fbc4e8cd550d8f0dffe22a68b0f61 commit 4d8b1476957fbc4e8cd550d8f0dffe22a68b0f61 Author: tandrii <tandrii@google.com> Date: Mon Jun 20 17:26:44 2016
,
Jun 24 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/73eadf346580d5c4547d920cfda5a4606a7d143c commit 73eadf346580d5c4547d920cfda5a4606a7d143c Author: tandrii <tandrii@google.com> Date: Fri Jun 24 14:20:39 2016
,
Jun 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/92261d26ec2627df90c0b527dacdf6d079df4e0c commit 92261d26ec2627df90c0b527dacdf6d079df4e0c Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Jun 24 14:22:24 2016 Make bucket names explicit in cq.cfg. Don't assume bucket name to start with 'master.'. NOTRY=True BUG= chromium:617627 Change-Id: I177e85e53ffdce01c8f8460a96c53d9564354307 Reviewed-on: https://chromium-review.googlesource.com/355981 Reviewed-by: Sergiy Byelozyorov <sergiyb@google.com> Commit-Queue: Sergiy Byelozyorov <sergiyb@google.com> [modify] https://crrev.com/92261d26ec2627df90c0b527dacdf6d079df4e0c/config/cq.cfg
,
Jun 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d49a280262a26c8ce517322b97fe796a4ed3204 commit 9d49a280262a26c8ce517322b97fe796a4ed3204 Author: tandrii <tandrii@chromium.org> Date: Fri Jun 24 14:39:04 2016 Make bucket names explicit in cq.cfg. Don't assume bucket name to start with 'master.'. NOTRY=True BUG= chromium:617627 R=phajdan.jr@chromium.org, sergiyb@chromium.org Review-Url: https://codereview.chromium.org/2088393004 Cr-Commit-Position: refs/heads/master@{#401860} [modify] https://crrev.com/9d49a280262a26c8ce517322b97fe796a4ed3204/infra/config/cq.cfg
,
Jun 24 2016
,
Jun 24 2016
,
Jun 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/fd99bfc647aeb87689091a78498b178e8ac4e5d5 commit fd99bfc647aeb87689091a78498b178e8ac4e5d5 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Jun 24 14:31:09 2016 Make bucket names explicit in cq.cfg. Don't assume bucket name to start with 'master.'. NOTRY=True BUG= chromium:617627 Change-Id: I4e634fd2f485ac06c8e06af2de0cd86dbf425e9b Reviewed-on: https://chromium-review.googlesource.com/355990 Reviewed-by: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/fd99bfc647aeb87689091a78498b178e8ac4e5d5/infra/config/cq.cfg
,
Jun 24 2016
I've went through all CQ configs here https://commit-queue.appspot.com/restricted/configs and created CLs.
,
Jun 24 2016
The following revision refers to this bug: https://skia.googlesource.com/buildbot.git/+/35707ae7e83a08f0b8482d4ffc908cc43617c609 commit 35707ae7e83a08f0b8482d4ffc908cc43617c609 Author: tandrii <tandrii@chromium.org> Date: Fri Jun 24 18:25:33 2016 Make bucket names explicit in cq.cfg. Don't assume bucket name to start with 'master.'. NOTRY=True BUG= chromium:617627 R=sergiyb@google.com,rmistry@google.com Review-Url: https://codereview.chromium.org/2096943003 [modify] https://crrev.com/35707ae7e83a08f0b8482d4ffc908cc43617c609/infra/branch-config/cq.cfg
,
Jun 24 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/acbbd942a9e8f542026f29c876141163e5aa61c7 commit acbbd942a9e8f542026f29c876141163e5aa61c7 Author: tandrii <tandrii@google.com> Date: Fri Jun 24 18:31:26 2016
,
Jun 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe5b345331487cd25e29ee300c51d0557110dca0 commit fe5b345331487cd25e29ee300c51d0557110dca0 Author: skia-deps-roller <skia-deps-roller@chromium.org> Date: Fri Jun 24 20:53:04 2016 Roll src/third_party/skia/ 8acedde59..e2cddc534 (2 commits). https://chromium.googlesource.com/skia.git/+log/8acedde5970c..e2cddc5342d5 $ git log 8acedde59..e2cddc534 --date=short --no-merges --format='%ad %ae %s' 2016-06-24 brianosman Fix incorrect swizzle on BGRA platforms in filterColor4f path 2016-06-24 tandrii Make bucket names explicit in cq.cfg. BUG= 617627 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=brianosman@google.com Review-Url: https://codereview.chromium.org/2094703006 Cr-Commit-Position: refs/heads/master@{#401962} [modify] https://crrev.com/fe5b345331487cd25e29ee300c51d0557110dca0/DEPS
,
Jun 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/b580edda3f2b6270167d2431b1a2fd4f5477ca27 commit b580edda3f2b6270167d2431b1a2fd4f5477ca27 Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Jun 24 21:36:16 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/43b25d5e9d503477f62e27c5c49cab0241787b4c Make bucket names explicit in cq.cfg. (tandrii@chromium.org) https://crrev.com/dc3dede9cec7f8dd4ccf2f2f2c42da6d6f1f05e9 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) recipe_engine: https://crrev.com/2eb32f6462d24eda586ae27d785c75a6e300197c improve unicode support (martiniss@chromium.org) R=phajdan.jr@chromium.org,recipe-roller@chromium.org,sergiyb@chromium.org,martiniss@chromium.org,tandrii@chromium.org BUG= chromium:617627 ,619694 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2098003002 [modify] https://crrev.com/b580edda3f2b6270167d2431b1a2fd4f5477ca27/infra/config/recipes.cfg
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/playground/gerrit-cq/normal/+/f1683088ca8b9147542cf35748da9612a093435b commit f1683088ca8b9147542cf35748da9612a093435b Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Mon Jun 27 13:28:59 2016 Make bucket names explicit in cq.cfg. Don't assume bucket name to start with 'master.'. NOTRY=True BUG= chromium:617627 Change-Id: Ibc8fe5ef851d71917baab0b43b832e07d5984048 Reviewed-on: https://chromium-review.googlesource.com/356400 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/f1683088ca8b9147542cf35748da9612a093435b/infra/config/cq.cfg
,
Jun 27 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build/+/6e2f5ed0ff67c91ec5a259aa7d5ab14efaca2fd4 commit 6e2f5ed0ff67c91ec5a259aa7d5ab14efaca2fd4 Author: tandrii <tandrii@google.com> Date: Mon Jun 27 14:27:28 2016
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/native_client/src/native_client.git/+/631e22d24a37d9c1b7092a5d3a15d27e2769d6bc commit 631e22d24a37d9c1b7092a5d3a15d27e2769d6bc Author: tandrii <tandrii@chromium.org> Date: Mon Jun 27 14:58:45 2016 Make bucket names explicit in cq.cfg. Don't assume bucket name to start with 'master.'. NOTRY=True BUG= chromium:617627 Review-Url: https://codereview.chromium.org/2099753002 [modify] https://crrev.com/631e22d24a37d9c1b7092a5d3a15d27e2769d6bc/infra/config/cq.cfg
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/7ba0262248ffa2ad9a993ee96875d441907ad869 commit 7ba0262248ffa2ad9a993ee96875d441907ad869 Author: tandrii <tandrii@chromium.org> Date: Mon Jun 27 15:04:40 2016 Make bucket names explicit in cq.cfg. Don't assume bucket name to start with 'master.'. NOTRY=True BUG= chromium:617627 R=kjellander@webrtc.org Review-Url: https://codereview.webrtc.org/2095083002 Cr-Commit-Position: refs/heads/master@{#13296} [modify] https://crrev.com/7ba0262248ffa2ad9a993ee96875d441907ad869/infra/config/cq.cfg
,
Jun 27 2016
And I'm done! Now cleaning up CQ codebase.
,
Jun 27 2016
,
Jun 27 2016
,
Jun 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9473e3e4a7e1ab2b569024a86bc672d55f2ac2f8 commit 9473e3e4a7e1ab2b569024a86bc672d55f2ac2f8 Author: nacl-deps-roller <nacl-deps-roller@chromium.org> Date: Tue Jun 28 23:27:59 2016 Roll src/native_client/ d1ea091da..41bda598a (3 commits). https://chromium.googlesource.com/native_client/src/native_client.git/+log/d1ea091dad37..41bda598ad1e $ git log d1ea091da..41bda598a --date=short --no-merges --format='%ad %ae %s' 2016-06-28 mseaborn Futexes: Fix race between futex timeout and wakeup that can lose wakeups 2016-06-27 thakis nacl/mac: Remove outer_sandbox.c 2016-06-27 tandrii Make bucket names explicit in cq.cfg. BUG= 617627 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build TBR=mseaborn@chromium.org Review-Url: https://codereview.chromium.org/2104153002 Cr-Commit-Position: refs/heads/master@{#402593} [modify] https://crrev.com/9473e3e4a7e1ab2b569024a86bc672d55f2ac2f8/DEPS
,
Jun 30 2016
As the roller message above shows: this bug can't be closed until we ensure that those recipe rollers explicitly use master prefix.
,
Jun 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39d447a13fdc171f98d81b87ca0a75995d5a5e78 commit 39d447a13fdc171f98d81b87ca0a75995d5a5e78 Author: geofflang <geofflang@chromium.org> Date: Thu Jun 30 16:17:17 2016 Roll ANGLE be5a8a4..3c75419 https://chromium.googlesource.com/angle/angle.git/+log/be5a8a4..3c75419 BUG= chromium:617848 , 598924 , chromium:617627 , chromium:534814 , 483282 , 620937 TBR=jmadill@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2119463002 Cr-Commit-Position: refs/heads/master@{#403192} [modify] https://crrev.com/39d447a13fdc171f98d81b87ca0a75995d5a5e78/DEPS
,
Jul 5 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/a992c13e30d968c4fcb4ab5892b9cedc1cbbdfe0 commit a992c13e30d968c4fcb4ab5892b9cedc1cbbdfe0 Author: tandrii <tandrii@google.com> Date: Tue Jul 05 16:22:30 2016
,
Jul 5 2016
,
Jul 13 2016
Special deprecator verifier has been deployed (https://chromereviews.googleplex.com/470837013/) that warns users of CQ whenever they rely on implicit "master." prefix. So, I'll keep it like this, and then finally deprecate.
,
Jul 13 2016
When I hit CQ button I get directed to this bug, but I don't understand what am I supposed to do?
,
Jul 13 2016
Is it this line causing the warning? CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Should that say master.tryserver.blink:linux_blink_rel instead?
,
Jul 13 2016
,
Jul 13 2016
danakj@ your understanding is correct. piman@ and danakj@ Do you have an idea what message would have been more clear?
,
Jul 13 2016
It took me a few reads to undertand it was talking about the CQ_INCLUDE_TRYBOTS line in the description. I thought it was referring to something in the CQ infrastructure at first. Referring to that would help. Some reformatting would help too. Now: Your CL relies on deprecated CQ feature(s): * Specifying master names without "master." prefix is deprecated: tryserver.chromium.linux, tryserver.chromium.mac, tryserver.chromium.win. For more details, see http://crbug.com/617627 . Proposed: Your CL relies on deprecated CQ feature(s): * Specifying tryserver master names in CQ_INCLUDE_TRYBOTS without a "master." prefix is deprecated: tryserver.chromium.linux, tryserver.chromium.mac, tryserver.chromium.win. For more details, see http://crbug.com/617627 .
,
Jul 13 2016
Also this context in the bug here will help future people :)
,
Jul 13 2016
% git gs tryserver\.|grep PRESUBMIT
PRESUBMIT.py:2185: 'chromium_presubmit': 'tryserver.chromium.linux',
PRESUBMIT.py:2186: 'tools_build_presubmit': 'tryserver.chromium.linux',
PRESUBMIT.py:2191: master = 'tryserver.chromium.android'
PRESUBMIT.py:2193: master = 'tryserver.chromium.linux'
PRESUBMIT.py:2195: master = 'tryserver.chromium.win'
PRESUBMIT.py:2197: master = 'tryserver.chromium.mac'
PRESUBMIT.py:2207: # Build up the mapping from tryserver master to bot/test.
PRESUBMIT_test.py:709: 'tryserver.chromium.android': [
PRESUBMIT_test.py:733: 'tryserver.chromium.mac': [
PRESUBMIT_test.py:749: 'tryserver.chromium.linux': [
PRESUBMIT_test.py:784: 'tryserver.chromium.win': [
cc/PRESUBMIT.py:341: 'master.tryserver.blink:linux_blink_rel',
chrome/browser/resources/PRESUBMIT.py:108: new_bots = clean_bots | set(['tryserver.chromium.linux:closure_compilation'])
content/browser/frame_host/PRESUBMIT.py:15: 'tryserver.chromium.linux': {
content/test/gpu/PRESUBMIT.py:76: 'tryserver.chromium.linux:linux_optional_gpu_tests_rel',
content/test/gpu/PRESUBMIT.py:77: 'tryserver.chromium.mac:mac_optional_gpu_tests_rel',
content/test/gpu/PRESUBMIT.py:78: 'tryserver.chromium.win:win_optional_gpu_tests_rel',
gpu/PRESUBMIT.py:26: 'tryserver.chromium.linux:linux_optional_gpu_tests_rel',
gpu/PRESUBMIT.py:27: 'tryserver.chromium.mac:mac_optional_gpu_tests_rel',
gpu/PRESUBMIT.py:28: 'tryserver.chromium.win:win_optional_gpu_tests_rel',
native_client_sdk/PRESUBMIT.py:44: 'tryserver.chromium.linux': {
native_client_sdk/PRESUBMIT.py:48: 'tryserver.chromium.win': {
native_client_sdk/PRESUBMIT.py:52: 'tryserver.chromium.mac': {
sandbox/win/PRESUBMIT.py:26: 'tryserver.chromium.win:win10_chromium_x64_rel_ng',
third_party/WebKit/Source/modules/webgl/PRESUBMIT.py:28: 'tryserver.chromium.win:win_optional_gpu_tests_rel',
third_party/WebKit/Source/modules/webgl/PRESUBMIT.py:29: 'tryserver.chromium.mac:mac_optional_gpu_tests_rel',
tools/perf/PRESUBMIT.py:134: bots = ['tryserver.chromium.perf:%s' % s for s in bots]
tools/valgrind/drmemory/PRESUBMIT.py:36: 'tryserver.chromium.win': {
ui/webui/resources/PRESUBMIT.py:14: new_bots = clean_bots | set(['tryserver.chromium.linux:closure_compilation'])
It looks like there is a bunch of places that add the wrong things. I've fixed the cc/ one, but could you go through the rest?
,
Jul 13 2016
Improving message: https://chromereviews.googleplex.com/470887013 Re #34: will do.
,
Jul 13 2016
nothing internal here.
,
Jul 13 2016
Sorry about that. danakj@ should I fix the GPU presubmit checks or would you help out by doing so? Thanks.
,
Jul 13 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/8196b204517c178d6984220e7eabf13c6f8095d3 commit 8196b204517c178d6984220e7eabf13c6f8095d3 Author: tandrii <tandrii@google.com> Date: Wed Jul 13 20:44:57 2016
,
Jul 13 2016
kbr@ I think this CL should fix all PRESUBMITS (thanks to danakj@ for heads up) https://codereview.chromium.org/2148053002
,
Jul 13 2016
I am disabling the warnings until My CL lands. I've underestimated the amount.
,
Jul 13 2016
https://chromereviews.googleplex.com/468027014/ is the revert. Will be deployed within 5 minutes.
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4830867580d6ce70f500f0ea145248a4c1b892ff commit 4830867580d6ce70f500f0ea145248a4c1b892ff Author: danakj <danakj@chromium.org> Date: Wed Jul 13 21:31:00 2016 cc presubmit: Add "master." prefix for the blink tryserver. R=tandrii@chromium.org BUG= 617627 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2147793003 Cr-Commit-Position: refs/heads/master@{#405293} [modify] https://crrev.com/4830867580d6ce70f500f0ea145248a4c1b892ff/cc/PRESUBMIT.py
,
Jul 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5587794fa922c30fe4ef22857f20721f75c5e56 commit e5587794fa922c30fe4ef22857f20721f75c5e56 Author: tandrii <tandrii@chromium.org> Date: Thu Jul 14 00:34:50 2016 PRESUBMIT: use "master." prefix in CQ_INCLUDE_TRYBOTS. R=jam@chromium.org,danakj@chromium.org,kbr@chromium.org BUG= 617627 Review-Url: https://codereview.chromium.org/2148053002 Cr-Commit-Position: refs/heads/master@{#405365} [modify] https://crrev.com/e5587794fa922c30fe4ef22857f20721f75c5e56/PRESUBMIT.py [modify] https://crrev.com/e5587794fa922c30fe4ef22857f20721f75c5e56/PRESUBMIT_test.py [modify] https://crrev.com/e5587794fa922c30fe4ef22857f20721f75c5e56/chrome/browser/resources/PRESUBMIT.py [modify] https://crrev.com/e5587794fa922c30fe4ef22857f20721f75c5e56/content/browser/frame_host/PRESUBMIT.py [modify] https://crrev.com/e5587794fa922c30fe4ef22857f20721f75c5e56/content/test/gpu/PRESUBMIT.py [modify] https://crrev.com/e5587794fa922c30fe4ef22857f20721f75c5e56/gpu/PRESUBMIT.py [modify] https://crrev.com/e5587794fa922c30fe4ef22857f20721f75c5e56/native_client_sdk/PRESUBMIT.py [modify] https://crrev.com/e5587794fa922c30fe4ef22857f20721f75c5e56/sandbox/win/PRESUBMIT.py [modify] https://crrev.com/e5587794fa922c30fe4ef22857f20721f75c5e56/third_party/WebKit/Source/modules/webgl/PRESUBMIT.py [modify] https://crrev.com/e5587794fa922c30fe4ef22857f20721f75c5e56/tools/perf/PRESUBMIT.py [modify] https://crrev.com/e5587794fa922c30fe4ef22857f20721f75c5e56/tools/valgrind/drmemory/PRESUBMIT.py [modify] https://crrev.com/e5587794fa922c30fe4ef22857f20721f75c5e56/ui/webui/resources/PRESUBMIT.py
,
Jul 14 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/4a4948de584c771f1cba31649d69daa11a349a4d commit 4a4948de584c771f1cba31649d69daa11a349a4d Author: tandrii <tandrii@google.com> Date: Thu Jul 14 11:13:14 2016
,
Jul 14 2016
I've re-enabled warnings.
,
Jul 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65854075e069afd2c5be3fbebc9c99cf36e5b59e commit 65854075e069afd2c5be3fbebc9c99cf36e5b59e Author: cwallez <cwallez@chromium.org> Date: Thu Jul 14 19:38:01 2016 tools/roll*: use master.tryserver instead of tryserver BUG= 617627 TBR=kjellander@chromium.org Review-Url: https://codereview.chromium.org/2150963002 Cr-Commit-Position: refs/heads/master@{#405543} [modify] https://crrev.com/65854075e069afd2c5be3fbebc9c99cf36e5b59e/tools/roll_angle.py [modify] https://crrev.com/65854075e069afd2c5be3fbebc9c99cf36e5b59e/tools/roll_webgl_conformance.py [modify] https://crrev.com/65854075e069afd2c5be3fbebc9c99cf36e5b59e/tools/roll_webrtc.py
,
Jul 18 2016
I'll keep this bug open for another 2 weeks and then finally require master prefix.
,
Jul 26 2016
I'm getting this deprecation warning on my CLs:
Your CL relies on deprecated CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
tryserver.chromium.linux
For more details, see http://crbug.com/617627 .
My CL has this on it:
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
I didn't *put that there*, some crazy bot, or possibly "git cl upload" itself, is doing it (and not indicating who did it) on all my CLs. This means I just get spammed with this deprecation notice through no fault of my own.
Please either remove this deprecation notice, or update whatever it is that is spamming my CL descriptions with this flag, to include "master.tryserver".
,
Jul 26 2016
mgiuca@ I'm sorry. The PRESUBMIT.py[1] has been fixed on July 14th. So, I think you just didn't rebase before uploading your patch. gclient sync + rebase your patch should resolve this issue for the future. [1] https://cs.chromium.org/chromium/src/content/browser/frame_host/PRESUBMIT.py?q=linux_site_isolation&sq=package:chromium&dr=C&l=13
,
Jul 27 2016
Oh OK great!
,
Aug 3 2016
,
Aug 10 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/6f73f72cfba62dbccd7e916a1e15c8e67fa7bcf5 commit 6f73f72cfba62dbccd7e916a1e15c8e67fa7bcf5 Author: tandrii <tandrii@google.com> Date: Wed Aug 10 16:17:21 2016
,
Aug 10 2016
And I've landed a change to completely disallow this.
,
Aug 10 2016
,
Oct 17 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/2907daf329801154e29fd95800327379860f26e7 commit 2907daf329801154e29fd95800327379860f26e7 Author: tandrii <tandrii@google.com> Date: Mon Oct 17 14:57:26 2016
,
Oct 17 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/aa6683c1781f9f7f6d6e81aa7a4409657e2784f5 commit aa6683c1781f9f7f6d6e81aa7a4409657e2784f5 Author: iannucci <iannucci@google.com> Date: Mon Oct 17 20:00:26 2016
,
Oct 19 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/43b6b1da7984d79523417b62879b9a69858bc0f5 commit 43b6b1da7984d79523417b62879b9a69858bc0f5 Author: tandrii <tandrii@google.com> Date: Wed Oct 19 11:53:08 2016
,
Oct 19 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/43b6b1da7984d79523417b62879b9a69858bc0f5 commit 43b6b1da7984d79523417b62879b9a69858bc0f5 Author: tandrii <tandrii@google.com> Date: Wed Oct 19 11:53:08 2016
,
Oct 19 2016
I've finally landed a CL that let's cq.cfg use arbitrary bucket names excpet for "tryserver.chromium*" which must start with master. for UX purpose. In retrospect, deprecating implicit assumptions is so very hard :( |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 6 2016