recipes shouldn't use runhooks_wrapper.py |
||||
Issue descriptionIt looks like there's now a script that automatically converts masters from ChromiumFactory to recipes. That's cool, but the recipes it generates are somewhat suboptimal. ChromiumFactory needs runhooks_wrapper.py because the goma dir isn't known until build time. With recipes, that's not true -- all the existing recipe bots use goma fine without this runhooks_wrapper.py trampoline. The autoconverted recipes bots shouldn't use it either, so that it can be deleted once everything's on recipes.
,
May 15 2017
I'm not familiar enough with the wrapper to know how to remove it, though it looks like it's actually only used in two autogenerated recipes: https://cs.chromium.org/search/?q=runhooks_wrapper+package:%5Echromium$+file:.py&type=cs Moving this up a level to client for now.
,
May 16 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 19
|
||||
►
Sign in to add a comment |
||||
Comment 1 by estaab@chromium.org
, Nov 17 2016Owner: ----
Status: Available (was: Assigned)