Pause autoplayed muted videos when unmuted if no gesture |
|||
Issue descriptionWhen unmuting, if there is no UserGestureIndicator in the stack, we should pause the playback. Otherwise, we should "unlock" the element.
,
Jun 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73df13de2a2ba7d1d7e132a3934d4d39f1959b66 commit 73df13de2a2ba7d1d7e132a3934d4d39f1959b66 Author: avayvod <avayvod@chromium.org> Date: Fri Jun 10 14:14:32 2016 Pause autoplay muted video when unmuting if there's no user gesture BUG= 617598 TEST=https://avayvod.github.io/autoplay-test.html Review-Url: https://codereview.chromium.org/2047333002 Cr-Commit-Position: refs/heads/master@{#399174} [modify] https://crrev.com/73df13de2a2ba7d1d7e132a3934d4d39f1959b66/third_party/WebKit/LayoutTests/media/autoplay-muted.html [modify] https://crrev.com/73df13de2a2ba7d1d7e132a3934d4d39f1959b66/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
,
Jun 10 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73df13de2a2ba7d1d7e132a3934d4d39f1959b66 commit 73df13de2a2ba7d1d7e132a3934d4d39f1959b66 Author: avayvod <avayvod@chromium.org> Date: Fri Jun 10 14:14:32 2016 Pause autoplay muted video when unmuting if there's no user gesture BUG= 617598 TEST=https://avayvod.github.io/autoplay-test.html Review-Url: https://codereview.chromium.org/2047333002 Cr-Commit-Position: refs/heads/master@{#399174} [modify] https://crrev.com/73df13de2a2ba7d1d7e132a3934d4d39f1959b66/third_party/WebKit/LayoutTests/media/autoplay-muted.html [modify] https://crrev.com/73df13de2a2ba7d1d7e132a3934d4d39f1959b66/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
,
Nov 23 2016
While reviewing https://codereview.chromium.org/2510353004/ and looking back at https://codereview.chromium.org/2091253002 I noticed that the UserGestureIndicator::processingUserGesture() added in HTMLMediaElement::setMuted should probably be UserGestureIndicator::utilizeUserGesture() instead.
,
Nov 23 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by avayvod@chromium.org
, Jun 8 2016