The NTP doesn't update the display when the omnibox is focused before it is loaded |
|||||||||||
Issue description1. Go to the NTP, then kill Chrome. (to make sure it will start on the NTP next time it is opened) 2. Open Chrome and tap on the omnibox right away 3. Observe Expected: The omnibox is focused and updated to reflect that, then the NTP finishes loading and the tiles are snapped at the bottom of the omnibox Actual: The omnibox is focused and updated to reflect that, the the NTP finishes loading but does so as if the omnibox was not focused. It sill shows the fakebox, so we have 2 omniboxes showing.
,
Jun 7 2016
Friendly ping :)
,
Jun 7 2016
I also can't repro it - at least on my N5x. But according to your screenshot you are using a much older device, right?
,
Jun 7 2016
,
Jun 7 2016
I can repro reliably on N5/KK and N6/L with debug builds Using Chrome Dev on N6 it's less reliable, as Chrome starts much faster. See the attached video for repro. I tried on the N6 with Chrome Dev. at 0:30 I tried on a local build.
,
Jun 7 2016
,
Jul 1 2016
,
Jul 9 2016
,
Jul 9 2016
,
Jul 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2ea385339e75be9f8d8edcfa600273fd4db7a54 commit d2ea385339e75be9f8d8edcfa600273fd4db7a54 Author: dgn <dgn@chromium.org> Date: Mon Jul 11 11:58:44 2016 [NTP] Delay the URL focus effects if they happen before NTP is loaded. When the URL bar is focused before the NTP is loaded, the UI misses the events and renders in the incorrect state. This change just runs the effects of the event later. BUG= 617582 Review-Url: https://codereview.chromium.org/2133753002 Cr-Commit-Position: refs/heads/master@{#404634} [modify] https://crrev.com/d2ea385339e75be9f8d8edcfa600273fd4db7a54/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/d2ea385339e75be9f8d8edcfa600273fd4db7a54/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
,
Jul 11 2016
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by nepper@chromium.org
, Jun 6 2016