New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 617577 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Peeking card does not show border on tablet

Project Member Reported by bauerb@chromium.org, Jun 6 2016

Issue description

Chrome version: 53.0.2761.0 (trunk)
Device: Pixel C

The peeking card does not appear with a side border on a tablet; see attached screenshot.
 
device-2016-06-06-125202.png
126 KB View Download
Status: Available (was: Untriaged)

Comment 2 by bauerb@chromium.org, Jun 13 2016

Labels: -Pri-2 M-53 Pri-1

Comment 3 by pke@google.com, Jun 15 2016

Owner: pke@google.com
Status: Started (was: Available)

Comment 4 by peconn@chromium.org, Jun 20 2016

Blocking: 617576

Comment 5 by pke@google.com, Jun 21 2016

Labels: zine-mr-iter-20
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6d15de0bd5f2527dec694f4a72a15182ba289f4

commit e6d15de0bd5f2527dec694f4a72a15182ba289f4
Author: pke <pke@google.com>
Date: Tue Jun 21 15:37:29 2016

[Android] Use NTPRecyclerView for peeking card viewport height

Instead of using the height of NewTabPageView, use the height of
NewTabPageRecyclerView as the viewport height for the computation
of the peeking card layout animation.

The view structure is: NTPView -> NTPRecyclerView -> Card.
The NTPView has the dimensions of the entire screen (excluding
Android's status bars). The NTPRecyclerView has the dimensions of
the page content. On phones the two coincide, whereas on tablets
the tabs and address bar take additional space from the NTPView,
which is not included in the NTPRecyclerView. To be visible at the
lower edge of the screen, the peeking card (viewholder) needs the
distance of the lower edge from the top of the parent it is rendered
in. The parent is NTPRecyclerView (not NTPView) and the distance is
the height of the parent (aka the height of the viewport).

BUG= 617577 

Review-Url: https://codereview.chromium.org/2065493007
Cr-Commit-Position: refs/heads/master@{#400997}

[modify] https://crrev.com/e6d15de0bd5f2527dec694f4a72a15182ba289f4/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[modify] https://crrev.com/e6d15de0bd5f2527dec694f4a72a15182ba289f4/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
[modify] https://crrev.com/e6d15de0bd5f2527dec694f4a72a15182ba289f4/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsLayoutOperations.java
[modify] https://crrev.com/e6d15de0bd5f2527dec694f4a72a15182ba289f4/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

Comment 7 by pke@google.com, Jun 21 2016

Status: Fixed (was: Started)

Comment 8 by fi...@chromium.org, Jul 1 2016

Labels: zine-mr-MVP

Comment 9 by finkm@google.com, Jul 1 2016

Labels: -zine-mr-mvp
Labels: zine-mr-MVP
Blocking: -617576

Sign in to add a comment