New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 617573 link

Starred by 1 user
Status: Fixed
Owner:
est...@chromium.org
Closed: Jun 2016
Cc:
nyerramilli@chromium.org
█ tkonch...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessarily alert message at download bar is clickable.

Reported by yfulgaon...@etouch.net, Jun 6 2016 
Chrome version : 53.0.2760.0 (Official Build) 851eb42016eeca7ac932921164bb1fdb3a5844b3-refs/heads/master@{#397956} 32/64 bit
OS :  Windows (7,8,8.1,10), Linux(14.04 LTS)

Test URL : http://download.safebrowsingtest.com/download/test?attredirects=0&d=1

What steps will reproduce the problem?
1) Launch chrome and go to above url. (Alert message is seen at the download bar)
2) Click on the alert message and observe.

Actual : Unnecessarily alert message at download bar is clickable.
Expected : It should not be clickable and if it is clickable then the ripple effect should be fully seen.

This is a regression issue, broken in 'M-51', below is the Manual Bisect and Narrow Bisect info.
Good Build : 51.0.2699.0
Bad Build : 51.0.2700.0

Narrow Bisect info:
https://chromium.googlesource.com/chromium/src/+log/1b66d9cd30ed716b1defc9f4018b0001e0699f1d..7d0b8e68976cdd63274f72e507559d413c7debb8?pretty=fuller&n=10000

Suspecting : r385052 from Narrow Bisect

Note : Above issue is not seen on Mac(10.10.5, 10.11.4) OS.
Actual_download_bar.mp4
751 KB Download
Expec_download_bar.mp4
1.2 MB Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07025e9df358bb0249550d6124b9817333421fc0

commit 07025e9df358bb0249550d6124b9817333421fc0
Author: estade <estade@chromium.org>
Date: Wed Jun 22 16:17:41 2016

MD Download items - fix mode checks to include both dangerous and
malicious as appropriate.

BUG= 617573 

Review-Url: https://codereview.chromium.org/2089923002
Cr-Commit-Position: refs/heads/master@{#401299}

[modify] https://crrev.com/07025e9df358bb0249550d6124b9817333421fc0/chrome/browser/ui/views/download/download_item_view_md.cc

Comment 2 by est...@chromium.org, Jun 22 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment