Issue metadata
Sign in to add a comment
|
Regression: Weird font for 'Import bookmarks now' is observed at bookmark bar after applying theme.
Reported by
jshan...@etouch.net,
Jun 6 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 53.0.2760.0 (Official Build) 851eb42016eeca7ac932921164bb1fdb3a5844b3-refs/heads/master@{#397956} OS: Mac (10.10.5 , 10.11.4),Mac Retina (10.11.4) Pre-condition: Enable 'Material Design in the browser's top chrome' from chrome://flags URL: https://chrome.google.com/webstore/detail/black-red-shards/jpjlkkaalgfbbegfnjoclhfidancjpch?hl=en Steps: 1. Launch Chrome, navigate to above URL and add the theme. 2. Right click on bookmark bar and select 'Show bookmarks bar' from context menu. 3. Observe the font 'Import bookmarks now'. Actual: 'Import bookmarks now' font is not seen properly i.e blue and white color of font is overlapping. Expected: 'Import bookmarks now' font should be seen properly i.e blue color of font should be seen. This is a regression issue broken in M-51, below is bisect info. Good build: 51.0.2663.0 Bad build: 51.0.2664.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/5121a34129f274edc61a288f73f99b39eb06e1e7..b38be38cee2027dcb827ebc61abb23508b8e5d25?pretty=fuller&n=100 Suspecting: r378367 ? Please help to re-assign if your change is not the cause for this issue. Note: This is Mac OS specific issue, not seen on Windows and Linux OS.
,
Jun 7 2016
With response to comment #1, In actual, two font color is seen i.e blue color overlapping white color for 'Import bookmarks now' link. In expected, 'Import bookmarks now' link is seen clearly in blue color.
,
Jun 7 2016
This looks worse on non-Retina. I think the issue is the textfield has a transparent background and is layer-backed, so sub-pixel antialiasing isn't working correctly. tapted@ - any ideas/suggestions for a fix?
,
Jun 7 2016
Except it looks OK in non-Material, and I think the textfield is still layer-backed. I need to investigate more.
,
Jun 8 2016
If the layer backing didn't change, it's possible that a background color now has an alpha channel when it previously didn't. It might be possible to premultiply the colours in theme_properties.cc that do SkColorSetARGB - there shouldn't be any bleed-through in the bookmarks toolbar.
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eadf1aa099669f7a232ee8deed94d5b9d2da14a8 commit eadf1aa099669f7a232ee8deed94d5b9d2da14a8 Author: shrike <shrike@chromium.org> Date: Wed Jun 22 20:33:26 2016 [Mac][Material Design] Fix regression with initial bookmark bar text. [Mac][Material Design] Fix regression with initial bookmark bar text. When you have an empty bookmarks bar, the bar displays a message about adding bookmarks. With the switch to Material Design and the addition of an NSVisualEffectView, the textfields' opaque ancestor was no longer opaque, messing up subpixel anti-aliasing. This cl changes the BookmarkBarToolbarView's isOpaque: method to always return YES. The BookmarkBarToolbarView was in fact always opaque, so returning YES is correct. Doing so causes the BookmarkBarToolbarView's to be the textfields' opaque ancestor, leading to correctly-drawn text. R=tapted@chromium.org BUG= 617550 , 617856 Review-Url: https://codereview.chromium.org/2061353002 Cr-Commit-Position: refs/heads/master@{#401391} [modify] https://crrev.com/eadf1aa099669f7a232ee8deed94d5b9d2da14a8/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm
,
Jun 23 2016
,
Jun 27 2016
,
Jun 27 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5825147fa986abde5d2a293d06d1cac8ac8314e commit d5825147fa986abde5d2a293d06d1cac8ac8314e Author: Jayson Adams <shrike@chromium.org> Date: Mon Jun 27 22:27:42 2016 [Mac][Material Design] Fix regression with initial bookmark bar text. [Mac][Material Design] Fix regression with initial bookmark bar text. When you have an empty bookmarks bar, the bar displays a message about adding bookmarks. With the switch to Material Design and the addition of an NSVisualEffectView, the textfields' opaque ancestor was no longer opaque, messing up subpixel anti-aliasing. This cl changes the BookmarkBarToolbarView's isOpaque: method to always return YES. The BookmarkBarToolbarView was in fact always opaque, so returning YES is correct. Doing so causes the BookmarkBarToolbarView's to be the textfields' opaque ancestor, leading to correctly-drawn text. R=tapted@chromium.org BUG= 617550 , 617856 Review-Url: https://codereview.chromium.org/2061353002 Cr-Commit-Position: refs/heads/master@{#401391} (cherry picked from commit eadf1aa099669f7a232ee8deed94d5b9d2da14a8) Review URL: https://codereview.chromium.org/2100323003 . Cr-Commit-Position: refs/branch-heads/2743@{#490} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/d5825147fa986abde5d2a293d06d1cac8ac8314e/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm
,
Jun 27 2016
,
Jun 30 2016
Tested the same on MacBook Pro Retina 10.11.5 chrome version 52.0.2743.60 - 'Import bookmarks now' font displays fine Please find the screenshot Fix works as expected. Adding TE verified labels |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by shrike@chromium.org
, Jun 6 2016