Print preview: all numbers should be locale formatted (i.e. 1000 => 1,000 for en-US)
Reported by
adha...@etouch.net,
Jun 6 2016
|
|||||
Issue descriptionChrome Version:53.0.2760.0 (Official Build) canary Revision 851eb42016eeca7ac932921164bb1fdb3a5844b3-refs/heads/master@{#397956} (32/64-bit) OS: Windows(7,8,8.1,10) Steps: 1.Launch chrome,Navigate to any webpage(Ex:https://twitter.com/) 2.Give Print command(ctrl+P),click on more settings 3.click on 'quality' dropdownlist and observe. Actual:Unnecessary ',' is seen for 1200 dpi option. Expected:No such ',' should be seen for 1200 dpi option. This is a regression issue broken in M-53 Manual Regression range: Good Build:53.0.2757.0 Bad Build:53.0.2759.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/2ccd36dd90285fc457dca2ba4f7440012bb5ea40..b56bbaad735742d2495bea1e5c9836d96f563e38?pretty=fuller&n=10000 Suspecting:r397608? Please re-assign if your change is not cause of this issue. Note: Issue is not seen on Mac and Linux OS.
,
Jun 20 2016
Just to update. Still able to repro this issue on Google Chrome Latest Canary Version - 53.0.2773.0
,
Jun 23 2016
jshin@: Could you please review the blocker label and update accordingly as we are approaching the M-53 branch point.
,
Jul 1 2016
Just to update. Still able to repro this issue on Google Chrome Latest Canary Version - 53.0.2784.1
,
Jul 7 2016
+dbeam who did the review. It is a bit weird that we have "1,200 dpi", but if I print a 2 page document with 500 copies, print preview says "1000 sheets of paper" at the top.
,
Jul 7 2016
,
Jul 7 2016
thestig@: your wish is my command!
,
Jul 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/314dd0c72e7921f4aec79dd700db5dd3562c3e39 commit 314dd0c72e7921f4aec79dd700db5dd3562c3e39 Author: dbeam <dbeam@chromium.org> Date: Thu Jul 07 18:57:16 2016 Print preview: make page/sheet summary locale aware R=dpapad@chromium.org BUG=617540 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2131603002 Cr-Commit-Position: refs/heads/master@{#404196} [modify] https://crrev.com/314dd0c72e7921f4aec79dd700db5dd3562c3e39/chrome/browser/resources/print_preview/print_header.js
,
Jul 7 2016
i'll let jshin@ look through the dark corners
,
Jul 25 2016
Wow... it'll be rather hard to find other cases because there's no specific string signature to look for. Well, search in JS would be hopeless, but search in grd should turn up something. Actually, bug 613331 caught/fixed a few in JS (e.g. print preview dpi was fixed 3 days before this bug report in ToT.) by grd search. I'll look for more.
,
Jul 27 2017
The "Pages" error message still does not have commas when the number of pages is > 999 (print preview a 1000+ page document and then enter a page number larger than the max page in the "Pages" field). Any other issues still exist for this? |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tkonch...@chromium.org
, Jun 6 2016