Add the unpacked extension.

Deleted: DebuggerCallframe.7z 1.9 KB

DebuggerCallframe.7z 1.9 KB Download

Adding more detail about the extension in the attachement.
Background page will attach to each web page via chrome.debugger API and listen on "Debugger.paused" event. If a breakpoint is triggered, the callframes will be printed in the console of the background page.
In content script(ContentScriptWorker.js), "debugger" instruction will be called after some delay(to make sure background is attached to current page). 
I'm expecting to get the callframes of the content script code. The callframes are always empty in chrome version 51 while the callframes are correct in version 50 and 46. There seems to be something wrong in version 51.
Please compare the console log from the attachment for version 51 and version before 51.  

Deleted: 51.PNG 143 KB

	51.PNG 143 KB View Download

Deleted: before 51.PNG 139 KB

	before 51.PNG 139 KB View Download

Thanks for the repro steps!

Narrow bisect done.  Suspecting commit:
https://chromium.googlesource.com/chromium/src/+/3ba0c2fb4f8ecd2315828043d4e5508915c2f99c

Thanks for the quick investigation.

My company developed a extension and plan to release it around August. This extension depends on chrome debugger mechanism heavily. It breaks on version 51 due to the bug I submitted. May I know the time frame you plan to fix this bug? It would be great if this bug can be fix in a stable version released before August. 

Thanks & Regards

Patch is on the way: https://codereview.chromium.org/2064133002/

A friendly reminder that M52 Stable is launching soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch by July 12. All changes MUST be merged into the release branch by 5pm on July 15 to make into the desktop Stable final build cut. Thank you!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/151d5d907870e262ff7f94fd4b1f1e5ef887e96d

commit 151d5d907870e262ff7f94fd4b1f1e5ef887e96d
Author: dgozman <dgozman@chromium.org>
Date: Mon Jun 20 20:34:57 2016

[DevTools] Explicitly reset context group when clearing ScriptController.

Previously, we assumed that main world context creation means reset.
This is not the case when content script is executed before main world script,
and we ended up with content script context being cleared from debugger.
Now we get explicit notification from ScriptController to reset (mainly on navigation).

BUG= 617530 

Review-Url: https://codereview.chromium.org/2064133002
Cr-Commit-Position: refs/heads/master@{#400770}

[modify] https://crrev.com/151d5d907870e262ff7f94fd4b1f1e5ef887e96d/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/151d5d907870e262ff7f94fd4b1f1e5ef887e96d/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
[modify] https://crrev.com/151d5d907870e262ff7f94fd4b1f1e5ef887e96d/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/151d5d907870e262ff7f94fd4b1f1e5ef887e96d/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

@dgozman: Could you please have a look at the attached video and let us know if this is the expected behavior. If yes, we can add the TE-Verified labels.

Thank you.

Deleted: 617530.mp4 1.4 MB

	617530.mp4 1.4 MB View Download

Re #c10: you have to open DevTools window not for the page, but for the extension: go to chrome://extensions and click on "Inspect views: background page" link for the installed extension. There, you should see "size of callframes is 4".

** IMPORTANT change in M52 merge date due to first 2 weeks of July no release weeks **
M52 Stable is launching very soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged ASAP. All changes MUST be merged into the release branch by 5pm on July 1 to make into the desktop Stable final build cut. Thank you!

Could you please verify this issue? See #c10 and #c11 for more details.

@dgozman: Unable to repro this issue on Windows 7 for Google Chrome Stable Version - 51.0.2704.106 

"Size of Call callframes is 4" is displayed for www.google.com with the flag "#silent-debugger-extension-api" enabled.

Screen-recording is attached.

COuld you please let us know if this is the correct procedure.

Thank you.

Thank you for verification, that's perfect! Requesting merge to M52.

Your change meets the bar and is auto-approved for M52 (branch: 2743)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87c1e7416fb66c6892abb38d9295c611e03e1157

commit 87c1e7416fb66c6892abb38d9295c611e03e1157
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Jun 28 17:19:56 2016

Merge to 2743 "[DevTools] Explicitly reset context group when clearing ScriptController."
> [DevTools] Explicitly reset context group when clearing ScriptController.
>
> Previously, we assumed that main world context creation means reset.
> This is not the case when content script is executed before main world script,
> and we ended up with content script context being cleared from debugger.
> Now we get explicit notification from ScriptController to reset (mainly on navigation).
>
> BUG= 617530 
>
> Review-Url: https://codereview.chromium.org/2064133002
> Cr-Commit-Position: refs/heads/master@{#400770}
(cherry picked from commit 151d5d907870e262ff7f94fd4b1f1e5ef887e96d)
TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/2105853002 .

Cr-Commit-Position: refs/branch-heads/2743@{#505}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/87c1e7416fb66c6892abb38d9295c611e03e1157/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/87c1e7416fb66c6892abb38d9295c611e03e1157/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
[modify] https://crrev.com/87c1e7416fb66c6892abb38d9295c611e03e1157/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/87c1e7416fb66c6892abb38d9295c611e03e1157/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

Verified the fix on Windows 7 for Google Chrome Beta Version - 52.0.2743.60

Followed the steps in the comment #15

Screen-shot is attached.

TE-Verified labels are attached.

Deleted: 617530.png 115 KB

	617530.png 115 KB View Download